Page MenuHomePhabricator

[lib] Deprecate `updateRolesAndPermissions`
ClosedPublic

Authored by atul on Jun 27 2024, 2:05 PM.
Tags
None
Referenced Files
F3249438: D12599.id42169.diff
Fri, Nov 15, 2:43 PM
F3249212: D12599.id42168.diff
Fri, Nov 15, 12:41 PM
Unknown Object (File)
Mon, Nov 11, 4:49 PM
Unknown Object (File)
Mon, Nov 11, 4:42 PM
Unknown Object (File)
Mon, Nov 11, 4:28 PM
Unknown Object (File)
Mon, Nov 11, 4:22 PM
Unknown Object (File)
Mon, Nov 11, 3:21 PM
Unknown Object (File)
Mon, Nov 11, 11:48 AM
Subscribers

Details

Summary

We want to deprecate this function because it's no longer relevant for *RawThreadInfos without member permissions.

We're keeping it around to ensure existing migrations work as expected.


Depends on D12598

Test Plan

This diff is just a rename to make it clear function shouldn't be used in future. Looked at all callsites and ensured there's nothing preventing function from being deprecated.

Diff Detail

Repository
rCOMM Comm
Branch
july26 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Jun 27 2024, 2:14 PM

Is the idea here that we'll never need to run deprecatedUpdateRolesAndPermissions again when we change permissions, since we're not storing the permissions in the ThreadStore at all?

And that permission checks in the future will be computed on-the-fly based on the user's role in the relevant thread and its ancestors?

This revision is now accepted and ready to land.Jul 1 2024, 1:05 PM

Safe to land out of order since it's purely rename

This revision was landed with ongoing or failed builds.Jul 9 2024, 12:42 PM
This revision was automatically updated to reflect the committed changes.
This revision is now accepted and ready to land.Jul 9 2024, 1:17 PM

re-open to address eslint thing

JK, the ESLint issue was in revision one before the one that landed. Re-landing.

This revision was landed with ongoing or failed builds.Jul 9 2024, 1:27 PM
This revision was automatically updated to reflect the committed changes.