Details

Reviewers

Commits

rCOMMfc1e4abe9c83: [lib] Deprecate `updateRolesAndPermissions`
rCOMMad00e8286547: [lib] Deprecate `updateRolesAndPermissions`

Summary

We want to deprecate this function because it's no longer relevant for *RawThreadInfos without member permissions.

We're keeping it around to ensure existing migrations work as expected.

Depends on D12598

Test Plan

This diff is just a rename to make it clear function shouldn't be used in future. Looked at all callsites and ensured there's nothing preventing function from being deprecated.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 27 2024, 2:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2024, 2:05 PM

atul published this revision for review.Jun 27 2024, 2:14 PM

atul added a child revision: D12601: [lib] Add `flow` suppression to `deprecatedDecodeMinimallyEncodedRawThreadInfo`.Jun 27 2024, 2:16 PM

Harbormaster failed remote builds in B29973: Diff 41772!Jun 27 2024, 2:19 PM

Is the idea here that we'll never need to run deprecatedUpdateRolesAndPermissions again when we change permissions, since we're not storing the permissions in the ThreadStore at all?

And that permission checks in the future will be computed on-the-fly based on the user's role in the relevant thread and its ancestors?

This revision is now accepted and ready to land.Jul 1 2024, 1:05 PM

resolve merge conflict

Harbormaster failed remote builds in B30232: Diff 42155!Jul 9 2024, 11:19 AM

resequence

Safe to land out of order since it's purely rename

This revision was landed with ongoing or failed builds.Jul 9 2024, 12:42 PM

Closed by commit rCOMMad00e8286547: [lib] Deprecate `updateRolesAndPermissions` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMad00e8286547: [lib] Deprecate `updateRolesAndPermissions`.

Harbormaster failed remote builds in B30238: Diff 42168!Jul 9 2024, 12:50 PM

atul added a reverting change: rCOMM1377f88ecd03: Revert "[lib] Deprecate `updateRolesAndPermissions`".Jul 9 2024, 1:15 PM