Page MenuHomePhabricator

[SQLite] Introduce getRelatedMessages
ClosedPublic

Authored by ashoat on Jul 14 2024, 6:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 3:22 AM
Unknown Object (File)
Fri, Oct 18, 10:29 PM
Unknown Object (File)
Fri, Oct 18, 10:24 PM
Unknown Object (File)
Mon, Oct 14, 1:34 PM
Unknown Object (File)
Sep 25 2024, 8:25 PM
Unknown Object (File)
Sep 18 2024, 6:59 PM
Unknown Object (File)
Sep 16 2024, 1:32 PM
Unknown Object (File)
Sep 15 2024, 10:07 AM
Subscribers
None

Details

Summary

I'm modelling this stack after @kamil's recent one (see D12080) that introduced functions to SQLiteAPI. First I'm introducing the shared SQLite C++ code, and then I will introduce the layers on native and web that will interact with it. This diff also contains some web-specific customizations necessary on the SQLite C++ code.

This query will be used for:

  1. Querying for a sidebar source's latest edit at sidebar creation time (ENG-8788)
  2. Querying for a messages edits and reactions for search results (ENG-87890)
Test Plan
  1. In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
  2. I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 15 2024, 2:52 AM
ashoat retitled this revision from [SQLite] Introduce getLatestMessageEdit to [SQLite] Introduce getRelatedMessages.
ashoat edited the summary of this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)

Rework into getRelatedMessages, which can be reused for rendering search results

This revision was automatically updated to reflect the committed changes.