Paths

Table of Contentst

[SQLite] implement query for searching messages
ClosedPublic
Actions

Authored by kamil on Jul 22 2024, 5:15 PM.

Details

Reviewers

tomek
inka

Commits

rCOMM3b9546b1e346: [SQLite] implement query for searching messages

Summary

Query similar to keyserver version.

Depends on D12843

Test Plan

Tested in D12851

Diff Detail

Repository

rCOMM Comm

Branch

cpp-search-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 22 2024, 5:15 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 22 2024, 5:15 PM

Harbormaster failed remote builds in B30573: Diff 42637!Jul 22 2024, 5:35 PM

rebase

kamil added a child revision: D12850: [SQLite] add Emscripten bindings for message search.Jul 23 2024, 9:53 AM

kamil edited the test plan for this revision. (Show Details)Jul 23 2024, 9:55 AM

Harbormaster completed remote builds in B30592: Diff 42666.Jul 23 2024, 10:12 AM

kamil published this revision for review.Jul 23 2024, 12:03 PM

kamil mentioned this in D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2574	there is no `;` on purpose
2589	we can't use this becuase this will require adding `folly` dependency to `.wasm`

tomek accepted this revision.Jul 23 2024, 1:15 PM

inka accepted this revision.Jul 23 2024, 1:22 PM

This revision is now accepted and ready to land.Jul 23 2024, 1:22 PM

Closed by commit rCOMM3b9546b1e346: [SQLite] implement query for searching messages. · Explain WhyJul 23 2024, 3:18 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3b9546b1e346: [SQLite] implement query for searching messages.

ashoat added inline comments.Aug 1 2024, 1:52 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2589	Maybe I shouldn't have abandoned D12761

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

45 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

Diff 42666

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp