Page MenuHomePhabricator

[lib][web][native] Create message search store ops
ClosedPublic

Authored by inka on Jul 22 2024, 2:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 11:26 AM
Unknown Object (File)
Thu, Oct 24, 1:40 AM
Unknown Object (File)
Fri, Oct 18, 3:34 PM
Unknown Object (File)
Fri, Oct 18, 6:48 AM
Unknown Object (File)
Thu, Oct 17, 5:59 PM
Unknown Object (File)
Thu, Oct 17, 7:09 AM
Unknown Object (File)
Mon, Oct 14, 4:11 PM
Unknown Object (File)
Mon, Oct 14, 4:11 PM
Subscribers

Details

Summary

issue: ENG-8647

Test Plan

Tested by removnig the extractKeyserverIDFromIDOptional(messageInfo.threadID) condition from getMessageSearchStoreOps. Tested that on web and native if replace message ops are present, update ops are created for the search table, and updateMessageSearchIndex is called

Diff Detail

Repository
rCOMM Comm
Branch
inka/search
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 22 2024, 2:12 AM
Harbormaster failed remote builds in B30557: Diff 42604!
inka requested review of this revision.Jul 22 2024, 3:12 AM
tomek added inline comments.
lib/handlers/db-ops-handler.react.js
89–96 ↗(On Diff #42604)

I'm not sure where's the best place to put this logic. DBOpsHandler wasn't supposed to understand the content of the ops. db-ops-reducer.js could be a better place, because reducers handle business logic. What do you think?

This revision is now accepted and ready to land.Jul 22 2024, 5:01 AM

Move code to db-ops-reducer.js