issue: ENG-8882
Removing code that is irrelevant to nux overlay.
Mind that this diff is only supposed to be removing unnecessary code. Name changes and so on will follow in the next diffs
Details
Details
Tested by creating a component wuth this createTooltip, and navigating to it. It appears correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/tooltip/nux-tips-overlay.react.js | ||
|---|---|---|
| 119 ↗ | (On Diff #42961) | This will be updated in later diffs |
| 122 ↗ | (On Diff #42961) | We will always have the tooltip be "below" |
| 124 ↗ | (On Diff #42961) | We will be displaying text, not a list of entries |
| 125 ↗ | (On Diff #42961) | We will be displaying the tips in a place where chat input bar is not present |
| 228 ↗ | (On Diff #42961) | This is vibration. I don't think we want the phone to vibrate when showing tips |
| 297–302 ↗ | (On Diff #42961) | We don't need this customisation |
| 386–390 ↗ | (On Diff #42961) | This was moved directly to tooltip. In later diffs MenuComponent will be replaced with some fixed component that only takes text |
| 424–425 ↗ | (On Diff #42961) | Because the nux tips will always be below the item they are pointing to, we only need the triangleUp |
| 435 ↗ | (On Diff #42961) | This is needed for transitions when opening a sidebar and the message slides into the sidebar. We don't need this |
| native/tooltip/nux-tips-overlay.react.js | ||
|---|---|---|
| 343–345 ↗ | (On Diff #42961) | This doesn't seem to do anything. |
| native/tooltip/nux-tips-overlay.react.js | ||
|---|---|---|
| 343–345 ↗ | (On Diff #42961) | This is removed in the next diff |
Comment Actions
Love the approach you took here of first copying the code, and then submitting a second diff to clear out the irrelevant stuff. It makes it much easier to review!