Page MenuHomePhabricator

[lib] implement action for sending DM messages
ClosedPublic

Authored by kamil on Aug 23 2024, 5:42 AM.
Tags
None
Referenced Files
F3193605: D13155.id43640.diff
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 2:29 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Thu, Oct 24, 4:19 PM
Unknown Object (File)
Thu, Oct 24, 4:15 PM
Unknown Object (File)
Sat, Oct 19, 2:33 PM
Unknown Object (File)
Sat, Oct 19, 2:33 PM
Unknown Object (File)
Sat, Oct 19, 2:32 PM
Subscribers

Details

Summary

ENG-8423.

Action dispatched when processing DM Operation, sucess will be dispatched when Tunnelbroker finished queueing messages.

SEND_DM_FAILED is not needed but implemented it this way to use dispatchActionPromise.

Depends on D13154

Test Plan

Test dispatching this action.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Branch
landing-dms
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
lib/reducers/message-reducer.js
1878 ↗(On Diff #43612)

I think we should remove the local entry when remainingOutboundP2PMessageIDs.length === 0.

kamil published this revision for review.Aug 23 2024, 7:26 AM
kamil added inline comments.
lib/reducers/message-reducer.js
1893 ↗(On Diff #43612)

this is used to show message in progress in UI when retrying

tomek added inline comments.
lib/reducers/message-reducer.js
1865 ↗(On Diff #43612)

We should create a Set from it before filtering.

1878 ↗(On Diff #43612)

Agree

lib/types/redux-types.js
1596 ↗(On Diff #43612)

Do you think it makes sense to rename this type?

This revision is now accepted and ready to land.Aug 26 2024, 4:17 AM
  • rename type
  • use Set
  • remove local entry after success