Page MenuHomePhabricator
Differential D13177

[native] Create home tab tip
ClosedPublic
Actions

Authored by inka on Tue, Aug 27, 8:58 AM.
Tags
None
Referenced Files
F2770553: D13177.id43733.diff
Thu, Sep 19, 8:50 PM
Unknown Object (File)
Wed, Sep 18, 7:55 AM
Unknown Object (File)
Tue, Sep 17, 10:26 PM
Unknown Object (File)
Tue, Sep 17, 5:37 AM
Unknown Object (File)
Tue, Sep 17, 12:33 AM
Unknown Object (File)
Fri, Sep 13, 5:15 AM
Unknown Object (File)
Thu, Sep 12, 9:51 AM
Unknown Object (File)
Wed, Sep 11, 11:53 AM
View All 28 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMe3d8a3f29e67: [native] Create home tab tip
Summary

issue: ENG-9063

Test Plan

Tested that it shows up after the community drawer tip and pressing ok navigates to the muted tab tip

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Tue, Aug 27, 8:58 AM
Herald added a subscriber: ashoat. · View Herald TranscriptTue, Aug 27, 8:58 AM
inka mentioned this in D13178: [native] Move ChatTabBarButton.Tue, Aug 27, 8:59 AM
inka added a parent revision: D13178: [native] Move ChatTabBarButton.Tue, Aug 27, 9:00 AM
Harbormaster completed remote builds in B31297: Diff 43698.Tue, Aug 27, 9:15 AM
inka requested review of this revision.Tue, Aug 27, 9:15 AM
inka added a child revision: D13179: [native] Make possible to render tip not pointing to anything.Tue, Aug 27, 10:04 AM
tomek accepted this revision.Wed, Aug 28, 3:56 AM
This revision is now accepted and ready to land.Wed, Aug 28, 3:56 AM
inka updated this revision to Diff 43733.Wed, Aug 28, 4:15 AM

Rebase

Harbormaster completed remote builds in B31325: Diff 43733.Wed, Aug 28, 4:35 AM
Closed by commit rCOMMe3d8a3f29e67: [native] Create home tab tip (authored by inka). · Explain WhyThu, Aug 29, 6:43 AM
This revision was automatically updated to reflect the committed changes.
inka mentioned this in rCOMM4434329e0518: [native] Move ChatTabBarButton.
inka added a commit: rCOMMe3d8a3f29e67: [native] Create home tab tip.

Revision Contents
Changeset List

PathSize
native/
components/
10 lines
navigation/
3 lines
22 lines
2 lines
3 lines

Diff 43698

View Options

native/components/nux-tips-context.react.js

Loading...
View Options

native/navigation/app-navigator.react.js

Loading...
View Options

native/navigation/home-tab-tip.react.js

Loading...
View Options

native/navigation/overlay-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...