Paths

Table of Contentst

Differential D13179

[native] Make possible to render tip not pointing to anything
ClosedPublic
Actions

Authored by inka on Aug 27 2024, 10:03 AM.

Tags

None

Referenced Files

	F3643675: D13179.id43806.diff
	Sat, Jan 4, 5:40 PM

	F3643674: D13179.id43734.diff
	Sat, Jan 4, 5:40 PM

	F3643673: D13179.id43701.diff
	Sat, Jan 4, 5:40 PM

	F3643662: D13179.id.diff
	Sat, Jan 4, 5:40 PM

	F3643655: D13179.diff
	Sat, Jan 4, 5:39 PM

	Unknown Object (File)
	Tue, Dec 31, 12:10 AM

	Unknown Object (File)
	Thu, Dec 26, 2:36 AM

	Unknown Object (File)
	Tue, Dec 17, 8:38 PM

View All 66 Files

Subscribers

Details

Reviewers

tomek
will

Commits

rCOMM0171af76e7be: [native] Make possible to render tip not pointing to anything

Summary

issue: ENG-9062
the intro tip will not be pointing to anything

Test Plan

tested with the next diff:

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 27 2024, 10:03 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2024, 10:03 AM

inka added a parent revision: D13177: [native] Create home tab tip.Aug 27 2024, 10:04 AM

inka edited the test plan for this revision. (Show Details)

inka attached a referenced file: F2559097: Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-27 at 18.55.48.mp4. (Show Details)

inka added a child revision: D13180: [native] Create intro tip.Aug 27 2024, 10:07 AM

Harbormaster completed remote builds in B31300: Diff 43701.Aug 27 2024, 10:25 AM

inka requested review of this revision.Aug 27 2024, 10:25 AM

tomek accepted this revision.Aug 28 2024, 4:06 AM

tomek added inline comments.

native/tooltip/nux-tips-overlay.react.js
134–137 ↗	(On Diff #43701)	I guess you can have a single invariant for these

This revision is now accepted and ready to land.Aug 28 2024, 4:06 AM

Address review

Harbormaster completed remote builds in B31326: Diff 43734.Aug 28 2024, 4:38 AM

Closed by commit rCOMM0171af76e7be: [native] Make possible to render tip not pointing to anything (authored by inka). · Explain WhyAug 29 2024, 6:44 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM0171af76e7be: [native] Make possible to render tip not pointing to anything.

Just some style nits. Please note that we need to handle styling ourselves inside of prettier-ignore

native/tooltip/nux-tips-overlay.react.js
321 ↗	(On Diff #43806)	The worklet has to be wrapped with `prettier-ignore` to avoid stripping the Flow comment annotations, but that means we have to handle the styling ourselves
331 ↗	(On Diff #43806)	Whitespace issue here too

inka mentioned this in D13585: [native] Fix styling in animation code.Oct 3 2024, 3:05 AM

inka mentioned this in rCOMMee7e376f90ec: [native] Fix styling in animation code.Oct 4 2024, 3:25 AM

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

75 lines

Diff 43734

native/tooltip/nux-tips-overlay.react.js

Loading...