Page MenuHomePhabricator
Differential D13330

[web][native][lib] deprecate `sendDMActionTypes` and simplify hooks
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 4:16 AM.
Tags
None
Referenced Files
F3233063: D13330.id44225.diff
Tue, Nov 12, 2:28 PM
Unknown Object (File)
Sat, Nov 9, 7:23 AM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:56 PM
Unknown Object (File)
Fri, Oct 18, 8:36 AM
Unknown Object (File)
Wed, Oct 16, 1:35 AM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMd83c2d52351f: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks
Summary

ENG-8424.

This removes code, now we use dedicated actions for composable messages. Some more context about why this is better in D13290.

Depends on D13329

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 13 2024, 4:16 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 4:16 AM
kamil edited the summary of this revision. (Show Details)Sep 13 2024, 4:17 AM
kamil added a parent revision: D13329: [web][native] update `InputStateContainer` logic for sending text messages.
kamil removed a parent revision: D13327: [lib] implement hook to send composable DMOperation.
kamil added a child revision: D13331: [lib] implement hook to send text multimedia message from `InputStateContainer`.Sep 13 2024, 4:20 AM
Harbormaster completed remote builds in B31599: Diff 44144.Sep 13 2024, 4:32 AM
kamil published this revision for review.Sep 13 2024, 4:40 AM
tomek accepted this revision.Sep 13 2024, 7:01 AM
This revision is now accepted and ready to land.Sep 13 2024, 7:01 AM
kamil updated this revision to Diff 44211.Sep 16 2024, 3:10 AM

rebase

kamil mentioned this in D13325: [lib] update `processOutboundP2PMessages` to return failed message IDs.Sep 16 2024, 3:20 AM
Harbormaster completed remote builds in B31639: Diff 44211.Sep 16 2024, 3:32 AM
Closed by commit rCOMMd83c2d52351f: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks (authored by kamil). · Explain WhySep 16 2024, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd83c2d52351f: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks.

Revision Contents
Changeset List

PathSize
lib/
reducers/
59 lines
shared/
dm-ops/
65 lines
types/
15 lines
18 lines
native/
chat/
21 lines
web/
chat/
20 lines

Diff 44211

View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/chat/failed-send.react.js

Loading...
View Options

web/chat/failed-send.react.js

Loading...