Page MenuHomePhabricator
Differential D13803

[identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
ClosedPublic
Actions

Authored by kamil on Oct 29 2024, 7:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 25, 2:06 AM
Unknown Object (File)
Sun, Apr 20, 2:29 AM
Unknown Object (File)
Sat, Apr 19, 11:47 AM
Unknown Object (File)
Sat, Apr 19, 10:56 AM
Unknown Object (File)
Sat, Apr 19, 7:38 AM
Unknown Object (File)
Fri, Apr 18, 8:19 PM
Unknown Object (File)
Fri, Apr 18, 12:16 AM
Unknown Object (File)
Wed, Apr 9, 3:49 AM
View All 75 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
Summary

ENG-6145.

We'll need to use this on backup, to be able to call FindUserID RPC based on public user identifier - we need to somehow know if this is a Password or Wallet user

Test Plan

Run unit tests in Identity and comm-lib

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Oct 29 2024, 7:47 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 29 2024, 7:47 AM
kamil added a child revision: D13805: [commtest] use registered `UserIdentity` in backup tests.Oct 29 2024, 7:59 AM
Harbormaster failed remote builds in B32399: Diff 45421!Oct 29 2024, 8:01 AM
kamil updated this revision to Diff 45424.Oct 29 2024, 8:25 AM

CI

kamil updated this revision to Diff 45425.Oct 29 2024, 8:33 AM

CI v2

Harbormaster failed remote builds in B32402: Diff 45424!Oct 29 2024, 8:38 AM
Harbormaster completed remote builds in B32403: Diff 45425.Oct 29 2024, 8:50 AM
kamil published this revision for review.Oct 30 2024, 9:28 AM
varun accepted this revision.Oct 30 2024, 10:18 AM
This revision is now accepted and ready to land.Oct 30 2024, 10:18 AM
bartek accepted this revision.Nov 4 2024, 4:56 AM
Closed by commit rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib` (authored by kamil). · Explain WhyNov 7 2024, 4:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`.
kamil mentioned this in D13893: [terraform] deploy backup 0.5.0 to staging.Nov 7 2024, 4:12 AM
kamil mentioned this in rCOMM4c2bf6a62dff: [terraform] deploy backup 0.5.0 to staging.Nov 7 2024, 4:36 AM
kamil mentioned this in D13904: [terraform] deploy backup 0.5.0 to prod.Nov 12 2024, 4:03 AM
kamil mentioned this in rCOMM54cc6a82a876: [terraform] deploy backup 0.5.0 to prod.Nov 13 2024, 2:33 AM

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
services/
backup/
1 line
identity/
1 line
src/
7 lines
46 lines
shared/
comm-lib/
1 line
src/
crypto/
1 line
52 lines
web/
backup-client-wasm/

Diff 45425

View Options

Cargo.lock

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesfunction ConnectFarcaster(prop: Props): React.Node {
const [webViewState, setWebViewState] = const [webViewState, setWebViewState] =
React.useState<FarcasterWebViewState>('closed'); React.useState<FarcasterWebViewState>('closed');
const { ethereumAccount } = cachedSelections; const { ethereumAccount } = cachedSelections;
const goToNextStep = React.useCallback( const goToNextStep = React.useCallback(
(fid?: ?string) => { (fid?: ?string) => {
setWebViewState('closed'); setWebViewState('closed');
invariant(
!ethereumAccount || ethereumAccount.nonceTimestamp,
'nonceTimestamp must be set after connecting to ethereum account',
);
const nonceExpired = const nonceExpired =
ethereumAccount && siweNonceExpired(ethereumAccount.nonceTimestamp); ethereumAccount &&
ethereumAccount.nonceTimestamp &&
siweNonceExpired(ethereumAccount.nonceTimestamp);
if (nonceExpired) { if (nonceExpired) {
setCachedSelections(oldUserSelections => ({ setCachedSelections(oldUserSelections => ({
...oldUserSelections, ...oldUserSelections,
ethereumAccount: undefined, ethereumAccount: undefined,
})); }));
} }
if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) { if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) {
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines
View Options

native/native_rust_library/Cargo.lock

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesfunction ConnectFarcaster(prop: Props): React.Node {
const [webViewState, setWebViewState] = const [webViewState, setWebViewState] =
React.useState<FarcasterWebViewState>('closed'); React.useState<FarcasterWebViewState>('closed');
const { ethereumAccount } = cachedSelections; const { ethereumAccount } = cachedSelections;
const goToNextStep = React.useCallback( const goToNextStep = React.useCallback(
(fid?: ?string) => { (fid?: ?string) => {
setWebViewState('closed'); setWebViewState('closed');
invariant(
!ethereumAccount || ethereumAccount.nonceTimestamp,
'nonceTimestamp must be set after connecting to ethereum account',
);
const nonceExpired = const nonceExpired =
ethereumAccount && siweNonceExpired(ethereumAccount.nonceTimestamp); ethereumAccount &&
ethereumAccount.nonceTimestamp &&
siweNonceExpired(ethereumAccount.nonceTimestamp);
if (nonceExpired) { if (nonceExpired) {
setCachedSelections(oldUserSelections => ({ setCachedSelections(oldUserSelections => ({
...oldUserSelections, ...oldUserSelections,
ethereumAccount: undefined, ethereumAccount: undefined,
})); }));
} }
if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) { if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) {
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines
View Options

services/backup/Cargo.toml

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesfunction ConnectFarcaster(prop: Props): React.Node {
const [webViewState, setWebViewState] = const [webViewState, setWebViewState] =
React.useState<FarcasterWebViewState>('closed'); React.useState<FarcasterWebViewState>('closed');
const { ethereumAccount } = cachedSelections; const { ethereumAccount } = cachedSelections;
const goToNextStep = React.useCallback( const goToNextStep = React.useCallback(
(fid?: ?string) => { (fid?: ?string) => {
setWebViewState('closed'); setWebViewState('closed');
invariant(
!ethereumAccount || ethereumAccount.nonceTimestamp,
'nonceTimestamp must be set after connecting to ethereum account',
);
const nonceExpired = const nonceExpired =
ethereumAccount && siweNonceExpired(ethereumAccount.nonceTimestamp); ethereumAccount &&
ethereumAccount.nonceTimestamp &&
siweNonceExpired(ethereumAccount.nonceTimestamp);
if (nonceExpired) { if (nonceExpired) {
setCachedSelections(oldUserSelections => ({ setCachedSelections(oldUserSelections => ({
...oldUserSelections, ...oldUserSelections,
ethereumAccount: undefined, ethereumAccount: undefined,
})); }));
} }
if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) { if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) {
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines
View Options

services/identity/Cargo.toml

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesfunction ConnectFarcaster(prop: Props): React.Node {
const [webViewState, setWebViewState] = const [webViewState, setWebViewState] =
React.useState<FarcasterWebViewState>('closed'); React.useState<FarcasterWebViewState>('closed');
const { ethereumAccount } = cachedSelections; const { ethereumAccount } = cachedSelections;
const goToNextStep = React.useCallback( const goToNextStep = React.useCallback(
(fid?: ?string) => { (fid?: ?string) => {
setWebViewState('closed'); setWebViewState('closed');
invariant(
!ethereumAccount || ethereumAccount.nonceTimestamp,
'nonceTimestamp must be set after connecting to ethereum account',
);
const nonceExpired = const nonceExpired =
ethereumAccount && siweNonceExpired(ethereumAccount.nonceTimestamp); ethereumAccount &&
ethereumAccount.nonceTimestamp &&
siweNonceExpired(ethereumAccount.nonceTimestamp);
if (nonceExpired) { if (nonceExpired) {
setCachedSelections(oldUserSelections => ({ setCachedSelections(oldUserSelections => ({
...oldUserSelections, ...oldUserSelections,
ethereumAccount: undefined, ethereumAccount: undefined,
})); }));
} }
if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) { if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) {
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines
View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesfunction ConnectFarcaster(prop: Props): React.Node {
const [webViewState, setWebViewState] = const [webViewState, setWebViewState] =
React.useState<FarcasterWebViewState>('closed'); React.useState<FarcasterWebViewState>('closed');
const { ethereumAccount } = cachedSelections; const { ethereumAccount } = cachedSelections;
const goToNextStep = React.useCallback( const goToNextStep = React.useCallback(
(fid?: ?string) => { (fid?: ?string) => {
setWebViewState('closed'); setWebViewState('closed');
invariant(
!ethereumAccount || ethereumAccount.nonceTimestamp,
'nonceTimestamp must be set after connecting to ethereum account',
);
const nonceExpired = const nonceExpired =
ethereumAccount && siweNonceExpired(ethereumAccount.nonceTimestamp); ethereumAccount &&
ethereumAccount.nonceTimestamp &&
siweNonceExpired(ethereumAccount.nonceTimestamp);
if (nonceExpired) { if (nonceExpired) {
setCachedSelections(oldUserSelections => ({ setCachedSelections(oldUserSelections => ({
...oldUserSelections, ...oldUserSelections,
ethereumAccount: undefined, ethereumAccount: undefined,
})); }));
} }
if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) { if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) {
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines
View Options

services/identity/src/siwe.rs

Loading...
View Options

shared/comm-lib/Cargo.toml

Loading...
View Options

shared/comm-lib/src/crypto/mod.rs

Loading...
View Options

shared/comm-lib/src/crypto/siwe.rs

Loading...
View Options

web/backup-client-wasm/Cargo.lock

Loading...