[lib] Fetch older messages when showInMessagePreview rejects messages in local store
Needs ReviewPublic
Actions

Authored by ashoat on Wed, Oct 30, 11:49 AM.

Details

Reviewers

tomek

Summary

This diff implements "Potential solution 3" described on Linear here.

Depends on D13830

Test Plan

Tested in combination with the rest of the stack:

Make sure membership operations (user joining / leaving) don't appear in MessagePreview
Make sure reactions to the viewer's messages still appear in MessagePreview
Make sure reactions to other user's messages don't appear in MessagePreview
Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

lib/hooks/message-hooks.js
127	I included this `sleep` here for two reasons: In case we need repeated fetches, I figured it would be better for performance to avoid having them all occur in rapid succession. There may be some delay between when the call resolves and when the Redux store is updated. Ideally we would watch the Redux store and flip `setCanFetchOlderMessages` when the new messages come in, but that would be rather complicated.

ashoat requested review of this revision.Wed, Oct 30, 1:20 PM

Path

Size

lib/

hooks/

24 lines