Page MenuHomePhabricator

[lib] Rename useCreateChatThreadItem to useGetChatThreadItemLoader
ClosedPublic

Authored by ashoat on Wed, Dec 11, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 2:51 PM
Unknown Object (File)
Sat, Dec 21, 9:32 AM
Unknown Object (File)
Fri, Dec 20, 4:15 PM
Unknown Object (File)
Thu, Dec 19, 9:26 PM
Unknown Object (File)
Thu, Dec 19, 4:42 PM
Unknown Object (File)
Thu, Dec 19, 2:21 PM
Unknown Object (File)
Wed, Dec 18, 7:24 PM
Unknown Object (File)
Wed, Dec 18, 12:58 PM
Subscribers
None

Details

Summary
  1. Renames the type CreatedChatThreadItem to ChatThreadItemLoader
  2. Renames the hook useCreateChatThreadItem to useGetChatThreadItemLoader

These renames make sense in light of the parent diffs, where we lifted some stuff into the CreatedChatThreadItem type, which can now be thought of as handling a transition between initialChatThreadItem and getFinalChatThreadItem.

Depends on D14138

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage