Page MenuHomePhabricator

[native] Add loading indicator at the bottom of ChatThreadList
ClosedPublic

Authored by ashoat on Wed, Dec 11, 3:51 PM.
Tags
None
Referenced Files
F3515073: D14143.id46443.diff
Sun, Dec 22, 7:23 AM
F3515052: D14143.id46362.diff
Sun, Dec 22, 7:16 AM
F3515032: D14143.id46369.diff
Sun, Dec 22, 7:08 AM
F3513869: D14143.diff
Sun, Dec 22, 2:29 AM
F3512970: D14143.id46371.diff
Sat, Dec 21, 9:27 PM
F3511034: D14143.id46445.diff
Sat, Dec 21, 1:12 PM
Unknown Object (File)
Sat, Dec 21, 7:42 AM
Unknown Object (File)
Sat, Dec 21, 3:33 AM
Subscribers
None

Details

Summary

Now that loading is async and can take a bit longer, it's good to have a loading indicator visible to the user.

Depends on D14142

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage