Page MenuHomePhabricator
Differential D13918

[lib] Reactions only bump thread timestamps when reacting to viewer
AcceptedPublic
Actions

Authored by ashoat on Nov 12 2024, 12:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 6:17 AM
Unknown Object (File)
Wed, Dec 18, 7:43 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
View All 58 Files
Subscribers
None

Details

Reviewers
tomek
Summary

This addresses ENG-9558 for reaction robotext messages. The implementation is broadly similar to D13828.

Depends on D13829

Test Plan

I logged in as two users on web, and with the second user, tested reacting to the first user's messages and other messages. Confirmed that the timestamp was bumped for the first user only when reacting to their messages. I also tested this with a sleep to confirm that the timestamps would only be bumped after the promise resolved

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fix
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Nov 12 2024, 12:46 PM
ashoat added a child revision: D13919: [lib] Don't bump thin thread timestamp for membership robotext.
ashoat edited the test plan for this revision. (Show Details)Nov 12 2024, 12:48 PM
ashoat mentioned this in D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
ashoat mentioned this in D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
ashoat updated this revision to Diff 45771.Nov 12 2024, 12:57 PM

Rebase

Harbormaster failed remote builds in B32629: Diff 45765!Nov 12 2024, 1:15 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 12 2024, 1:27 PM
Harbormaster failed remote builds in B32635: Diff 45771!
ashoat updated this revision to Diff 45778.Nov 12 2024, 1:58 PM

Rebase

Harbormaster completed remote builds in B32640: Diff 45778.Nov 12 2024, 3:24 PM
ashoat requested review of this revision.Nov 12 2024, 3:24 PM
tomek accepted this revision.Nov 13 2024, 4:53 AM
This revision is now accepted and ready to land.Nov 13 2024, 4:53 AM
ashoat mentioned this in rCOMMed9e9cf2c268: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.Nov 13 2024, 11:20 AM
ashoat mentioned this in rCOMM4d3afd3231b5: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
ashoat edited parent revisions, added: D13984: [lib] Fix incorrect timestamps for sidebars; removed: D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.Tue, Dec 10, 8:25 AM
ashoat edited the summary of this revision. (Show Details)
ashoat edited the summary of this revision. (Show Details)Wed, Dec 11, 3:54 PM
ashoat added a parent revision: D13829: [lib] Hide membership robotext from MessagePreview in thin threads.
ashoat removed a parent revision: D13984: [lib] Fix incorrect timestamps for sidebars.
ashoat updated this revision to Diff 46366.Wed, Dec 11, 4:46 PM

Rebase

ashoat updated this revision to Diff 46367.Wed, Dec 11, 4:48 PM

Rebase

Harbormaster completed remote builds in B33048: Diff 46366.Wed, Dec 11, 5:25 PM
Harbormaster completed remote builds in B33049: Diff 46367.Wed, Dec 11, 5:33 PM
Ashoat Tevosyan <ashoat@gmail.com> mentioned this in rCOMM85d0b02b1949: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.Fri, Dec 13, 6:13 AM
Ashoat Tevosyan <ashoat@gmail.com> mentioned this in rCOMM0943dead4c72: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.

Revision Contents
Changeset List

Diff 46366

View Options

lib/shared/messages/add-members-message-spec.js

Loading...
View Options

lib/shared/messages/join-thread-message-spec.js

Loading...
View Options

lib/shared/messages/leave-thread-message-spec.js

Loading...
View Options

lib/shared/messages/remove-members-message-spec.js

Loading...