Page MenuHomePhabricator
Differential D14335

[keyserver][lib] Split generateNotifUserInfoPromise into two
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 2:32 PM
Unknown Object (File)
Sat, Apr 19, 1:36 AM
Unknown Object (File)
Fri, Apr 18, 9:38 PM
Unknown Object (File)
Fri, Apr 18, 4:47 AM
Unknown Object (File)
Thu, Apr 17, 8:22 PM
Unknown Object (File)
Wed, Apr 9, 8:51 PM
Unknown Object (File)
Mon, Apr 7, 1:36 AM
Unknown Object (File)
Sun, Apr 6, 8:58 AM
View All 45 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMMbadaf89528b0: [keyserver][lib] Split generateNotifUserInfoPromise into two
Summary

This has two benefits:

  1. Avoids calling await getMessageNotifyType twice for every message.
  2. Exposes messageNotifyType to the callsite, which is necessary for a later diff.

Depends on D14334

Test Plan

Tested in combination with later diffs, to confirm that it's possible for some message types to not set a thread to unread

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
59 lines
lib/
push/
36 lines
143 lines

Diff 46983

View Options

keyserver/src/creators/message-creator.js

Show All 19 Linesexport type OLMOneTimeKeys = {
+curve25519: { +[string]: string }, +curve25519: { +[string]: string },
}; };
export type PickledOLMAccount = { export type PickledOLMAccount = {
+picklingKey: string, +picklingKey: string,
+pickledAccount: string, +pickledAccount: string,
}; };
export type CryptoStore = { export type CompleteCryptoStore = {
+primaryAccount: ?PickledOLMAccount, +primaryAccount: PickledOLMAccount,
+primaryIdentityKeys: ?OLMIdentityKeys, +primaryIdentityKeys: OLMIdentityKeys,
+notificationAccount: ?PickledOLMAccount, +notificationAccount: PickledOLMAccount,
+notificationIdentityKeys: ?OLMIdentityKeys, +notificationIdentityKeys: OLMIdentityKeys,
}; };
export type CryptoStore = $ObjMap<CompleteCryptoStore, <T>(T) => ?T>;
export type IdentityKeysBlob = { export type IdentityKeysBlob = {
+primaryIdentityPublicKeys: OLMIdentityKeys, +primaryIdentityPublicKeys: OLMIdentityKeys,
+notificationIdentityPublicKeys: OLMIdentityKeys, +notificationIdentityPublicKeys: OLMIdentityKeys,
}; };
export type SignedIdentityKeysBlob = { export type SignedIdentityKeysBlob = {
+payload: string, +payload: string,
+signature: string, +signature: string,
Show All 33 Lines
View Options

lib/push/send-utils.js

Show All 19 Linesexport type OLMOneTimeKeys = {
+curve25519: { +[string]: string }, +curve25519: { +[string]: string },
}; };
export type PickledOLMAccount = { export type PickledOLMAccount = {
+picklingKey: string, +picklingKey: string,
+pickledAccount: string, +pickledAccount: string,
}; };
export type CryptoStore = { export type CompleteCryptoStore = {
+primaryAccount: ?PickledOLMAccount, +primaryAccount: PickledOLMAccount,
+primaryIdentityKeys: ?OLMIdentityKeys, +primaryIdentityKeys: OLMIdentityKeys,
+notificationAccount: ?PickledOLMAccount, +notificationAccount: PickledOLMAccount,
+notificationIdentityKeys: ?OLMIdentityKeys, +notificationIdentityKeys: OLMIdentityKeys,
}; };
export type CryptoStore = $ObjMap<CompleteCryptoStore, <T>(T) => ?T>;
export type IdentityKeysBlob = { export type IdentityKeysBlob = {
+primaryIdentityPublicKeys: OLMIdentityKeys, +primaryIdentityPublicKeys: OLMIdentityKeys,
+notificationIdentityPublicKeys: OLMIdentityKeys, +notificationIdentityPublicKeys: OLMIdentityKeys,
}; };
export type SignedIdentityKeysBlob = { export type SignedIdentityKeysBlob = {
+payload: string, +payload: string,
+signature: string, +signature: string,
Show All 33 Lines
View Options

lib/push/utils.js

Show All 19 Linesexport type OLMOneTimeKeys = {
+curve25519: { +[string]: string }, +curve25519: { +[string]: string },
}; };
export type PickledOLMAccount = { export type PickledOLMAccount = {
+picklingKey: string, +picklingKey: string,
+pickledAccount: string, +pickledAccount: string,
}; };
export type CryptoStore = { export type CompleteCryptoStore = {
+primaryAccount: ?PickledOLMAccount, +primaryAccount: PickledOLMAccount,
+primaryIdentityKeys: ?OLMIdentityKeys, +primaryIdentityKeys: OLMIdentityKeys,
+notificationAccount: ?PickledOLMAccount, +notificationAccount: PickledOLMAccount,
+notificationIdentityKeys: ?OLMIdentityKeys, +notificationIdentityKeys: OLMIdentityKeys,
}; };
export type CryptoStore = $ObjMap<CompleteCryptoStore, <T>(T) => ?T>;
export type IdentityKeysBlob = { export type IdentityKeysBlob = {
+primaryIdentityPublicKeys: OLMIdentityKeys, +primaryIdentityPublicKeys: OLMIdentityKeys,
+notificationIdentityPublicKeys: OLMIdentityKeys, +notificationIdentityPublicKeys: OLMIdentityKeys,
}; };
export type SignedIdentityKeysBlob = { export type SignedIdentityKeysBlob = {
+payload: string, +payload: string,
+signature: string, +signature: string,
Show All 33 Lines