Paths

Table of Contentst

-
lib/
-
push/
2/4
utils.js
-
shared/messages/
-
messages/
2/4
create-sub-thread-message-spec.js
2/4
message-spec.js
2/4
reaction-message-spec.js

[lib] Don't pass MessageData to getMessageNotifyType
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:25 AM.

Details

Reviewers

tomek
angelika

Commits

rCOMM6616b63237f1: [lib] Don't pass MessageData to getMessageNotifyType

Summary

We want to do this because for DMs, we need to call this function on the recipient's side in order to determine whether to set a thread to unread. But the recipient does not have access to the MessageData.

Depends on D14340

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 11 2025, 12:25 AM

ashoat added a child revision: D14342: [lib] Add messagesNotifyTypes to ProcessDMOpsPayload.

Harbormaster completed remote builds in B33457: Diff 46989.Feb 11 2025, 1:59 AM

ashoat requested review of this revision.Feb 11 2025, 1:59 AM

tomek accepted this revision.Feb 12 2025, 3:48 AM

This revision is now accepted and ready to land.Feb 12 2025, 3:48 AM

Closed by commit rCOMM6616b63237f1: [lib] Don't pass MessageData to getMessageNotifyType (authored by ashoat). · Explain WhyFeb 12 2025, 5:59 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6616b63237f1: [lib] Don't pass MessageData to getMessageNotifyType.

Revision Contents
Changeset List

Path

Size

lib/

push/

utils.js

17 lines

shared/

messages/

create-sub-thread-message-spec.js

1 line

message-spec.js

1 line

reaction-message-spec.js

1 line

Diff 46989

View Options

lib/push/utils.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

View Options

lib/shared/messages/create-sub-thread-message-spec.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

View Options

lib/shared/messages/message-spec.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

View Options

lib/shared/messages/reaction-message-spec.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

[lib] Don't pass MessageData to getMessageNotifyTypeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46989

lib/push/utils.js

lib/shared/messages/create-sub-thread-message-spec.js

lib/shared/messages/message-spec.js

lib/shared/messages/reaction-message-spec.js

[lib] Don't pass MessageData to getMessageNotifyType
ClosedPublic
Actions

Revision Contents
Changeset List