Page MenuHomePhabricator
Differential D14344

[lib] Don't set thread to unread for reactions to other user's messages
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 1:40 PM
Unknown Object (File)
Sat, Apr 19, 11:02 AM
Unknown Object (File)
Fri, Apr 18, 9:06 PM
Unknown Object (File)
Fri, Apr 18, 1:34 PM
Unknown Object (File)
Sat, Apr 12, 7:05 PM
Unknown Object (File)
Thu, Apr 3, 2:44 PM
Unknown Object (File)
Tue, Apr 1, 1:36 AM
Unknown Object (File)
Sun, Mar 30, 12:47 PM
View All 54 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMMea97d13b0d77: [lib] Don't set thread to unread for reactions to other user's messages
Summary

This addresses part of the goal of ENG-9557.

Note that we'll have to continue setting the thread to unread for reactions to your own messages, as those generate a notif. More context here.

Depends on D14338

Test Plan

See test plans of D14337 (thin threads) and D14343 (thick threads)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
2 lines

Diff 46992

View Options

lib/shared/messages/reaction-message-spec.js

#import "CommMMKV.h" #import "CommMMKV.h"
#import "../../cpp/CommonCpp/CryptoTools/Tools.h" #import "../../cpp/CommonCpp/CryptoTools/Tools.h"
#import "CommSecureStore.h" #import "CommSecureStore.h"
#import "Logger.h" #import "Logger.h"
#import "Tools.h" #import "Tools.h"
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <MMKV.h> #import <MMKV.h>
#import <MMKVCore/MMKV.h>
// Core MMKV C++ implementation and Android wrapper have public `lock` and
// `unlock` methods while Obj-C wrapper doesn't. However Obj-C wrapper has
// private instance variable of type `mmkv::MMKV *`. Interface redeclaration
// below lets us access it. This pattern is hacky but it is well known in
// Obj-C and used in our codebase in CommSecureStore.
@interface MMKV () {
@public
mmkv::MMKV *m_mmkv;
}
@end
namespace comm { namespace comm {
const int mmkvEncryptionKeySize = 16; const int mmkvEncryptionKeySize = 16;
const int mmkvIDsize = 8; const int mmkvIDsize = 8;
const std::string secureStoreMMKVEncryptionKeyID = "comm.mmkvEncryptionKey"; const std::string secureStoreMMKVEncryptionKeyID = "comm.mmkvEncryptionKey";
const std::string secureStoreMMKVIdentifierKeyID = "comm.mmkvID"; const std::string secureStoreMMKVIdentifierKeyID = "comm.mmkvID";
static NSString *mmkvEncryptionKey; static NSString *mmkvEncryptionKey;
static NSString *mmkvIdentifier; static NSString *mmkvIdentifier;
MMKV *getMMKVInstance(NSString *mmkvID, NSString *encryptionKey) { MMKV *getMMKVInstance(NSString *mmkvID, NSString *encryptionKey) {
MMKV *mmkv = MMKV *mmkv =
[MMKV mmkvWithID:mmkvID [MMKV mmkvWithID:mmkvID
cryptKey:[encryptionKey dataUsingEncoding:NSUTF8StringEncoding] cryptKey:[encryptionKey dataUsingEncoding:NSUTF8StringEncoding]
mode:MMKVMultiProcess]; mode:MMKVMultiProcess];
if (!mmkv) { if (!mmkv) {
throw std::runtime_error("Failed to instantiate MMKV object."); throw std::runtime_error("Failed to instantiate MMKV object.");
} }
return mmkv; return mmkv;
} }
CommMMKV::ScopedCommMMKVLock::ScopedCommMMKVLock() {
CommMMKV::initialize();
MMKV *mmkv = getMMKVInstance(mmkvIdentifier, mmkvEncryptionKey);
mmkv->m_mmkv->lock();
}
CommMMKV::ScopedCommMMKVLock::~ScopedCommMMKVLock() {
MMKV *mmkv = getMMKVInstance(mmkvIdentifier, mmkvEncryptionKey);
mmkv->m_mmkv->unlock();
}
void assignInitializationData() { void assignInitializationData() {
std::string encryptionKey = std::string encryptionKey =
crypto::Tools::generateRandomString(mmkvEncryptionKeySize); crypto::Tools::generateRandomString(mmkvEncryptionKeySize);
std::string identifier = crypto::Tools::generateRandomString(mmkvIDsize); std::string identifier = crypto::Tools::generateRandomString(mmkvIDsize);
CommSecureStore::set(secureStoreMMKVEncryptionKeyID, encryptionKey); CommSecureStore::set(secureStoreMMKVEncryptionKeyID, encryptionKey);
CommSecureStore::set(secureStoreMMKVIdentifierKeyID, identifier); CommSecureStore::set(secureStoreMMKVIdentifierKeyID, identifier);
mmkvEncryptionKey = [NSString stringWithCString:encryptionKey.c_str() mmkvEncryptionKey = [NSString stringWithCString:encryptionKey.c_str()
encoding:NSUTF8StringEncoding]; encoding:NSUTF8StringEncoding];
▲ Show 20 Lines • Show All 153 Lines • Show Last 20 Lines