Differential D14475

[android] Implement generateThumbnail() function on Android
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:41 AM.

Tags

None

Referenced Files

	F5111663: D14475.diff
	Wed, Apr 2, 4:32 AM

	Unknown Object (File)
	Tue, Apr 1, 12:48 AM

	Unknown Object (File)
	Mon, Mar 31, 4:56 PM

	Unknown Object (File)
	Mon, Mar 31, 2:05 PM

	Unknown Object (File)
	Mon, Mar 31, 12:56 AM

	Unknown Object (File)
	Sun, Mar 30, 5:40 PM

	Unknown Object (File)
	Sun, Mar 30, 2:13 PM

	Unknown Object (File)
	Sun, Mar 30, 3:45 AM

View All 22 Files

Subscribers

Details

Reviewers

Commits

rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Copied and simplified from expo-module-thumbnails. I don't think it's worth to have a dependency for a few lines of code while we have already related code here. JPEG quality wasn't specified in the original implementation, but I had to put something so I've put 0.9.

Depends on D14474

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:41 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:42 AM

angelika added a child revision: D14476: [ios] Implement generateThumbnail() function on iOS.Thu, Mar 20, 4:42 AM

angelika edited the summary of this revision. (Show Details)Thu, Mar 20, 5:09 AM

Harbormaster completed remote builds in B33782: Diff 47486.Thu, Mar 20, 5:11 AM

angelika published this revision for review.Thu, Mar 20, 5:56 AM

bartek accepted this revision.Fri, Mar 21, 1:56 AM

This revision is now accepted and ready to land.Fri, Mar 21, 1:56 AM

Rebase & fix

Harbormaster completed remote builds in B33833: Diff 47551.Tue, Mar 25, 10:30 PM

Closed by commit rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

android/

src/

main/

java/

app/

comm/

android/

media/

36 lines

Diff 47486

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

Loading...