Differential D14475

[android] Implement generateThumbnail() function on Android
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:41 AM.

Details

Reviewers

bartek

Commits

rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android

Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Copied and simplified from expo-module-thumbnails. I don't think it's worth to have a dependency for a few lines of code while we have already related code here. JPEG quality wasn't specified in the original implementation, but I had to put something so I've put 0.9.

Depends on D14474

Test Plan

Send a video and verify thumbnail is generated

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:41 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:42 AM

angelika added a child revision: D14476: [ios] Implement generateThumbnail() function on iOS.Thu, Mar 20, 4:42 AM

angelika edited the summary of this revision. (Show Details)Thu, Mar 20, 5:09 AM

Harbormaster completed remote builds in B33782: Diff 47486.Thu, Mar 20, 5:11 AM

angelika published this revision for review.Thu, Mar 20, 5:56 AM

bartek accepted this revision.Fri, Mar 21, 1:56 AM

This revision is now accepted and ready to land.Fri, Mar 21, 1:56 AM

Rebase & fix

Harbormaster completed remote builds in B33833: Diff 47551.Tue, Mar 25, 10:30 PM

Closed by commit rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android.

Revision Contents
Changeset List

Path

Size

native/

expo-modules/

comm-expo-package/

android/

src/

main/

java/

app/

comm/

android/

media/

MediaModule.kt

36 lines

Diff 47551

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/media/MediaModule.kt

Show First 20 Lines • Show All 824 Lines • ▼ Show 20 Lines	blacklist: [
'lifecycleState',		'lifecycleState',
'dimensions',		'dimensions',
'draftStore',		'draftStore',
'connectivity',		'connectivity',
'deviceOrientation',		'deviceOrientation',
'frozen',		'frozen',
'threadStore',		'threadStore',
'storeLoaded',		'storeLoaded',
		'connection',
],		],
debug: __DEV__,		debug: __DEV__,
version: 49,		version: 49,
transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform],		transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),		migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number \| void),		timeout: ((__DEV__ ? 0 : undefined): number \| void),
};		};

Show All 15 Lines

[android] Implement generateThumbnail() function on AndroidClosedPublicActions