Page MenuHomePhabricator
Differential D14480

[native] Use transcodeVideo() from MediaModule instead of ffmpeg
ClosedPublic
Actions

Authored by angelika on Thu, Mar 20, 4:47 AM.
Tags
None
Referenced Files
F5086506: D14480.id47491.diff
Sat, Mar 29, 7:58 PM
F5084860: D14480.id47556.diff
Sat, Mar 29, 3:06 PM
Unknown Object (File)
Fri, Mar 28, 9:14 PM
Unknown Object (File)
Thu, Mar 27, 11:20 PM
Unknown Object (File)
Thu, Mar 27, 10:39 PM
Unknown Object (File)
Thu, Mar 27, 7:56 PM
Unknown Object (File)
Thu, Mar 27, 2:37 PM
Unknown Object (File)
Thu, Mar 27, 11:10 AM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg
Summary

https://linear.app/comm/issue/ENG-10314/migrate-comm-app-to-use-new-media-module

Depends on D14479

Test Plan

Send some videos on some devices and verify they're transcoded correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Thu, Mar 20, 4:47 AM
angelika held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:47 AM
angelika added a child revision: D14481: [native] Remove ffmpeg dependency.Thu, Mar 20, 4:48 AM
Harbormaster completed remote builds in B33787: Diff 47491.Thu, Mar 20, 5:24 AM
angelika added inline comments.Thu, Mar 20, 5:38 AM
lib/types/media-types.js
107 ↗(On Diff #47491)

I'm returning some basic stats (speed, size and duration) but some are missing compared to ffmpeg implementation because I don't see much sense in collecting them. However I can add them if necessary (should be easy on Android, more complicated on iOS)

118 ↗(On Diff #47491)

We don't have return code anymore but we throw exceptions

angelika updated this revision to Diff 47502.Thu, Mar 20, 5:52 AM

Fix

angelika published this revision for review.Thu, Mar 20, 5:57 AM
Harbormaster completed remote builds in B33798: Diff 47502.Thu, Mar 20, 6:11 AM
bartek accepted this revision.Sun, Mar 23, 11:44 PM

Looks much cleaner now

This revision is now accepted and ready to land.Sun, Mar 23, 11:44 PM
angelika updated this revision to Diff 47556.Tue, Mar 25, 10:06 PM

Rebase

Harbormaster completed remote builds in B33838: Diff 47556.Tue, Mar 25, 10:46 PM
angelika updated this revision to Diff 47592.Thu, Mar 27, 9:08 AM

Set bitrate to 4000 kb/s

Harbormaster failed remote builds in B33859: Diff 47592!Thu, Mar 27, 9:17 AM
Harbormaster completed remote builds in B33859: Diff 47592.Thu, Mar 27, 12:05 PM
Closed by commit rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg (authored by angelika). · Explain WhyThu, Mar 27, 12:21 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Revision Contents
Changeset List

PathSize
lib/
media/
65 lines
types/
5 lines
native/
media/
44 lines
32 lines
utils/
51 lines

Diff 47556

View Options

lib/media/video-utils.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;
View Options

lib/types/media-types.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;
View Options

native/media/ffmpeg.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;
View Options

native/media/video-utils.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;
View Options

native/utils/media-module.js

Loading...