Page MenuHomePhabricator
Differential D14510

[lib] Introduce delete message type
ClosedPublic
Actions

Authored by tomek on Fri, Mar 28, 4:10 AM.
Tags
None
Referenced Files
F6268855: D14510.id47782.diff
Fri, Apr 25, 11:46 AM
Unknown Object (File)
Thu, Apr 24, 1:15 PM
Unknown Object (File)
Thu, Apr 24, 5:58 AM
Unknown Object (File)
Mon, Apr 21, 12:03 PM
Unknown Object (File)
Sun, Apr 20, 5:22 PM
Unknown Object (File)
Sat, Apr 19, 9:06 PM
Unknown Object (File)
Wed, Apr 16, 2:55 AM
Unknown Object (File)
Thu, Apr 10, 4:58 AM
View All 41 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMMad5e8de95dd3: [lib] Introduce delete message type
Summary

Introduce a new message type for deleting a message

https://linear.app/comm/issue/ENG-10325/create-a-new-message-type

Depends on D14505

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Fri, Mar 28, 4:10 AM
Harbormaster completed remote builds in B33861: Diff 47608.Fri, Mar 28, 4:29 AM
tomek requested review of this revision.Fri, Mar 28, 4:29 AM
tomek updated this revision to Diff 47609.Fri, Mar 28, 4:44 AM

Modify some more types, test the validator

tomek added inline comments.Fri, Mar 28, 4:46 AM
lib/selectors/chat-selectors.js
461 ↗(On Diff #47609)

This is temporary just to make sure Flow doesn't complain. Implementing the proper solution is a part of the client side work.

lib/shared/messages/delete-message-spec.js
65 ↗(On Diff #47609)

We're introducing this whole spec just to have this line - to make sure the tests work. The functions that were introduced here are mandatory. More functions will be implemented later.

Harbormaster completed remote builds in B33862: Diff 47609.Fri, Mar 28, 5:03 AM
tomek added a child revision: D14511: [lib] Introduce delete message spec.Fri, Mar 28, 5:45 AM
ashoat accepted this revision.Fri, Mar 28, 6:42 AM

Can you retitle all of the diffs in this stack to explicitly reference message deletion? Just realized that they're just generically titled.

This revision is now accepted and ready to land.Fri, Mar 28, 6:42 AM
tomek updated this revision to Diff 47611.Fri, Mar 28, 6:46 AM

Expand MessageData

Harbormaster failed remote builds in B33864: Diff 47611!Fri, Mar 28, 6:55 AM
tomek retitled this revision from [lib] Introduce a new message type to [lib] Introduce delete message type.Thu, Apr 3, 8:16 AM
In D14510#402801, @ashoat wrote:

Can you retitle all of the diffs in this stack to explicitly reference message deletion? Just realized that they're just generically titled.

Sure!

Harbormaster completed remote builds in B33864: Diff 47611.Wed, Apr 9, 8:43 AM
Closed by commit rCOMMad5e8de95dd3: [lib] Introduce delete message type (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMad5e8de95dd3: [lib] Introduce delete message type.

Revision Contents
Changeset List

PathSize
lib/
selectors/
3 lines
shared/
10 lines
messages/
66 lines
2 lines
types/
4 lines
16 lines
messages/
39 lines
9 lines
8 lines

Diff 47611

View Options

lib/selectors/chat-selectors.js

Show All 40 Lines
export type TooltipPosition = $Values<typeof tooltipPositions>; export type TooltipPosition = $Values<typeof tooltipPositions>;
export type MessageTooltipAction = { export type MessageTooltipAction = {
+label: string, +label: string,
+onClick: (SyntheticEvent<HTMLDivElement>) => mixed, +onClick: (SyntheticEvent<HTMLDivElement>) => mixed,
+actionButtonContent: React.Node, +actionButtonContent: React.Node,
}; };
const font =
'14px "Inter", -apple-system, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", ' +
'"Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", ui-sans-serif';
type FindTooltipPositionArgs = { type FindTooltipPositionArgs = {
+sourcePositionInfo: PositionInfo, +sourcePositionInfo: PositionInfo,
+tooltipSize: TooltipSize, +tooltipSize: TooltipSize,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
+defaultPosition: TooltipPosition, +defaultPosition: TooltipPosition,
+preventDisplayingBelowSource?: boolean, +preventDisplayingBelowSource?: boolean,
}; };
▲ Show 20 Lines • Show All 269 Lines • ▼ Show 20 Lines
function calculateTooltipSize({ function calculateTooltipSize({
tooltipLabels, tooltipLabels,
timestamp, timestamp,
}: CalculateTooltipSizeArgs): { }: CalculateTooltipSizeArgs): {
+width: number, +width: number,
+height: number, +height: number,
} { } {
const textWidth = const textWidth =
calculateMaxTextWidth([...tooltipLabels, timestamp], font) + calculateMaxTextWidth([...tooltipLabels, timestamp], 14) +
2 * tooltipLabelStyle.padding; 2 * tooltipLabelStyle.padding;
const buttonsWidth = const buttonsWidth =
tooltipLabels.length * tooltipLabels.length *
(tooltipButtonStyle.width + (tooltipButtonStyle.width +
tooltipButtonStyle.paddingLeft + tooltipButtonStyle.paddingLeft +
tooltipButtonStyle.paddingRight); tooltipButtonStyle.paddingRight);
const width = const width =
Math.max(textWidth, buttonsWidth) + Math.max(textWidth, buttonsWidth) +
Show All 13 Lines
View Options

lib/shared/message-utils.js

Show All 40 Lines
export type TooltipPosition = $Values<typeof tooltipPositions>; export type TooltipPosition = $Values<typeof tooltipPositions>;
export type MessageTooltipAction = { export type MessageTooltipAction = {
+label: string, +label: string,
+onClick: (SyntheticEvent<HTMLDivElement>) => mixed, +onClick: (SyntheticEvent<HTMLDivElement>) => mixed,
+actionButtonContent: React.Node, +actionButtonContent: React.Node,
}; };
const font =
'14px "Inter", -apple-system, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", ' +
'"Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", ui-sans-serif';
type FindTooltipPositionArgs = { type FindTooltipPositionArgs = {
+sourcePositionInfo: PositionInfo, +sourcePositionInfo: PositionInfo,
+tooltipSize: TooltipSize, +tooltipSize: TooltipSize,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
+defaultPosition: TooltipPosition, +defaultPosition: TooltipPosition,
+preventDisplayingBelowSource?: boolean, +preventDisplayingBelowSource?: boolean,
}; };
▲ Show 20 Lines • Show All 269 Lines • ▼ Show 20 Lines
function calculateTooltipSize({ function calculateTooltipSize({
tooltipLabels, tooltipLabels,
timestamp, timestamp,
}: CalculateTooltipSizeArgs): { }: CalculateTooltipSizeArgs): {
+width: number, +width: number,
+height: number, +height: number,
} { } {
const textWidth = const textWidth =
calculateMaxTextWidth([...tooltipLabels, timestamp], font) + calculateMaxTextWidth([...tooltipLabels, timestamp], 14) +
2 * tooltipLabelStyle.padding; 2 * tooltipLabelStyle.padding;
const buttonsWidth = const buttonsWidth =
tooltipLabels.length * tooltipLabels.length *
(tooltipButtonStyle.width + (tooltipButtonStyle.width +
tooltipButtonStyle.paddingLeft + tooltipButtonStyle.paddingLeft +
tooltipButtonStyle.paddingRight); tooltipButtonStyle.paddingRight);
const width = const width =
Math.max(textWidth, buttonsWidth) + Math.max(textWidth, buttonsWidth) +
Show All 13 Lines
View Options

lib/shared/messages/delete-message-spec.js

Show All 40 Lines
export type TooltipPosition = $Values<typeof tooltipPositions>; export type TooltipPosition = $Values<typeof tooltipPositions>;
export type MessageTooltipAction = { export type MessageTooltipAction = {
+label: string, +label: string,
+onClick: (SyntheticEvent<HTMLDivElement>) => mixed, +onClick: (SyntheticEvent<HTMLDivElement>) => mixed,
+actionButtonContent: React.Node, +actionButtonContent: React.Node,
}; };
const font =
'14px "Inter", -apple-system, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", ' +
'"Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", ui-sans-serif';
type FindTooltipPositionArgs = { type FindTooltipPositionArgs = {
+sourcePositionInfo: PositionInfo, +sourcePositionInfo: PositionInfo,
+tooltipSize: TooltipSize, +tooltipSize: TooltipSize,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
+defaultPosition: TooltipPosition, +defaultPosition: TooltipPosition,
+preventDisplayingBelowSource?: boolean, +preventDisplayingBelowSource?: boolean,
}; };
▲ Show 20 Lines • Show All 269 Lines • ▼ Show 20 Lines
function calculateTooltipSize({ function calculateTooltipSize({
tooltipLabels, tooltipLabels,
timestamp, timestamp,
}: CalculateTooltipSizeArgs): { }: CalculateTooltipSizeArgs): {
+width: number, +width: number,
+height: number, +height: number,
} { } {
const textWidth = const textWidth =
calculateMaxTextWidth([...tooltipLabels, timestamp], font) + calculateMaxTextWidth([...tooltipLabels, timestamp], 14) +
2 * tooltipLabelStyle.padding; 2 * tooltipLabelStyle.padding;
const buttonsWidth = const buttonsWidth =
tooltipLabels.length * tooltipLabels.length *
(tooltipButtonStyle.width + (tooltipButtonStyle.width +
tooltipButtonStyle.paddingLeft + tooltipButtonStyle.paddingLeft +
tooltipButtonStyle.paddingRight); tooltipButtonStyle.paddingRight);
const width = const width =
Math.max(textWidth, buttonsWidth) + Math.max(textWidth, buttonsWidth) +
Show All 13 Lines
View Options

lib/shared/messages/message-specs.js

Show All 40 Lines
export type TooltipPosition = $Values<typeof tooltipPositions>; export type TooltipPosition = $Values<typeof tooltipPositions>;
export type MessageTooltipAction = { export type MessageTooltipAction = {
+label: string, +label: string,
+onClick: (SyntheticEvent<HTMLDivElement>) => mixed, +onClick: (SyntheticEvent<HTMLDivElement>) => mixed,
+actionButtonContent: React.Node, +actionButtonContent: React.Node,
}; };
const font =
'14px "Inter", -apple-system, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", ' +
'"Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", ui-sans-serif';
type FindTooltipPositionArgs = { type FindTooltipPositionArgs = {
+sourcePositionInfo: PositionInfo, +sourcePositionInfo: PositionInfo,
+tooltipSize: TooltipSize, +tooltipSize: TooltipSize,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
+defaultPosition: TooltipPosition, +defaultPosition: TooltipPosition,
+preventDisplayingBelowSource?: boolean, +preventDisplayingBelowSource?: boolean,
}; };
▲ Show 20 Lines • Show All 269 Lines • ▼ Show 20 Lines
function calculateTooltipSize({ function calculateTooltipSize({
tooltipLabels, tooltipLabels,
timestamp, timestamp,
}: CalculateTooltipSizeArgs): { }: CalculateTooltipSizeArgs): {
+width: number, +width: number,
+height: number, +height: number,
} { } {
const textWidth = const textWidth =
calculateMaxTextWidth([...tooltipLabels, timestamp], font) + calculateMaxTextWidth([...tooltipLabels, timestamp], 14) +
2 * tooltipLabelStyle.padding; 2 * tooltipLabelStyle.padding;
const buttonsWidth = const buttonsWidth =
tooltipLabels.length * tooltipLabels.length *
(tooltipButtonStyle.width + (tooltipButtonStyle.width +
tooltipButtonStyle.paddingLeft + tooltipButtonStyle.paddingLeft +
tooltipButtonStyle.paddingRight); tooltipButtonStyle.paddingRight);
const width = const width =
Math.max(textWidth, buttonsWidth) + Math.max(textWidth, buttonsWidth) +
Show All 13 Lines
View Options

lib/types/message-types-enum.js

Show All 40 Lines
export type TooltipPosition = $Values<typeof tooltipPositions>; export type TooltipPosition = $Values<typeof tooltipPositions>;
export type MessageTooltipAction = { export type MessageTooltipAction = {
+label: string, +label: string,
+onClick: (SyntheticEvent<HTMLDivElement>) => mixed, +onClick: (SyntheticEvent<HTMLDivElement>) => mixed,
+actionButtonContent: React.Node, +actionButtonContent: React.Node,
}; };
const font =
'14px "Inter", -apple-system, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", ' +
'"Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", ui-sans-serif';
type FindTooltipPositionArgs = { type FindTooltipPositionArgs = {
+sourcePositionInfo: PositionInfo, +sourcePositionInfo: PositionInfo,
+tooltipSize: TooltipSize, +tooltipSize: TooltipSize,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
+defaultPosition: TooltipPosition, +defaultPosition: TooltipPosition,
+preventDisplayingBelowSource?: boolean, +preventDisplayingBelowSource?: boolean,
}; };
▲ Show 20 Lines • Show All 269 Lines • ▼ Show 20 Lines
function calculateTooltipSize({ function calculateTooltipSize({
tooltipLabels, tooltipLabels,
timestamp, timestamp,
}: CalculateTooltipSizeArgs): { }: CalculateTooltipSizeArgs): {
+width: number, +width: number,
+height: number, +height: number,
} { } {
const textWidth = const textWidth =
calculateMaxTextWidth([...tooltipLabels, timestamp], font) + calculateMaxTextWidth([...tooltipLabels, timestamp], 14) +
2 * tooltipLabelStyle.padding; 2 * tooltipLabelStyle.padding;
const buttonsWidth = const buttonsWidth =
tooltipLabels.length * tooltipLabels.length *
(tooltipButtonStyle.width + (tooltipButtonStyle.width +
tooltipButtonStyle.paddingLeft + tooltipButtonStyle.paddingLeft +
tooltipButtonStyle.paddingRight); tooltipButtonStyle.paddingRight);
const width = const width =
Math.max(textWidth, buttonsWidth) + Math.max(textWidth, buttonsWidth) +
Show All 13 Lines
View Options

lib/types/message-types.js

Show All 40 Lines
export type TooltipPosition = $Values<typeof tooltipPositions>; export type TooltipPosition = $Values<typeof tooltipPositions>;
export type MessageTooltipAction = { export type MessageTooltipAction = {
+label: string, +label: string,
+onClick: (SyntheticEvent<HTMLDivElement>) => mixed, +onClick: (SyntheticEvent<HTMLDivElement>) => mixed,
+actionButtonContent: React.Node, +actionButtonContent: React.Node,
}; };
const font =
'14px "Inter", -apple-system, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", ' +
'"Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", ui-sans-serif';
type FindTooltipPositionArgs = { type FindTooltipPositionArgs = {
+sourcePositionInfo: PositionInfo, +sourcePositionInfo: PositionInfo,
+tooltipSize: TooltipSize, +tooltipSize: TooltipSize,
+availablePositions: $ReadOnlyArray<TooltipPosition>, +availablePositions: $ReadOnlyArray<TooltipPosition>,
+defaultPosition: TooltipPosition, +defaultPosition: TooltipPosition,
+preventDisplayingBelowSource?: boolean, +preventDisplayingBelowSource?: boolean,
}; };
▲ Show 20 Lines • Show All 269 Lines • ▼ Show 20 Lines
function calculateTooltipSize({ function calculateTooltipSize({
tooltipLabels, tooltipLabels,
timestamp, timestamp,
}: CalculateTooltipSizeArgs): { }: CalculateTooltipSizeArgs): {
+width: number, +width: number,
+height: number, +height: number,
} { } {
const textWidth = const textWidth =
calculateMaxTextWidth([...tooltipLabels, timestamp], font) + calculateMaxTextWidth([...tooltipLabels, timestamp], 14) +
2 * tooltipLabelStyle.padding; 2 * tooltipLabelStyle.padding;
const buttonsWidth = const buttonsWidth =
tooltipLabels.length * tooltipLabels.length *
(tooltipButtonStyle.width + (tooltipButtonStyle.width +
tooltipButtonStyle.paddingLeft + tooltipButtonStyle.paddingLeft +
tooltipButtonStyle.paddingRight); tooltipButtonStyle.paddingRight);
const width = const width =
Math.max(textWidth, buttonsWidth) + Math.max(textWidth, buttonsWidth) +
Show All 13 Lines
View Options

lib/types/messages/delete.js

Loading...
View Options

lib/types/messages/unsupported.js

Loading...
View Options

lib/types/validation.test.js

Loading...