Make sure the deleted message height is computed correctly.
https://linear.app/comm/issue/ENG-10347/make-sure-height-calculation-is-correct
Depends on D14545
Details
Details
Checked if there are no warnings in the console about an invalid height.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/chat/chat-item-height-measurer.react.js | ||
|---|---|---|
| 47–51 ↗ | (On Diff #47658) | This is probably wrong because a deleted message can be a sidebar source |
| native/chat/chat-item-height-measurer.react.js | ||
|---|---|---|
| 95–100 ↗ | (On Diff #47661) | Is it difficult to do this without rendering <Markdown>? I can see the argument for it if so, but would be helpful to explain |
Comment Actions
Don't use markdown when measuring deleted messages
| native/chat/chat-item-height-measurer.react.js | ||
|---|---|---|
| 95–100 ↗ | (On Diff #47661) | It isn't that difficult, and after the recent changes from the parent diffs it is more correct. |