In D3895#108996, @ashoat wrote:In a later diff it would probably be good to rename InlineSidebar to InlineFeedback, InlineReactions, InlineResponses, or InlineEngagement or something
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 4 2022
May 4 2022
rename cls
re add bold styling to inline sidebar
• benschac committed rCOMM3263b7e9a3f0: [web] [feat] [ENG-991] add modal prompt (authored by • benschac).
[web] [feat] [ENG-991] add modal prompt
• benschac committed rCOMM0d0f869b628a: [web] [feat] [ENG-991] add show promote thread logic to web (authored by • benschac).
[web] [feat] [ENG-991] add show promote thread logic to web
• benschac committed rCOMMab089253eac4: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook (authored by • benschac).
[lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook
• benschac added a comment to D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
We talked IRL yesterday.
May 3 2022
May 3 2022
• benschac committed rCOMM67e4e8655154: [native] [fix] [ENG-1078] fix hot reload loosing state (authored by • benschac).
[native] [fix] [ENG-1078] fix hot reload loosing state
• benschac committed rCOMM0637428a5235: [native] [fix] [ENG-1077] fix reloading bug in tab navigation (authored by • benschac).
[native] [fix] [ENG-1077] fix reloading bug in tab navigation
• benschac requested review of D3900: [native] [fix] [ENG-1077] fix reloading bug in tab navigation.
• benschac added a comment to D3896: [refactor] [web] [ENG-530] rename prop from positioning to position.
In D3896#108991, @ashoat wrote:Do you think there's a risk of confusion with CSS position?
In D3895#108996, @ashoat wrote:In a later diff it would probably be good to rename InlineSidebar to InlineFeedback, InlineReactions, InlineResponses, or InlineEngagement or something
I removed the bolding functionality and I didn't re-add it yet. Going to put this back as plan changes for now.
add more styles
• benschac requested review of D3896: [refactor] [web] [ENG-530] rename prop from positioning to position.
• benschac requested review of D3894: [lib] [refactor] [ENG-530] remove list of users string in reply.
May 2 2022
May 2 2022
• benschac requested review of D3893: [web] [chore] [ENG-530] remove old styles from inline sidebar component.
Going to close this diff in favor of: D3839
• benschac committed rCOMM80abee4eb84a: [lib] [refactor] [ENG-530] add memo in inline sidebar hook (authored by • benschac).
[lib] [refactor] [ENG-530] add memo in inline sidebar hook
• benschac committed rCOMMfd5c857f78dc: [lib,native,web] move inline sidebar text to shared hook in lib (authored by • benschac).
[lib,native,web] move inline sidebar text to shared hook in lib
• benschac added a comment to D3879: [lib,native,web] move inline sidebar text to shared hook in lib.
In D3879#108720, @ashoat wrote:Thanks for factoring this out! I didn't look too closely at the red/green... assuming that this is just a simple move
I tried it.
• benschac updated the summary of D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
• benschac updated the summary of D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
• benschac updated the diff for D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
fixup arrows
• benschac planned changes to D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
this needs a little more work.
• benschac retitled D3841: [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec [squashed diff into another stack] from [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec to [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec [squashed diff into another stack].
• benschac updated the summary of D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
• benschac updated the diff for D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
update svg
• benschac added a reviewer for D3879: [lib,native,web] move inline sidebar text to shared hook in lib: ashoat.
• benschac added a comment to D3879: [lib,native,web] move inline sidebar text to shared hook in lib.
Adding @ashoat because @palys-swm is on vacation.
• benschac retitled D3887: [lib] [refactor] [ENG-530] add memo in inline sidebar hook from [lib] [refactor] [ENG-530] add memo and nullish check in hook to [lib] [refactor] [ENG-530] add memo in inline sidebar hook .
remove nullish check and optional flag
• benschac added inline comments to D3887: [lib] [refactor] [ENG-530] add memo in inline sidebar hook .
• benschac retitled D3887: [lib] [refactor] [ENG-530] add memo in inline sidebar hook from [lib] [refactor] [ENG-530] add memo and nullish check in hook inline sidebar hook to [lib] [refactor] [ENG-530] add memo and nullish check in hook.
• benschac planned changes to D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
I got a 2px shorter arrow from @atul. I need to update the img in the keyserver directory.
• benschac retitled D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar from [web] [remove] [ENG-1022] remove arrow and extender from sidebar to [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
• benschac added inline comments to D3879: [lib,native,web] move inline sidebar text to shared hook in lib.
Apr 29 2022
Apr 29 2022
• benschac requested review of D3879: [lib,native,web] move inline sidebar text to shared hook in lib.
Fix formatting of content, remove unneeded quotes
• benschac updated the diff for D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
parentThreadID
• benschac updated the diff for D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
remove line
• benschac added inline comments to D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
• benschac added inline comments to D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
• benschac updated the diff for D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
diff review
Apr 28 2022
Apr 28 2022
• benschac updated the test plan for D3537: [web] [fix] ENG-761 add padding between timestamp and message.
change copy
remove file
revert
remove file
fix modal
• benschac updated the diff for D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
remove xml tag
• benschac added inline comments to D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
• benschac requested review of D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
Tested promote thread functionality on both iOS and web and it's working as expected.
• benschac planned changes to D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
I need to test the functionality a bit before passing this over for review.
• benschac updated the diff for D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
remove route / parent thread param
Apr 27 2022
Apr 27 2022
rebase fix
• benschac added a comment to D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
Last question from the D3841
In D3841#107354, @palys-swm wrote:
I need to adjust the size of the chat thread item in another diff.
Are you sure we should do that?
• benschac added a comment to D3841: [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec [squashed diff into another stack].
In D3841#107354, @palys-swm wrote:I need to adjust the size of the chat thread item in another diff.
Are you sure we should do that?
• benschac planned changes to D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
• benschac added a comment to D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
• benschac updated the diff for D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.
squash commit
• benschac requested review of D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
Putting this back as needs review to get it back into @ashoat's queue to make sure he'll see my comment.
Apr 26 2022
Apr 26 2022
• benschac retitled D3841: [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec [squashed diff into another stack] from [web, keyserver] [fix] [ENG-1022] add svg images to sidebar to try and fix arrow issue to [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec.
• benschac updated the diff for D3841: [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec [squashed diff into another stack].
fixup arrows design
• benschac added a comment to D3807: [lib, native] [move] [ENG-991] replace canPromote thread logic to lib hook.
I looked at this again, maybe for a bit too long and I'm having trouble figuring out exactly what you mean by @ashoat:
• benschac added inline comments to D3837: [web] Push "Delete thread" functionality down to `ThreadSettingsDeleteTab`.
diff review fixes.
In D3809#106845, @def-au1t wrote:I'm wondering if, instead of creating separate SidebarPromoteModal component, shouldn't we use existing logic already implemented in ConfirmLeaveThreadModal and create universal ConfirmModal component, that can receive e.g. title, message (content), and confirm action name? I think, there are quite many places, where something like this could be used in web app. What do you think?
• benschac committed rCOMM1f0272f1e14f: [web] [fix] [ENG-1033] change modal x default to show on default (authored by • benschac).
[web] [fix] [ENG-1033] change modal x default to show on default
• benschac requested review of D3820: [web] [fix] [ENG-1033] change modal x default to show on default.
@atul -- can you take another look?
• benschac added a comment to D3820: [web] [fix] [ENG-1033] change modal x default to show on default.
In D3820#106142, @atul wrote:Should you also go back and explicitly set withCloseButton to false for the modals you decided didn't need a close button?