Page MenuHomePhabricator
Feed Advanced Search

Mar 29 2023

kuba added a comment to D7066: [native] Displaying 'Edit' labels next to edited messages.
In D7066#214942, @inka wrote:

Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?

Mar 29 2023, 3:19 AM
kuba added a comment to D7128: [lib][keyserver] Added new edit_message endpoint.
In D7128#214943, @inka wrote:

What about the test plan?

Mar 29 2023, 2:11 AM
kuba updated the test plan for D7128: [lib][keyserver] Added new edit_message endpoint.
Mar 29 2023, 2:10 AM

Mar 28 2023

kuba updated the diff for D7017: [web] Added displaying 'Labels' to InlineEngagment.

Removed logic from JSX

Mar 28 2023, 12:28 PM
kuba planned changes to D7017: [web] Added displaying 'Labels' to InlineEngagment.
Mar 28 2023, 9:22 AM
kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Responded to review

Mar 28 2023, 9:20 AM
kuba added inline comments to D7063: [native] Move 'InlineEngagement' styling from 'ComposedMessage' to component.
Mar 28 2023, 8:56 AM
kuba added a comment to D7066: [native] Displaying 'Edit' labels next to edited messages.
In D7066#214557, @inka wrote:

What designs are you using? The designs I found (here) show the label next to the message.
I also see no comments regarding this, in what I guess is the task this diff is addressing (here)

Mar 28 2023, 8:52 AM
kuba added inline comments to D7128: [lib][keyserver] Added new edit_message endpoint.
Mar 28 2023, 8:49 AM
kuba updated the diff for D7143: [lib] Function to dispatch edit message action.

Added invariant & removed redundant error catching.

Mar 28 2023, 4:39 AM
kuba updated the diff for D7129: [lib] Added new 'sendEditMessage' action.

Removed redundant error payload & moved redux types to the end of the file

Mar 28 2023, 4:37 AM
kuba updated the diff for D7017: [web] Added displaying 'Labels' to InlineEngagment.

Added keys to the components list to prevent key error

Mar 28 2023, 4:23 AM
kuba added inline comments to D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
Mar 28 2023, 3:04 AM
kuba retitled D7141: [keyserver] Display edited message in the sidebar if the source message is edited from [keyserver] Display edited message in the sidebar if the source message is edited … to [keyserver] Display edited message in the sidebar if the source message is edited.
Mar 28 2023, 2:58 AM
kuba retitled D7141: [keyserver] Display edited message in the sidebar if the source message is edited from [keyserver] Add the latest edit message to the new sidebar if the source message is edited to [keyserver] Display edited message in the sidebar if the source message is edited ….
Mar 28 2023, 2:58 AM
kuba updated the diff for D7141: [keyserver] Display edited message in the sidebar if the source message is edited.

Changed the way of displaying new content of edited message in the sidebar

Mar 28 2023, 2:56 AM
kuba updated the diff for D7140: [lib] Displaying edited content in a pending thread.

Removed accidentally added empty line

Mar 28 2023, 2:45 AM
kuba updated the diff for D7140: [lib] Displaying edited content in a pending thread.

Removed 'Edited' label from the pending thread to match D7141 changes

Mar 28 2023, 2:42 AM
kuba requested review of D7065: [native] Added displaying labels to InlineEngagement.
Mar 28 2023, 1:05 AM
kuba updated the diff for D7139: [lib] Added method to call edit_message endpoint.

Removed redundant code

Mar 28 2023, 12:58 AM
kuba added inline comments to D7066: [native] Displaying 'Edit' labels next to edited messages.
Mar 28 2023, 12:49 AM
kuba added a comment to D7065: [native] Added displaying labels to InlineEngagement.

Will this affect the height of the item? Have you made the necessary changes to the height determination code (textMessageItemHeight)?

Requesting changes for my question above

Mar 28 2023, 12:48 AM
kuba updated the diff for D7066: [native] Displaying 'Edit' labels next to edited messages.

Added messageHeight of edited messages

Mar 28 2023, 12:47 AM

Mar 27 2023

kuba added inline comments to D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
Mar 27 2023, 9:01 AM
kuba added inline comments to D6962: [lib][keyserver] Add editing message type to messageTypes.
Mar 27 2023, 8:32 AM
kuba updated the diff for D6962: [lib][keyserver] Add editing message type to messageTypes.

Rebase to master

Mar 27 2023, 8:32 AM
kuba updated the diff for D6961: [lib] Create types for message editing.

Set id to readonly

Mar 27 2023, 8:28 AM
kuba updated the diff for D6961: [lib] Create types for message editing.

Rebase

Mar 27 2023, 8:12 AM
kuba updated the diff for D7127: [lib][keyserver] Introduce new threadPermissions types for editing messages.

Rebase

Mar 27 2023, 8:07 AM

Mar 24 2023

kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Rebase

Mar 24 2023, 5:35 AM
kuba updated the diff for D7063: [native] Move 'InlineEngagement' styling from 'ComposedMessage' to component.

Rebase

Mar 24 2023, 5:32 AM
kuba updated the diff for D7145: [keyserver] Adding edit_message to the sidebar thread.

Address comments

Mar 24 2023, 3:56 AM
kuba added inline comments to D7129: [lib] Added new 'sendEditMessage' action.
Mar 24 2023, 3:54 AM
kuba updated the diff for D7129: [lib] Added new 'sendEditMessage' action.

Change type to inexact

Mar 24 2023, 3:54 AM
kuba added inline comments to D7143: [lib] Function to dispatch edit message action.
Mar 24 2023, 3:39 AM
kuba updated the diff for D7143: [lib] Function to dispatch edit message action.

Address review comments

Mar 24 2023, 3:38 AM
kuba updated the diff for D7140: [lib] Displaying edited content in a pending thread.

Address comments

Mar 24 2023, 3:09 AM
kuba added a comment to D6965: [lib][native] Displaying edited messages from database.

We can consider preventing users from sending empty edit messages.

We should do this. We don't allow empty messages for messageTypes.TEXT. Can you create a follow-up Linear task for this before landing?

Mar 24 2023, 2:57 AM

Mar 23 2023

kuba added inline comments to D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
Mar 23 2023, 8:43 AM
kuba updated the diff for D7141: [keyserver] Display edited message in the sidebar if the source message is edited.

Addressed some of the comments

Mar 23 2023, 8:43 AM

Mar 22 2023

kuba updated the test plan for D7066: [native] Displaying 'Edit' labels next to edited messages.
Mar 22 2023, 1:09 PM
kuba requested review of D7145: [keyserver] Adding edit_message to the sidebar thread.
Mar 22 2023, 6:39 AM
kuba requested review of D7144: [lib] Added edit message action reducer.
Mar 22 2023, 6:37 AM
kuba requested review of D7143: [lib] Function to dispatch edit message action.
Mar 22 2023, 6:19 AM
kuba requested review of D7142: [lib] Checking if the user can edit the message.
Mar 22 2023, 6:16 AM
kuba requested review of D7140: [lib] Displaying edited content in a pending thread.
Mar 22 2023, 6:12 AM
kuba requested review of D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
Mar 22 2023, 6:11 AM
kuba requested review of D7139: [lib] Added method to call edit_message endpoint.
Mar 22 2023, 5:58 AM
kuba added inline comments to D6965: [lib][native] Displaying edited messages from database.
Mar 22 2023, 5:23 AM
kuba updated the diff for D6965: [lib][native] Displaying edited messages from database.

Revert the changes

Mar 22 2023, 5:23 AM
kuba retitled D6965: [lib][native] Displaying edited messages from database from [lib][native] Displaying edited messages from database to [lib] Displaying edited messages from database.
Mar 22 2023, 5:23 AM
kuba updated the diff for D6965: [lib][native] Displaying edited messages from database.

Simplified condition

Mar 22 2023, 5:14 AM
kuba added inline comments to D6963: [lib] Added new MessageSpec for editing messages.
Mar 22 2023, 5:09 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Added message type for error message

Mar 22 2023, 5:06 AM
kuba updated the diff for D6961: [lib] Create types for message editing.

id is no longer nullable

Mar 22 2023, 5:01 AM
kuba added a comment to D6961: [lib] Create types for message editing.

Can you clarify in what scenarios the id can be null? Usually we only see that for types that also have localID

Mar 22 2023, 4:59 AM
kuba updated the diff for D7128: [lib][keyserver] Added new edit_message endpoint.

Simplified text variable

Mar 22 2023, 4:51 AM
kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Added unique keys to the rendered components

Mar 22 2023, 4:40 AM

Mar 21 2023

kuba requested review of D7129: [lib] Added new 'sendEditMessage' action.
Mar 21 2023, 11:52 AM
kuba requested review of D7128: [lib][keyserver] Added new edit_message endpoint.
Mar 21 2023, 11:45 AM
kuba requested review of D7127: [lib][keyserver] Introduce new threadPermissions types for editing messages.
Mar 21 2023, 11:37 AM
kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Addressed @ginsu feedback from the web version of diff

Mar 21 2023, 11:16 AM
kuba planned changes to D7065: [native] Added displaying labels to InlineEngagement.

The same comments as in: https://phab.comm.dev/D7017?id=23714#inline-46406

Mar 21 2023, 10:42 AM
kuba added inline comments to D7017: [web] Added displaying 'Labels' to InlineEngagment.
Mar 21 2023, 10:41 AM
kuba updated the diff for D7017: [web] Added displaying 'Labels' to InlineEngagment.

Addressed @ginsu comments

Mar 21 2023, 10:40 AM
kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.
In D7017#210367, @ginsu wrote:

Also, I personally feel like the label for edited messages should be below the reactions/threads and not to the left/right of it. Could you link or send a screenshot of what the figma has?

Mar 21 2023, 10:15 AM
kuba updated the diff for D6961: [lib] Create types for message editing.

Removed localID from the type

Mar 21 2023, 1:49 AM
kuba abandoned D6393: Fixed incorret display for long thread names on web..

@inka fixed this in another diff.

Mar 21 2023, 12:33 AM

Mar 15 2023

kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Can you share an updated screenshot?

Mar 15 2023, 12:16 PM

Mar 14 2023

kuba updated the diff for D7017: [web] Added displaying 'Labels' to InlineEngagment.

Aligned 'Delivery failed' notice to the message label. Only for the right side, because we can't get delivery failed on the left side.

Mar 14 2023, 7:37 AM
kuba added a comment to D6963: [lib] Added new MessageSpec for editing messages.
In D6963#209536, @tomek wrote:

The proper way of testing older clients involves running an older client in prod mode (so that it won't get hot reloaded when we update the code version), then checking out the newest code, and running the server with this code. In this case we can consider a simplified approach: the thing which interests us the most is if the server sends an original message or the shimmed version. To test that we can run a client and set code version in the condition on the keyserver. If the client's version is higher than server's, we should receive an original message. Otherwise, it should be the shimmed one.

Mar 14 2023, 3:06 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Changed minCodeVersion for messageShimming

Mar 14 2023, 2:51 AM
kuba requested review of D7066: [native] Displaying 'Edit' labels next to edited messages.
Mar 14 2023, 2:10 AM
kuba requested review of D7065: [native] Added displaying labels to InlineEngagement.
Mar 14 2023, 2:07 AM
kuba requested review of D7063: [native] Move 'InlineEngagement' styling from 'ComposedMessage' to component.
Mar 14 2023, 1:53 AM
kuba added a comment to D6963: [lib] Added new MessageSpec for editing messages.

I don't know how to test message shimming yet, so for now it isn't tested.

Mar 14 2023, 1:10 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Added shimming message info, changed content to JSON format.

Mar 14 2023, 1:09 AM

Mar 13 2023

kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Can you check what it looks like with the "Delivery failed. RETRY?" text which appears when sending a message, and attach a screenshot? Not sure if this case was considered in the designs.

Mar 13 2023, 10:14 AM
kuba attached a referenced file: F425177: Screenshot 2023-03-13 at 11.24.47.png.
Mar 13 2023, 3:34 AM
kuba added a comment to D6963: [lib] Added new MessageSpec for editing messages.
In D6963#208218, @ginsu wrote:

I think we should consider if we also need shimUnsupportedMessageInfo and unshimMessageInfo. These functions will help us support older native clients that haven't been updated yet.

Mar 13 2023, 3:32 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Responded to comments

Mar 13 2023, 3:32 AM

Mar 9 2023

kuba requested review of D7018: [web] Displaying 'Edit' label next to edited messages.
Mar 9 2023, 3:57 AM
kuba requested review of D7017: [web] Added displaying 'Labels' to InlineEngagment.
Mar 9 2023, 3:50 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Removed 'hasBeenEdited' variable from 'RobotextChatMessageInfoItem'

Mar 9 2023, 1:50 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Add 'hasBeenEdited' to code for native to be able to access the variable

Mar 9 2023, 1:30 AM

Mar 8 2023

kuba added a comment to D6966: [lib] Add 'hasBeenEdited' status to messages.

Can we avoid putting this in TextMessageInfo? I don't think it belongs there... and you're doing something pretty inconsistent with how we approached reactions.

Why didn't you put this in ChatMessageInfoItem? (In the future, when you are doing something different like this, please expect that your reviewers will call you out on it, and explain it ahead of time.)

Mar 8 2023, 10:00 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Moved 'hasBeenEdited' property to 'ChatMessageInfoItem' type

Mar 8 2023, 10:00 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Responded to comments, made hasBeenEdited property read-only

Mar 8 2023, 3:08 AM
kuba updated the diff for D6965: [lib][native] Displaying edited messages from database.

Responded to comments, made read-only 'text' property

Mar 8 2023, 2:59 AM

Mar 7 2023

kuba added a reviewer for D6965: [lib][native] Displaying edited messages from database: ginsu.
Mar 7 2023, 8:11 AM
kuba added a reviewer for D6964: [native] Added new editing messages type to MessageSpecs in C++: ginsu.
Mar 7 2023, 8:11 AM
kuba added a reviewer for D6963: [lib] Added new MessageSpec for editing messages: ginsu.
Mar 7 2023, 8:11 AM
kuba added a reviewer for D6962: [lib][keyserver] Add editing message type to messageTypes: ginsu.
Mar 7 2023, 8:11 AM
kuba added a reviewer for D6961: [lib] Create types for message editing: ginsu.
Mar 7 2023, 8:10 AM
kuba added a comment to D6961: [lib] Create types for message editing.

Can you also updates lib/types/messages.js? EDIT ah I see these are in the next diff

In general I personally find it better to introduce types along with code that actually uses them, but many people on the team do what you did here and introduce them in a separate diff. It just makes it much harder to test... eg. your Test Plan doesn't actually test any of the types at all, which means it's quite a poor test plan.

Mar 7 2023, 8:10 AM
kuba updated the test plan for D6965: [lib][native] Displaying edited messages from database.
Mar 7 2023, 2:01 AM
kuba requested review of D6966: [lib] Add 'hasBeenEdited' status to messages.
Mar 7 2023, 2:00 AM
kuba requested review of D6965: [lib][native] Displaying edited messages from database.
Mar 7 2023, 1:59 AM
kuba requested review of D6964: [native] Added new editing messages type to MessageSpecs in C++.
Mar 7 2023, 1:56 AM
kuba requested review of D6963: [lib] Added new MessageSpec for editing messages.
Mar 7 2023, 1:54 AM