Page MenuHomePhabricator
Feed Advanced Search

Nov 27 2023

michal updated the diff for D9500: [keyserver] Remove cookieSources.

Update for flow 202

Nov 27 2023, 6:55 AM
michal requested review of D10054: [native] Implement native backup.
Nov 27 2023, 6:53 AM
michal updated the diff for D9500: [keyserver] Remove cookieSources.

Rebase

Nov 27 2023, 5:57 AM
michal updated the diff for D9291: [keyserver] Stop accepting http cookies.

Rebase

Nov 27 2023, 5:56 AM
michal updated the diff for D9452: [keyserver] Separate webapp and keyserver endpoints.

Rebase

Nov 27 2023, 5:53 AM
michal accepted D10047: Use olm WASM with content hash on web in production.
Nov 27 2023, 2:55 AM
michal updated the diff for D9967: [desktop] Unregister did-fail-load event after startup.

Fix position of the variable, it was a mistake - I extracted the handler function but didn't move the variable declaration with it.

Nov 27 2023, 1:06 AM
michal requested review of D9969: [native] Compute backup key for u8 slice.
Nov 27 2023, 12:39 AM
michal accepted D9985: [Flow202][native][skip-ci] [1/x] Ignore electron-update-server in native.
Nov 27 2023, 12:28 AM

Nov 24 2023

michal requested review of D9971: [native] Add native backup functions.
Nov 24 2023, 9:15 AM
michal requested review of D9967: [desktop] Unregister did-fail-load event after startup.
Nov 24 2023, 7:58 AM
michal added inline comments to D9939: [native] Implement Android encryption for Rust.
Nov 24 2023, 7:47 AM
michal updated the diff for D9939: [native] Implement Android encryption for Rust.

An issue with with non-static methods calling the static methods is that the ByteBuffer -> SecretKeySpec conversion must go through ByteArray (with a copy). So that means that we would have ByteArray -no-copy-> ByteBuffer -with-copy-> ByteArray -> SecretKeySpec. As the static methods are very minimal and most of the code is in encryptAES/ decryptAES functions I don't it's worth it.

Nov 24 2023, 7:47 AM
michal updated the diff for D9938: [native] Refactor Android AESCryptoModule to use ByteBuffers.

Fix naming

Nov 24 2023, 7:42 AM
michal updated the diff for D9933: [native] Implement iOS encryption for Rust.

Rebase after a new approach to error handling

Nov 24 2023, 7:41 AM
michal added inline comments to D9932: [native] Introduce Rust encryption functions.
Nov 24 2023, 7:41 AM
michal updated the diff for D9932: [native] Introduce Rust encryption functions.

Improve error handling

Nov 24 2023, 7:41 AM
michal accepted D9962: Implement method to decrypt desktop notification.
Nov 24 2023, 6:15 AM
michal accepted D9964: Implement main <-> renderer IPC and use it to decrypt notifications.

Accepting, but please fix the issues in inline comments.

Nov 24 2023, 6:13 AM
michal added inline comments to D9962: Implement method to decrypt desktop notification.
Nov 24 2023, 6:03 AM
michal accepted D9963: Extend showNotification method to cover the case of decryption error notitication.
Nov 24 2023, 6:03 AM

Nov 22 2023

michal accepted D9661: Decrypt encrypted web notifications in service worker.
Nov 22 2023, 6:25 AM
michal updated the diff for D9950: [desktop] Add additional logging.

Fix line lengths

Nov 22 2023, 6:17 AM
michal requested review of D9950: [desktop] Add additional logging.
Nov 22 2023, 6:14 AM
michal accepted D9535: Initialize olm sessions for notifications on web and keyserver via socket requests.
Nov 22 2023, 6:05 AM

Nov 21 2023

michal requested review of D9939: [native] Implement Android encryption for Rust.
Nov 21 2023, 5:54 AM
michal requested review of D9938: [native] Refactor Android AESCryptoModule to use ByteBuffers.
Nov 21 2023, 5:49 AM

Nov 20 2023

michal requested review of D9933: [native] Implement iOS encryption for Rust.
Nov 20 2023, 9:58 AM
michal requested review of D9932: [native] Introduce Rust encryption functions.
Nov 20 2023, 9:57 AM
michal requested review of D9926: [native] Expose SecureStore to Rust.
Nov 20 2023, 1:53 AM

Nov 17 2023

michal requested review of D9925: [native] Rust futures in C++.
Nov 17 2023, 10:07 AM
michal requested review of D9923: [native] Make SecureStore methods static.
Nov 17 2023, 9:04 AM
michal accepted D9915: [lib] Refactor baseReducer.
Nov 17 2023, 8:09 AM

Nov 16 2023

michal accepted D9820: [lib] Refactor keyserver reducer pt.2 - early return.
Nov 16 2023, 5:06 AM
michal accepted D9764: [lib] Inline reduceLastCommunicatedPlatformDetails.
Nov 16 2023, 5:04 AM
michal accepted D9763: [lib] Inline reduceUpdatesCurrentAsOf.
Nov 16 2023, 4:52 AM

Nov 15 2023

michal accepted D9865: [Flow202][keyserver][skip-ci] [16/x] Address type errors in message-fetchers.js.
Nov 15 2023, 1:35 AM
michal accepted D9853: [Flow202][keyserver][skip-ci] [5/x] Address type errors in keyserver/src/push/utils.js.

Some suggestions in inline comments, but looks good to me either way

Nov 15 2023, 1:34 AM

Nov 14 2023

michal accepted D9872: [Flow202][keyserver][skip-ci] [23/x] Address type errors in addSessionChangeInfoToResult.
Nov 14 2023, 7:35 AM
michal accepted D9869: [Flow202][keyserver][skip-ci] [20/x] Add any-casts for invalid validator tests.

Alternatively we could use //$FlowExpectedError, but doesn't really matter

Nov 14 2023, 7:34 AM
michal accepted D9866: [Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of accountUpdateInputValidator.

As an alternative, in a few places where I had to deal with a deprecated field I typed them as an optional empty field (e.g. email?: empty):

  • we don't need to introduce a new type
  • flow still guards us against using the deprecated field on the server
Nov 14 2023, 7:34 AM
michal accepted D9861: [Flow202][keyserver][skip-ci] [12/x] Address type errors with getInitialReduxStateResponder.
Nov 14 2023, 7:30 AM
michal accepted D9818: Refactor Windows push code to match conventions for other platforms.
Nov 14 2023, 7:21 AM
michal accepted D9882: [lib] Calculate currentAsOf for every keyserver in mergeNewMessages.
Nov 14 2023, 7:13 AM
michal accepted D9881: [lib] Add function for finding the time of the newest message per keyserver.
Nov 14 2023, 7:06 AM
michal accepted D9879: [keyserver][lib] Update freshMessageStore to return currentAsOf for all keyservers.
Nov 14 2023, 7:04 AM
michal added inline comments to D9820: [lib] Refactor keyserver reducer pt.2 - early return.
Nov 14 2023, 7:01 AM
michal accepted D9852: [Flow202][keyserver][skip-ci] [4/x] Address type error in rescindPushNotifs.
Nov 14 2023, 6:21 AM
michal requested changes to D9820: [lib] Refactor keyserver reducer pt.2 - early return.
Nov 14 2023, 6:17 AM
michal accepted D9816: [lib] Inline reduceDeviceToken.
Nov 14 2023, 6:11 AM
michal accepted D9815: [lib] Inline reduceConnectionInfo pt.2.
Nov 14 2023, 6:07 AM
michal accepted D9803: [lib] Inline reduceConnectionInfo pt.1.
Nov 14 2023, 5:25 AM
michal added inline comments to D9764: [lib] Inline reduceLastCommunicatedPlatformDetails.
Nov 14 2023, 5:12 AM
michal added inline comments to D9763: [lib] Inline reduceUpdatesCurrentAsOf.
Nov 14 2023, 4:10 AM
michal accepted D9750: [lib] Refactor keyserver reducer pt.1.
Nov 14 2023, 4:06 AM

Nov 9 2023

michal updated the diff for D9760: [CI] Fix macOS GitHub CI.

Add the python node-gyp fix to all js CI workflows.

Nov 9 2023, 6:52 AM

Nov 8 2023

michal requested review of D9760: [CI] Fix macOS GitHub CI.
Nov 8 2023, 1:48 PM

Nov 7 2023

michal accepted D9650: [keyserver][web] Refactor getInitialReduxState action.
Nov 7 2023, 3:46 AM
michal accepted D9661: Decrypt encrypted web notifications in service worker.

Could we amend the test plan with testing on safari and testing of incorrectly decrypted notifications?

Nov 7 2023, 3:43 AM
michal accepted D9620: Encrypt notifications for web clients supporting decryption.
Nov 7 2023, 3:25 AM
michal accepted D9727: [keyserver] add log while receiving response to a non-existing Tunnelbroker request.
Nov 7 2023, 3:04 AM
michal accepted D9730: [lib/keyserver] configure Tunnelbroker URL.
Nov 7 2023, 3:04 AM
michal accepted D9648: [lib][web][native] Refactor actions in user-actions.js pt.3 - login.
Nov 7 2023, 3:03 AM
michal added a comment to D9650: [keyserver][web] Refactor getInitialReduxState action.

We might also want to remove invite secret from urlinfo

Nov 7 2023, 2:44 AM
michal added inline comments to D9648: [lib][web][native] Refactor actions in user-actions.js pt.3 - login.
Nov 7 2023, 2:38 AM
michal updated the diff for D9739: [web] Move getSafariEncryptionKey to initPromise.

Readonly

Nov 7 2023, 2:20 AM
michal accepted D9645: [lib][web][native] Refactor actions in user-actions.js pt.2.
Nov 7 2023, 2:15 AM
michal accepted D9640: [keyserver][lib] Remove id from LoggedOutUserInfo.
Nov 7 2023, 2:12 AM
michal accepted D9622: [lib][web][native] Move deviceToken to keyserverStore.
Nov 7 2023, 2:11 AM
michal updated the diff for D9739: [web] Move getSafariEncryptionKey to initPromise.

Additionaly link the init in progress status to the init promise with types, so we won't get this situation in the future (an async operation between setting the status and setting the init promise).

Nov 7 2023, 1:45 AM
michal requested review of D9739: [web] Move getSafariEncryptionKey to initPromise.
Nov 7 2023, 1:12 AM

Nov 6 2023

michal requested review of D9722: [lib] Remove withCredentials on upload blob call.
Nov 6 2023, 2:10 AM
michal accepted D9721: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase.
Nov 6 2023, 1:37 AM
michal accepted D9718: [Flow202][electron-update-server][skip-ci] [3/3] Fix Flow issues in electron-update-server.
Nov 6 2023, 1:32 AM
michal accepted D9717: [Flow202][electron-update-server][skip-ci] [2/3] Use the same flow-typed libdef for express throughout our codebase.
Nov 6 2023, 1:30 AM
michal accepted D9716: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run Prettier on flow-typed folders.
Nov 6 2023, 1:30 AM
michal accepted D9714: [Flow202][lib][skip-ci] [22/23] Fix Flow issues with untyped conversionFunctions in conversion-utils.js.
Nov 6 2023, 1:28 AM
michal accepted D9670: [identity] pull out CORS logic.
Nov 6 2023, 1:25 AM

Nov 3 2023

michal accepted D9679: [identity] check if wallet address is reserved in LoginWalletUser RPC.
Nov 3 2023, 8:22 AM
michal accepted D9678: [identity] add RPC for logging in users with reserved wallet addresses.

LGTM but I haven't worked with identity service

Nov 3 2023, 8:22 AM
michal added inline comments to D9650: [keyserver][web] Refactor getInitialReduxState action.
Nov 3 2023, 7:57 AM
michal added a comment to D9640: [keyserver][lib] Remove id from LoggedOutUserInfo.

Will this break logging out on older clients?

Nov 3 2023, 7:51 AM
michal accepted D9636: [keyserver][lib][native] Refactor getVersion action.
Nov 3 2023, 7:45 AM
michal accepted D9628: [lib][web][native] Refactor setDeviceToken action.
Nov 3 2023, 7:39 AM
michal added a comment to D9622: [lib][web][native] Move deviceToken to keyserverStore.

Don't we need a migration for web too?

Nov 3 2023, 7:29 AM
michal accepted D9617: [web] implement screen for testing Tunnelbroker.
Nov 3 2023, 7:06 AM
michal accepted D9630: [Tunnelbroker] implement socket Heartbeats.
Nov 3 2023, 6:53 AM
michal accepted D9618: [native] implement screen for testing Tunnelbroker.
Nov 3 2023, 6:50 AM
michal accepted D9371: [lib][web][native] Refactor actions in thread-actions.js pt.2.
Nov 3 2023, 5:19 AM
michal accepted D9356: [lib][web][native] Refactor actions in entry-actions.js.
Nov 3 2023, 5:17 AM
michal accepted D9644: [lib] Add function for splitting calendar query per keyserver.
Nov 3 2023, 5:13 AM
michal accepted D9632: [lib] implement socket Heartbeats with Tunnelbroker.
Nov 3 2023, 5:03 AM
michal accepted D9631: [keyserver] implement Tunnelbroker socket Heartbeats.
Nov 3 2023, 4:56 AM
michal added inline comments to D9630: [Tunnelbroker] implement socket Heartbeats.
Nov 3 2023, 4:46 AM
michal added inline comments to D9618: [native] implement screen for testing Tunnelbroker.
Nov 3 2023, 4:22 AM
michal added inline comments to D9617: [web] implement screen for testing Tunnelbroker.
Nov 3 2023, 4:19 AM
michal accepted D9623: [keyserver] implement socket and update code to interact with Tunnelbroker API.
Nov 3 2023, 4:15 AM
michal accepted D9611: [lib] handle Tunnelbroker messages.

Please check the console.warn/error before landing but looks good.

Nov 3 2023, 4:07 AM
michal added a comment to D9670: [identity] pull out CORS logic.

Nice to see the magic string constants removed!

Nov 3 2023, 3:51 AM

Nov 2 2023

michal accepted D9610: [native] create Tunnelbroker session.
Nov 2 2023, 9:00 AM