Update for flow 202
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 27 2023
Rebase
Rebase
Fix position of the variable, it was a mistake - I extracted the handler function but didn't move the variable declaration with it.
Nov 24 2023
An issue with with non-static methods calling the static methods is that the ByteBuffer -> SecretKeySpec conversion must go through ByteArray (with a copy). So that means that we would have ByteArray -no-copy-> ByteBuffer -with-copy-> ByteArray -> SecretKeySpec. As the static methods are very minimal and most of the code is in encryptAES/ decryptAES functions I don't it's worth it.
Fix naming
Rebase after a new approach to error handling
Improve error handling
Accepting, but please fix the issues in inline comments.
Nov 22 2023
Fix line lengths
Nov 21 2023
Nov 20 2023
Nov 17 2023
Nov 16 2023
Nov 15 2023
Some suggestions in inline comments, but looks good to me either way
Nov 14 2023
Alternatively we could use //$FlowExpectedError, but doesn't really matter
As an alternative, in a few places where I had to deal with a deprecated field I typed them as an optional empty field (e.g. email?: empty):
- we don't need to introduce a new type
- flow still guards us against using the deprecated field on the server
Nov 9 2023
Add the python node-gyp fix to all js CI workflows.
Nov 8 2023
Nov 7 2023
Could we amend the test plan with testing on safari and testing of incorrectly decrypted notifications?
We might also want to remove invite secret from urlinfo
Readonly
Additionaly link the init in progress status to the init promise with types, so we won't get this situation in the future (an async operation between setting the status and setting the init promise).
Nov 6 2023
Nov 3 2023
LGTM but I haven't worked with identity service
Will this break logging out on older clients?
Don't we need a migration for web too?
Please check the console.warn/error before landing but looks good.
Nice to see the magic string constants removed!