Page MenuHomePhabricator
Feed Advanced Search

Jan 23 2024

atul updated the diff for D10721: [lib] Remove `LegacyThreadInfo` and `legacyThreadInfoValidator`.

rebase

Jan 23 2024, 2:31 PM
atul planned changes to D10718: [lib] Remove branching from `threadInfoFromRawThreadInfo(...)`.
Jan 23 2024, 2:30 PM
atul updated the diff for D10720: [lib] Remove `LegacyThreadInfo`-related type utilities.

rebase

Jan 23 2024, 2:30 PM
atul updated the diff for D10718: [lib] Remove branching from `threadInfoFromRawThreadInfo(...)`.

rebase

Jan 23 2024, 2:30 PM
atul closed D10715: [lib] Remove most remaining instances of `LegacyThreadInfo` from codebase.
Jan 23 2024, 1:43 PM
atul committed rCOMMbb8bbfc48e62: [lib] Remove most remaining instances of `LegacyThreadInfo` from codebase (authored by atul).
[lib] Remove most remaining instances of `LegacyThreadInfo` from codebase
Jan 23 2024, 1:43 PM
atul closed D10678: [lib] Remove `LegacyThreadInfo` where simple in `thread-utils`.
Jan 23 2024, 1:43 PM
atul closed D10713: [keyserver] Remove single instance of `LegacyThreadInfo` from `keyserver`.
Jan 23 2024, 1:43 PM
atul committed rCOMM9c90ec603092: [keyserver] Remove single instance of `LegacyThreadInfo` from `keyserver` (authored by atul).
[keyserver] Remove single instance of `LegacyThreadInfo` from `keyserver`
Jan 23 2024, 1:43 PM
atul closed D10677: [lib] Remove most remaining instances of `LegacyThreadInfo` from `lib`.
Jan 23 2024, 1:43 PM
atul committed rCOMMa28f6312402f: [lib] Remove `LegacyThreadInfo` where simple in `thread-utils` (authored by atul).
[lib] Remove `LegacyThreadInfo` where simple in `thread-utils`
Jan 23 2024, 1:43 PM
atul committed rCOMM1ac76618d00a: [lib] Remove most remaining instances of `LegacyThreadInfo` from `lib` (authored by atul).
[lib] Remove most remaining instances of `LegacyThreadInfo` from `lib`
Jan 23 2024, 1:43 PM
atul closed D10676: [native] Remove all instances of `LegacyThreadInfo` from `native`.
Jan 23 2024, 1:43 PM
atul closed D10675: [web] Remove all instances of `LegacyThreadInfo` from `web`.
Jan 23 2024, 1:43 PM
atul committed rCOMM2d36c951d4b8: [native] Remove all instances of `LegacyThreadInfo` from `native` (authored by atul).
[native] Remove all instances of `LegacyThreadInfo` from `native`
Jan 23 2024, 1:43 PM
atul committed rCOMMc1e3ee4ceae4: [web] Remove all instances of `LegacyThreadInfo` from `web` (authored by atul).
[web] Remove all instances of `LegacyThreadInfo` from `web`
Jan 23 2024, 1:43 PM
atul closed D10674: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`.
Jan 23 2024, 1:43 PM
atul committed rCOMMbd411a4d45ba: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo` (authored by atul).
Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`
Jan 23 2024, 1:43 PM
atul updated the diff for D10715: [lib] Remove most remaining instances of `LegacyThreadInfo` from codebase.

remove extraneous import changes

Jan 23 2024, 1:38 PM
atul updated the diff for D10677: [lib] Remove most remaining instances of `LegacyThreadInfo` from `lib`.

remove extraneous import changes

Jan 23 2024, 1:35 PM
atul updated the diff for D10676: [native] Remove all instances of `LegacyThreadInfo` from `native`.

remove extraneous import order changes

Jan 23 2024, 1:29 PM
atul updated the diff for D10675: [web] Remove all instances of `LegacyThreadInfo` from `web`.

remove extraneous import changes

Jan 23 2024, 1:16 PM
atul updated the diff for D10715: [lib] Remove most remaining instances of `LegacyThreadInfo` from codebase.

rebase

Jan 23 2024, 1:01 PM
atul updated the diff for D10713: [keyserver] Remove single instance of `LegacyThreadInfo` from `keyserver`.

rebase

Jan 23 2024, 1:01 PM
atul updated the diff for D10678: [lib] Remove `LegacyThreadInfo` where simple in `thread-utils`.

rebase

Jan 23 2024, 1:01 PM
atul updated the diff for D10677: [lib] Remove most remaining instances of `LegacyThreadInfo` from `lib`.

rebase

Jan 23 2024, 1:01 PM
atul updated the diff for D10676: [native] Remove all instances of `LegacyThreadInfo` from `native`.

rebase

Jan 23 2024, 1:00 PM
atul updated the diff for D10675: [web] Remove all instances of `LegacyThreadInfo` from `web`.

rebase

Jan 23 2024, 12:59 PM
atul updated the diff for D10674: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`.

rebase

Jan 23 2024, 12:59 PM
atul closed D10673: Remove `LegacyResolvedThreadInfo` from the codebase entirely.
Jan 23 2024, 12:53 PM
atul committed rCOMM8baab0e38b7b: Remove `LegacyResolvedThreadInfo` from the codebase entirely (authored by atul).
Remove `LegacyResolvedThreadInfo` from the codebase entirely
Jan 23 2024, 12:53 PM
atul closed D10672: [native] Remove instances of `LegacyThreadInfo` throughout `native`.
Jan 23 2024, 12:53 PM
atul closed D10671: [web] Remove instances of `LegacyThreadInfo` throughout `web`.
Jan 23 2024, 12:53 PM
atul committed rCOMMf91dff46177f: [web] Remove instances of `LegacyThreadInfo` throughout `web` (authored by atul).
[web] Remove instances of `LegacyThreadInfo` throughout `web`
Jan 23 2024, 12:53 PM
atul committed rCOMMc3d4ce4381b0: [native] Remove instances of `LegacyThreadInfo` throughout `native` (authored by atul).
[native] Remove instances of `LegacyThreadInfo` throughout `native`
Jan 23 2024, 12:53 PM
atul closed D10670: [lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo`.
Jan 23 2024, 12:53 PM
atul committed rCOMMbb09d5147ba2: [lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo` (authored by atul).
[lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo`
Jan 23 2024, 12:53 PM
atul updated the diff for D10673: Remove `LegacyResolvedThreadInfo` from the codebase entirely.

rebase

Jan 23 2024, 12:34 PM
atul updated the diff for D10672: [native] Remove instances of `LegacyThreadInfo` throughout `native`.

rebase

Jan 23 2024, 12:34 PM
atul updated the diff for D10671: [web] Remove instances of `LegacyThreadInfo` throughout `web`.

rebase

Jan 23 2024, 12:34 PM
atul updated the diff for D10670: [lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo`.

rebase

Jan 23 2024, 12:34 PM
atul closed D10655: Expand `ResolvedThreadInfo` alias to `[Legacy/MinimallyEncoded]ResolvedThreadInfo`.
Jan 23 2024, 12:19 PM
atul committed rCOMM620ae7032a44: Expand `ResolvedThreadInfo` alias to `[Legacy/MinimallyEncoded]ResolvedThreadIn… (authored by atul).
Expand `ResolvedThreadInfo` alias to `[Legacy/MinimallyEncoded]ResolvedThreadIn…
Jan 23 2024, 12:19 PM
atul updated the diff for D10655: Expand `ResolvedThreadInfo` alias to `[Legacy/MinimallyEncoded]ResolvedThreadInfo`.

rebase

Jan 23 2024, 12:18 PM
atul added a comment to D10709: Refactor main compaction creation and restore not to use ORM.

Agree that it would be good to check that the call to make_storage() isn't "filling in any gaps" from our SQL queries.

Jan 23 2024, 5:40 AM

Jan 22 2024

atul updated the diff for D10655: Expand `ResolvedThreadInfo` alias to `[Legacy/MinimallyEncoded]ResolvedThreadInfo`.

There was some extraneous re-ordering of imports in this diff. Removed those changes.

Jan 22 2024, 1:37 PM
atul closed D10654: [lib] Remove instances of `LegacyThreadInfo` from `DrawerUtils`.
Jan 22 2024, 1:28 PM
atul committed rCOMMafd1a3c40871: [lib] Remove instances of `LegacyThreadInfo` from `DrawerUtils` (authored by atul).
[lib] Remove instances of `LegacyThreadInfo` from `DrawerUtils`
Jan 22 2024, 1:28 PM
atul closed D10646: [lib] Narrow `threadUIName` to `ThreadInfo`.
Jan 22 2024, 1:28 PM
atul closed D10645: [lib] First pass at removing `LegacyThreadInfo` from `chat-selectors`.
Jan 22 2024, 1:28 PM
atul committed rCOMMdf18b2bb378c: [lib] First pass at removing `LegacyThreadInfo` from `chat-selectors` (authored by atul).
[lib] First pass at removing `LegacyThreadInfo` from `chat-selectors`
Jan 22 2024, 1:28 PM
atul committed rCOMM5f0b85664bf1: [lib] Narrow `threadUIName` to `ThreadInfo` (authored by atul).
[lib] Narrow `threadUIName` to `ThreadInfo`
Jan 22 2024, 1:28 PM
atul closed D10644: [lib] Remove `LegacyThreadInfo` from `thread-selectors`.
Jan 22 2024, 1:28 PM
atul committed rCOMM2c634e25c419: [lib] Remove `LegacyThreadInfo` from `thread-selectors` (authored by atul).
[lib] Remove `LegacyThreadInfo` from `thread-selectors`
Jan 22 2024, 1:28 PM
atul updated the diff for D10675: [web] Remove all instances of `LegacyThreadInfo` from `web`.

rebase

Jan 22 2024, 1:24 PM
atul updated the diff for D10674: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`.

rebase

Jan 22 2024, 12:53 PM
atul updated the diff for D10673: Remove `LegacyResolvedThreadInfo` from the codebase entirely.

rebase

Jan 22 2024, 12:52 PM
atul updated the diff for D10672: [native] Remove instances of `LegacyThreadInfo` throughout `native`.

rebase

Jan 22 2024, 12:51 PM
atul updated the diff for D10671: [web] Remove instances of `LegacyThreadInfo` throughout `web`.

rebase

Jan 22 2024, 12:50 PM
atul updated the diff for D10670: [lib] Update `useResolvedThreadInfos` to remove `LegacyThreadInfo`.

rebase

Jan 22 2024, 12:50 PM
atul updated the diff for D10655: Expand `ResolvedThreadInfo` alias to `[Legacy/MinimallyEncoded]ResolvedThreadInfo`.

rebase

Jan 22 2024, 12:49 PM
atul updated the diff for D10654: [lib] Remove instances of `LegacyThreadInfo` from `DrawerUtils`.

rebase

Jan 22 2024, 12:48 PM
atul updated the diff for D10646: [lib] Narrow `threadUIName` to `ThreadInfo`.

rebase

Jan 22 2024, 12:48 PM
atul updated the diff for D10645: [lib] First pass at removing `LegacyThreadInfo` from `chat-selectors`.

rebase

Jan 22 2024, 12:48 PM
atul updated the diff for D10644: [lib] Remove `LegacyThreadInfo` from `thread-selectors`.

rebase

Jan 22 2024, 12:47 PM
atul closed D10643: Rename `MinimallyEncodedThreadInfo` to `ThreadInfo`.
Jan 22 2024, 12:36 PM
atul closed D10642: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`.
Jan 22 2024, 12:36 PM
atul committed rCOMM93a9cdc2730f: Rename `MinimallyEncodedThreadInfo` to `ThreadInfo` (authored by atul).
Rename `MinimallyEncodedThreadInfo` to `ThreadInfo`
Jan 22 2024, 12:36 PM
atul committed rCOMM91e6d77671c9: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo` (authored by atul).
[lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`
Jan 22 2024, 12:36 PM
atul closed D10641: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-utils`.
Jan 22 2024, 12:36 PM
atul closed D10639: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`.
Jan 22 2024, 12:36 PM
atul committed rCOMMaadf73d8ac7d: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in… (authored by atul).
[lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in…
Jan 22 2024, 12:36 PM
atul closed D10640: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-selectors`.
Jan 22 2024, 12:36 PM
atul committed rCOMMc9e36aac647c: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in… (authored by atul).
[lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in…
Jan 22 2024, 12:36 PM
atul committed rCOMM4b48e731c0a1: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` (authored by atul).
Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`
Jan 22 2024, 12:36 PM
atul closed D10638: [lib] Rename `MinimallyEncodedRawThreadInfos` to `RawThreadInfos`.
Jan 22 2024, 12:36 PM
atul committed rCOMM84ddabe734d6: [lib] Rename `MinimallyEncodedRawThreadInfos` to `RawThreadInfos` (authored by atul).
[lib] Rename `MinimallyEncodedRawThreadInfos` to `RawThreadInfos`
Jan 22 2024, 12:36 PM
atul closed D10637: [lib] Rename `RawThreadInfos` to `MixedRawThreadInfos`.
Jan 22 2024, 12:36 PM
atul committed rCOMM406f32b4afe1: [lib] Rename `RawThreadInfos` to `MixedRawThreadInfos` (authored by atul).
[lib] Rename `RawThreadInfos` to `MixedRawThreadInfos`
Jan 22 2024, 12:36 PM
atul updated the diff for D10639: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`.

add newline after @flow

Jan 22 2024, 12:27 PM
atul added inline comments to D10639: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`.
Jan 22 2024, 12:26 PM
atul added a comment to D10639: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`.

This is going to add a lot of noise to the codebase... what % of these unions do you think you'll be able to "back out" back to just the minimally-encoded variant?

Jan 22 2024, 12:25 PM
atul updated the diff for D10643: Rename `MinimallyEncodedThreadInfo` to `ThreadInfo`.

rebase

Jan 22 2024, 12:23 PM
atul updated the diff for D10642: [lib] Remove `ThreadInfo` alias for `[Legacy/MinimallyEncoded]ThreadInfo`.

rebase

Jan 22 2024, 12:22 PM
atul updated the diff for D10641: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-utils`.

rebase

Jan 22 2024, 12:22 PM
atul updated the diff for D10640: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-selectors`.

rebase

Jan 22 2024, 12:21 PM
atul updated the diff for D10639: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`.

rebase

Jan 22 2024, 12:18 PM
atul updated the diff for D10638: [lib] Rename `MinimallyEncodedRawThreadInfos` to `RawThreadInfos`.

rebase

Jan 22 2024, 12:06 PM
atul updated the diff for D10637: [lib] Rename `RawThreadInfos` to `MixedRawThreadInfos`.

rebase

Jan 22 2024, 12:05 PM
atul closed D10634: Rename `MinimallyEncodedRawThreadInfo` to `RawThreadInfo`.
Jan 22 2024, 12:00 PM
atul closed D10627: [lib] First pass at removing `RawThreadInfos`.
Jan 22 2024, 12:00 PM
atul committed rCOMM13322dfcb291: Rename `MinimallyEncodedRawThreadInfo` to `RawThreadInfo` (authored by atul).
Rename `MinimallyEncodedRawThreadInfo` to `RawThreadInfo`
Jan 22 2024, 12:00 PM
atul committed rCOMMdd5f7f87996d: [lib] First pass at removing `RawThreadInfos` (authored by atul).
[lib] First pass at removing `RawThreadInfos`
Jan 22 2024, 12:00 PM
atul closed D10626: [lib] First pass at removing `LegacyRawThreadInfo`.
Jan 22 2024, 12:00 PM
atul closed D10625: Expand instances of `RawThreadInfo` to `LegacyRawThreadInfo|MinimallyEncodedRawTheadInfo`.
Jan 22 2024, 12:00 PM
atul committed rCOMM56cde60e0bc9: [lib] First pass at removing `LegacyRawThreadInfo` (authored by atul).
[lib] First pass at removing `LegacyRawThreadInfo`
Jan 22 2024, 12:00 PM
atul committed rCOMMa43befba77b9: Expand instances of `RawThreadInfo` to `LegacyRawThreadInfo|MinimallyEncodedRaw… (authored by atul).
Expand instances of `RawThreadInfo` to `LegacyRawThreadInfo|MinimallyEncodedRaw…
Jan 22 2024, 12:00 PM
atul updated the diff for D10634: Rename `MinimallyEncodedRawThreadInfo` to `RawThreadInfo`.

rebase

Jan 22 2024, 11:56 AM
atul updated the diff for D10627: [lib] First pass at removing `RawThreadInfos`.

rebase

Jan 22 2024, 11:55 AM
atul updated the diff for D10626: [lib] First pass at removing `LegacyRawThreadInfo`.

rebase

Jan 22 2024, 11:53 AM