Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 29 2024

michal requested review of D10857: [backup] Namespace log id in db.
Jan 29 2024, 2:59 AM
michal requested review of D10858: [native] Notify backup uploader after compaction creation.
Jan 29 2024, 2:55 AM

Jan 25 2024

michal accepted D10650: [lib] Refactor logout in reduceEntryInfos.
Jan 25 2024, 6:25 AM
michal requested changes to D10648: [lib][web][native] Stop removing some state on keyserver logout.

Requesting changes for some explanations so I can understand the diff better. Feel free to re-request.

Jan 25 2024, 6:20 AM
michal updated the diff for D10633: [native] Backup log upload.

Rebase

Jan 25 2024, 6:20 AM
michal accepted D10649: [lib] Stop removing policies on keyserver logout.
Jan 25 2024, 6:15 AM
michal accepted D10647: [lib] Remove threads from calendar filters on logout.

I think the diff description stopped matching the changes.

Jan 25 2024, 6:01 AM
michal accepted D10628: [lib] Refactor user reducer.
Jan 25 2024, 5:51 AM
michal updated the diff for D10632: [native] Backup compaction upload.

Improve logging

Jan 25 2024, 5:45 AM

Jan 18 2024

michal updated the diff for D10633: [native] Backup log upload.

Some renames and code refactor to make it cleaner

Jan 18 2024, 5:20 AM
michal updated the diff for D10632: [native] Backup compaction upload.

Some renames and code refactor to make it cleaner

Jan 18 2024, 5:19 AM
michal updated the diff for D10621: [native] Implement persistent rust backup client.

Some renames and code refactor to make it cleaner

Jan 18 2024, 5:16 AM

Jan 17 2024

michal planned changes to D10633: [native] Backup log upload.
Jan 17 2024, 7:06 AM
michal planned changes to D10632: [native] Backup compaction upload.
Jan 17 2024, 7:06 AM
michal planned changes to D10621: [native] Implement persistent rust backup client.
Jan 17 2024, 7:05 AM

Jan 16 2024

michal updated the diff for D10633: [native] Backup log upload.

Refactor code

Jan 16 2024, 7:53 AM
michal updated the diff for D10632: [native] Backup compaction upload.

unwrap -> expect. Refactored the code into separate functions so it's cleaner.

Jan 16 2024, 7:48 AM
michal accepted D10636: [lib] Refactor draft reducer.
Jan 16 2024, 7:17 AM
michal accepted D10628: [lib] Refactor user reducer.
Jan 16 2024, 7:14 AM
michal updated the diff for D10602: [backup] Allow one websocket connection to handle multiple backups.

Rebase

Jan 16 2024, 7:09 AM
michal added inline comments to D10621: [native] Implement persistent rust backup client.
Jan 16 2024, 6:56 AM
michal updated the diff for D10621: [native] Implement persistent rust backup client.

Fixes

Jan 16 2024, 6:56 AM
michal accepted D10619: [lib] Refactor report store reducer.
Jan 16 2024, 6:30 AM
michal requested review of D10651: [rust] Formatting and clippy fixes.
Jan 16 2024, 6:24 AM

Jan 15 2024

michal updated the diff for D10309: [web/native/lib] Combine openSocketSelector from web and native.

Rebase

Jan 15 2024, 7:10 AM
michal requested review of D10633: [native] Backup log upload.
Jan 15 2024, 7:10 AM
michal requested review of D10632: [native] Backup compaction upload.
Jan 15 2024, 7:02 AM
michal requested review of D10630: [native] Function for triggering file data upload.
Jan 15 2024, 6:36 AM
michal requested review of D10629: [native] Start/stop backup client from JS.
Jan 15 2024, 4:58 AM
michal requested review of D10621: [native] Implement persistent rust backup client.
Jan 15 2024, 4:55 AM
michal accepted D10404: [identity] Reorder device list when updated.
Jan 15 2024, 3:49 AM

Jan 12 2024

michal requested review of D10605: [native] Filepath generation for log and userkeys data.
Jan 12 2024, 6:41 AM
michal accepted D10603: [lib][web][native] Make possible to log out of one keyserver / delete account on one keyserver.
Jan 12 2024, 5:50 AM

Jan 11 2024

michal accepted D10590: [lib][native] Handle invalidSessionRecovery for keyserver auth.
Jan 11 2024, 8:13 AM
michal requested review of D10604: [native] Change backup file separator.
Jan 11 2024, 8:05 AM
michal accepted D10591: [lib] Fix types in deleteThread.
Jan 11 2024, 7:58 AM
michal requested review of D10602: [backup] Allow one websocket connection to handle multiple backups.
Jan 11 2024, 7:58 AM
michal accepted D10589: [lib] Refactor reduceMessageStore.
Jan 11 2024, 7:57 AM
michal requested review of D10601: [backup] Log cleanup.
Jan 11 2024, 7:50 AM
michal accepted D10592: [web] make sure all tabs and worker are operating on the same web version.

When we open a new tab with the new version, old tabs are in the background so it should be safe because the worker should not be performing anything on DB.

Jan 11 2024, 3:45 AM

Jan 10 2024

michal requested review of D10595: [native] Remove unwrap in backup testing code.
Jan 10 2024, 8:44 AM

Jan 9 2024

michal accepted D10379: [lib/native] introduce handling Tunnelbroker peer-to-peer messages.
Jan 9 2024, 3:01 AM
michal accepted D10511: [lib/shared] clean `RefreshKeyRequest` type.
Jan 9 2024, 2:58 AM
michal accepted D10383: [native] add button to test send encrypted content between devices.
Jan 9 2024, 2:56 AM

Jan 8 2024

michal updated the diff for D10533: [backup-client] Downloading logs.

Removed a bit of code duplication for parsing ws messages

Jan 8 2024, 6:32 AM
michal added inline comments to D10532: [backup-client] Uploading logs.
Jan 8 2024, 6:23 AM
michal updated the diff for D10532: [backup-client] Uploading logs.

Remove return

Jan 8 2024, 6:23 AM
michal updated the diff for D10456: [backup] Log upload endpoint.

Remove Arcs

Jan 8 2024, 6:19 AM
michal updated the diff for D10453: [backup] Implement basic websocket.

Fix rebase error

Jan 8 2024, 6:16 AM
michal updated the diff for D10453: [backup] Implement basic websocket.

Remove Arcs

Jan 8 2024, 6:13 AM
michal updated the diff for D10453: [backup] Implement basic websocket.

Respond to review

Jan 8 2024, 6:06 AM
michal updated the diff for D10453: [backup] Implement basic websocket.

Rebase

Jan 8 2024, 5:58 AM
michal updated the summary of D10451: [backup] Improve logging.
Jan 8 2024, 4:20 AM
michal updated the diff for D10451: [backup] Improve logging.

Removed logging of sensitive data.

Jan 8 2024, 4:19 AM
michal accepted D10379: [lib/native] introduce handling Tunnelbroker peer-to-peer messages.
Jan 8 2024, 3:42 AM
michal accepted D10552: [lib] Reduce notAcknowledgedPolicies on keyserver login.
Jan 8 2024, 3:35 AM
michal added inline comments to D10490: [lib] add olm auth action.
Jan 8 2024, 3:35 AM
michal accepted D10551: [lib] Hash new threads on keyserver login.

Does your updated code already separate out only the threads from the newly logged-in keyserver for hashing?

Jan 8 2024, 3:16 AM
michal accepted D10574: [services] update Cargo.lock files.
Jan 8 2024, 2:49 AM

Jan 5 2024

michal accepted D10512: Enable backup creation and restoration from Rust.
Jan 5 2024, 6:31 AM
michal accepted D10509: Implement C++ file to expose backup API.
Jan 5 2024, 6:30 AM
michal added inline comments to D10502: Implement tools to manage backup files.
Jan 5 2024, 6:22 AM
michal added a comment to D10508: [lib] Reset globalThemeInfo and dataLoaded on identity login.

So this app state without keyservers will be visible to the users right? Do other features work or at least they don't crash the app? E.g. "Create new chat" and "create community" buttons, thread search, calendar view?

Jan 5 2024, 6:18 AM
michal accepted D10531: [lib][web][native] Return current calendar query in logInExtraInfo.
Jan 5 2024, 6:09 AM
michal accepted D10507: [lib] Reduce new login actions in reduceEntryInfos and reduceKeyserverStore.
Jan 5 2024, 4:13 AM
michal accepted D10426: [lib] Reduce new login actions in reduceCalendarFilters.
Jan 5 2024, 4:11 AM
michal accepted D10425: [lib] Add function for filtering out calendar filters related to one keyserver.
Jan 5 2024, 4:10 AM

Jan 4 2024

michal requested review of D10535: [native] Upload and download logs.
Jan 4 2024, 8:17 AM
michal requested review of D10534: [commtest] Check log logic in backup tests.
Jan 4 2024, 7:50 AM
michal added inline comments to D10309: [web/native/lib] Combine openSocketSelector from web and native.
Jan 4 2024, 7:49 AM
michal requested review of D10533: [backup-client] Downloading logs.
Jan 4 2024, 7:47 AM
michal requested review of D10532: [backup-client] Uploading logs.
Jan 4 2024, 7:45 AM
michal added inline comments to D10451: [backup] Improve logging.
Jan 4 2024, 7:45 AM
michal added inline comments to D10383: [native] add button to test send encrypted content between devices.
Jan 4 2024, 5:34 AM
michal accepted D10382: [native] add button to test creating olm session with own devices.
Jan 4 2024, 5:32 AM
michal accepted D10374: [CommRustModule] implement `getInboundKeys`.
Jan 4 2024, 5:28 AM
michal accepted D10525: [web] Fix default apps.
Jan 4 2024, 3:28 AM

Jan 3 2024

michal added inline comments to D10264: [native-rust-library] Upload/download user backup.
Jan 3 2024, 6:34 AM

Jan 2 2024

michal accepted D10484: [lib][web][native] Create defaultKeyserverInfo.
Jan 2 2024, 5:01 AM
michal accepted D10306: [web] avoid race condition while deleting database.
Jan 2 2024, 4:32 AM
michal accepted D10448: [identity] Use DB conversion helpers from comm-lib.

In the future we might consider refactoring parse_{some_business_logic_name}_attribute() too, but it's not a direct purpose of this task, so I replaced only these "universal" functions

Jan 2 2024, 4:21 AM
michal accepted D10447: [identity] Use DB error types from comm-lib.

If I understand the error type correctly, shouldn't we use Value::String in places where we directly create Some(AttributeValue::S(...)?

Jan 2 2024, 4:00 AM
michal added a comment to D10441: [web] Fix connection field missing.

Looks good!

Jan 2 2024, 3:28 AM
michal accepted D10446: [services] Use comm-lib aws in Identity.
Jan 2 2024, 3:02 AM
michal accepted D10443: [comm-lib] Re-export AWS types.
Jan 2 2024, 3:00 AM
michal accepted D10444: [services] Use comm-lib aws in Tunnelbroker.

Nice!

Jan 2 2024, 2:57 AM
michal accepted D10445: [identity] Update AWS SDK to match comm-lib.
Jan 2 2024, 2:49 AM

Dec 22 2023

michal requested review of D10457: [backup] Log download endpoint.
Dec 22 2023, 8:58 AM
michal requested review of D10456: [backup] Log upload endpoint.
Dec 22 2023, 8:41 AM
michal requested review of D10453: [backup] Implement basic websocket.
Dec 22 2023, 8:11 AM
michal requested review of D10452: [backup] Add new dependencies.
Dec 22 2023, 7:59 AM
michal requested review of D10451: [backup] Improve logging.
Dec 22 2023, 7:53 AM
michal added a comment to D10441: [web] Fix connection field missing.
  1. Could we apply all transforms in persistConfig.transforms dynamically instead of "hardcoding" them in migrateStorageToSQLite?
Dec 22 2023, 5:57 AM
michal accepted D10442: [lib] Remove cookie on logout.
Dec 22 2023, 5:45 AM

Dec 21 2023

michal requested review of D10428: [backup] Small refactor.
Dec 21 2023, 6:08 AM
michal requested changes to D10374: [CommRustModule] implement `getInboundKeys`.
Dec 21 2023, 5:39 AM
michal accepted D10373: [CommRustModule] update `getOutboundKeys` to return all devices.
Dec 21 2023, 5:39 AM
michal requested review of D10427: [native] Fix ordering in pbxproj.
Dec 21 2023, 5:30 AM

Dec 20 2023

michal requested review of D10410: [backup-client] Fix lockfile.
Dec 20 2023, 4:23 AM
michal accepted D10394: [native] remove android feature.
Dec 20 2023, 3:45 AM
First
Prev
Next