Page MenuHomePhabricator
Feed Advanced Search

Jun 6 2024

marcin updated the diff for D12310: Implement native wrapper for syncPlatformDetails RPC.

Rebase befoe landing

Jun 6 2024, 8:26 AM
marcin updated the diff for D12308: Enable the client to fetch users platform details from identity RPC.

Rerbase before landing

Jun 6 2024, 8:23 AM
marcin updated the diff for D12307: Add identity platform details to aux user store.

Rebase before landing

Jun 6 2024, 8:22 AM
marcin closed D12334: Deploy identity 0.22-staging to staging.
Jun 6 2024, 7:58 AM
marcin committed rCOMM47d699f758b6: Deploy identity 0.22-staging to staging (authored by marcin).
Deploy identity 0.22-staging to staging
Jun 6 2024, 7:58 AM
marcin added inline comments to D12307: Add identity platform details to aux user store.
Jun 6 2024, 5:34 AM
marcin accepted D12300: [identity] Add Serialize trait for inbound keys types.
Jun 6 2024, 2:13 AM
marcin accepted D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.
Jun 6 2024, 2:08 AM
marcin accepted D12279: [grpc_clients] Add platform details metadata.
Jun 6 2024, 2:08 AM

Jun 5 2024

marcin updated the diff for D12308: Enable the client to fetch users platform details from identity RPC.

Make inner collection immutable. Use direct assignment in a for loop.

Jun 5 2024, 6:48 AM
marcin updated the diff for D12307: Add identity platform details to aux user store.

Fix types. Use a map of [deviceID]: IdentityPlatformDetails

Jun 5 2024, 6:47 AM
marcin planned changes to D12307: Add identity platform details to aux user store.

Those types are totally wrong. We need mapping from device id to platform details. Interestingly reducer worked as expected - it put map into the SQLite.

Jun 5 2024, 5:36 AM
marcin updated the diff for D12308: Enable the client to fetch users platform details from identity RPC.
  1. Make collection mutable.
  2. Use for loop instead of forEach
Jun 5 2024, 3:00 AM
marcin updated the diff for D12307: Add identity platform details to aux user store.

Make identity platform details type readonly

Jun 5 2024, 2:59 AM
marcin added inline comments to D12307: Add identity platform details to aux user store.
Jun 5 2024, 2:47 AM
marcin accepted D12283: [grpc_clients] Accept PlatformMetadata when creating client.
Jun 5 2024, 2:24 AM
marcin accepted D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse.
Jun 5 2024, 2:23 AM
marcin updated the diff for D12312: Synchronize platform details with identity on app start.
  1. Fix typing
  2. Use hasRun ref.
  3. Fix typing of MinVersionHandler
Jun 5 2024, 2:22 AM
marcin added inline comments to D12312: Synchronize platform details with identity on app start.
Jun 5 2024, 2:20 AM
marcin added a comment to D12312: Synchronize platform details with identity on app start.

By the way, do you think it makes sense to merge this with VersionSupportedChecker component?

I was thinking about this but I couldn't find any compelling arguments against neither of those solutions. What made me finally decide to use separate component was that we have two different components to check version support on native on web. However this logic is exactly the same for both platforms so putting it inside version support checkers would result in code duplication.

Jun 5 2024, 2:13 AM

Jun 4 2024

marcin updated subscribers of D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse.
Jun 4 2024, 9:35 AM
marcin accepted D12280: [web] Add platform details metadata.
Jun 4 2024, 9:33 AM
marcin added inline comments to D12283: [grpc_clients] Accept PlatformMetadata when creating client.
Jun 4 2024, 9:23 AM
marcin added inline comments to D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.
Jun 4 2024, 9:20 AM
marcin added inline comments to D12279: [grpc_clients] Add platform details metadata.
Jun 4 2024, 9:09 AM
marcin accepted D12275: [native_rust_library] Write state version as build-time constant.
Jun 4 2024, 9:06 AM
marcin accepted D12274: [identity][protos] Add RPC to update PlatformDetails.
Jun 4 2024, 9:03 AM
marcin accepted D12273: [identity] Fetch platform details along with device lists.
Jun 4 2024, 9:01 AM
marcin added inline comments to D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse.
Jun 4 2024, 9:00 AM
marcin accepted D12270: [identity] Add metadata parser for PlatformDetails.
Jun 4 2024, 7:57 AM
marcin accepted D12271: [identity] Get device PlatformDetails from metadata.
Jun 4 2024, 7:52 AM
marcin accepted D12269: [identity] Introduce PlatformDetails DDB attribute.
Jun 4 2024, 7:48 AM
marcin updated the diff for D12312: Synchronize platform details with identity on app start.

Check against usingCommServicesAccessToken before trying to sync platform details

Jun 4 2024, 7:45 AM
marcin requested review of D12312: Synchronize platform details with identity on app start.
Jun 4 2024, 7:26 AM
marcin requested review of D12311: Expose syncing platform details to identity client context.
Jun 4 2024, 7:02 AM
marcin requested review of D12310: Implement native wrapper for syncPlatformDetails RPC.
Jun 4 2024, 6:59 AM
marcin requested review of D12308: Enable the client to fetch users platform details from identity RPC.
Jun 4 2024, 1:46 AM
marcin requested review of D12307: Add identity platform details to aux user store.
Jun 4 2024, 1:34 AM

May 27 2024

marcin closed D12142: Implement JSI for EntryStore.
May 27 2024, 5:45 AM
marcin closed D12148: Connect pipes between C++ and JS for entry store.
May 27 2024, 5:45 AM
marcin committed rCOMM3c0246a0af6b: Implement JSI for EntryStore (authored by marcin).
Implement JSI for EntryStore
May 27 2024, 5:45 AM
marcin committed rCOMMb51b09fb1359: Connect pipes between C++ and JS for entry store (authored by marcin).
Connect pipes between C++ and JS for entry store
May 27 2024, 5:45 AM
marcin closed D12138: Implement SQLite API to handle entry store.
May 27 2024, 5:45 AM
marcin committed rCOMM34fae12d44fa: Implement SQLite API to handle entry store (authored by marcin).
Implement SQLite API to handle entry store
May 27 2024, 5:45 AM

May 24 2024

marcin updated the test plan for D12169: [web] Replace persisted entries with the ones from initial redux state.
May 24 2024, 9:14 AM
marcin accepted D12050: [lib] Create a compaction after schema-changing migration.

Soo we will remove backupEnabledByDefault and replace it with proper check for being primary device.

May 24 2024, 8:28 AM
marcin updated the test plan for D12164: [lib] Migrate remaining actions.
May 24 2024, 8:17 AM
marcin updated the test plan for D12162: [lib] Replace merging entries with an ops approach.
May 24 2024, 8:16 AM
marcin updated the test plan for D12164: [lib] Migrate remaining actions.
May 24 2024, 8:03 AM
marcin updated the test plan for D12162: [lib] Replace merging entries with an ops approach.
May 24 2024, 8:01 AM
marcin updated the test plan for D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
May 24 2024, 7:54 AM
marcin updated the test plan for D12164: [lib] Migrate remaining actions.
May 24 2024, 7:52 AM
marcin updated the test plan for D12164: [lib] Migrate remaining actions.
May 24 2024, 7:39 AM
marcin updated the test plan for D12162: [lib] Replace merging entries with an ops approach.
May 24 2024, 7:38 AM
marcin updated the test plan for D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
May 24 2024, 7:36 AM
marcin updated the test plan for D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
May 24 2024, 7:34 AM
marcin updated the test plan for D12162: [lib] Replace merging entries with an ops approach.
May 24 2024, 7:34 AM
marcin updated the test plan for D12162: [lib] Replace merging entries with an ops approach.
May 24 2024, 7:31 AM
marcin updated the test plan for D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
May 24 2024, 7:20 AM
marcin closed D12036: Enable backup restoration for SIWE users via testing buttons.
May 24 2024, 7:16 AM
marcin closed D12035: Modify Rust restore code to avoid fetching latest backup id twice.
May 24 2024, 7:16 AM
marcin committed rCOMM4e0a2f9ed8ab: Enable backup restoration for SIWE users via testing buttons (authored by marcin).
Enable backup restoration for SIWE users via testing buttons
May 24 2024, 7:16 AM
marcin committed rCOMM386ac68975e4: Modify Rust restore code to avoid fetching latest backup id twice (authored by marcin).
Modify Rust restore code to avoid fetching latest backup id twice
May 24 2024, 7:16 AM
marcin closed D12033: Introduce new header to siwe endpoint.
May 24 2024, 7:16 AM
marcin closed D12034: Change SIWE panel props to enable passing complete SIWE message.
May 24 2024, 7:16 AM
marcin committed rCOMMe393f320797b: Introduce new header to siwe endpoint (authored by marcin).
Introduce new header to siwe endpoint
May 24 2024, 7:16 AM
marcin committed rCOMM41beef91d650: Change SIWE panel props to enable passing complete SIWE message (authored by marcin).
Change SIWE panel props to enable passing complete SIWE message
May 24 2024, 7:16 AM
marcin closed D12032: Extract shared logci for SIWE panel state handling.
May 24 2024, 7:16 AM
marcin committed rCOMM094480a836c0: Extract shared logci for SIWE panel state handling (authored by marcin).
Extract shared logci for SIWE panel state handling
May 24 2024, 7:16 AM
marcin updated the test plan for D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
May 24 2024, 7:07 AM
marcin updated the diff for D12036: Enable backup restoration for SIWE users via testing buttons.

rebase before landing

May 24 2024, 6:47 AM
marcin updated the diff for D12035: Modify Rust restore code to avoid fetching latest backup id twice.

Rebase before landing

May 24 2024, 6:46 AM
marcin updated the diff for D12034: Change SIWE panel props to enable passing complete SIWE message.

Rebase before landing

May 24 2024, 6:44 AM
marcin updated the diff for D12033: Introduce new header to siwe endpoint.

Rebase before landing

May 24 2024, 6:43 AM
marcin updated the diff for D12032: Extract shared logci for SIWE panel state handling.

Rebase before landing

May 24 2024, 6:42 AM
marcin added inline comments to D12033: Introduce new header to siwe endpoint.
May 24 2024, 6:33 AM
marcin updated the diff for D12036: Enable backup restoration for SIWE users via testing buttons.

Rebase before landing

May 24 2024, 5:55 AM
marcin updated the diff for D12035: Modify Rust restore code to avoid fetching latest backup id twice.

Rebase before landing

May 24 2024, 5:54 AM
marcin updated the diff for D12034: Change SIWE panel props to enable passing complete SIWE message.

Rebase before landing

May 24 2024, 5:53 AM
marcin updated the diff for D12033: Introduce new header to siwe endpoint.

Rebase before landing

May 24 2024, 5:50 AM
marcin updated the diff for D12032: Extract shared logci for SIWE panel state handling.

Rebase before landing

May 24 2024, 5:47 AM
marcin added inline comments to D12033: Introduce new header to siwe endpoint.
May 24 2024, 5:41 AM
marcin accepted D12129: [web][native] implement encrypting and persisting OutboundP2PMessage's content in the same SQLite transaction as persisting `olm` session.
May 24 2024, 5:24 AM

May 23 2024

marcin accepted D12074: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`.
May 23 2024, 8:42 AM
marcin accepted D12071: [SQLite] add query to mark outbound P2P message as sent.
May 23 2024, 8:42 AM
marcin accepted D12070: [SQLite] add query to set ciphertext for outbound P2P message.
May 23 2024, 8:40 AM
marcin added a comment to D12050: [lib] Create a compaction after schema-changing migration.

This code (createAsyncMigrate) will be executed on app start (no matter if logged in/out). How about creating compaction after e.g. primary restore?

May 23 2024, 5:46 AM
marcin accepted D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
May 23 2024, 5:32 AM
marcin accepted D12162: [lib] Replace merging entries with an ops approach.
May 23 2024, 5:28 AM
marcin accepted D12164: [lib] Migrate remaining actions.
May 23 2024, 5:27 AM
marcin added inline comments to D12162: [lib] Replace merging entries with an ops approach.
May 23 2024, 5:16 AM
marcin accepted D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
May 23 2024, 4:47 AM
marcin added inline comments to D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
May 23 2024, 4:47 AM
marcin added inline comments to D12162: [lib] Replace merging entries with an ops approach.
May 23 2024, 4:32 AM
marcin added inline comments to D12162: [lib] Replace merging entries with an ops approach.
May 23 2024, 3:54 AM

May 22 2024

marcin updated the test plan for D12138: Implement SQLite API to handle entry store.
May 22 2024, 8:44 AM
marcin updated the test plan for D12142: Implement JSI for EntryStore.
May 22 2024, 8:43 AM
marcin updated the diff for D12148: Connect pipes between C++ and JS for entry store.

Change & -> $

May 22 2024, 8:41 AM
marcin updated the diff for D12142: Implement JSI for EntryStore.

Add newlines

May 22 2024, 8:40 AM
marcin added inline comments to D12162: [lib] Replace merging entries with an ops approach.
May 22 2024, 8:25 AM