Page MenuHomePhabricator
Feed Advanced Search

Jun 30 2024

ginsu added inline comments to D12568: [web] add Tag Farcaster channel option to CommunityActionsMenu.
Jun 30 2024, 8:12 PM
ginsu updated the diff for D12568: [web] add Tag Farcaster channel option to CommunityActionsMenu.

address comments

Jun 30 2024, 8:09 PM
ginsu updated the diff for D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal.

address comments

Jun 30 2024, 7:16 PM
ginsu updated the diff for D12566: [web] introduce CreateFarcasterChannelTagModal.

forgot to save

Jun 30 2024, 6:48 PM
ginsu updated the diff for D12566: [web] introduce CreateFarcasterChannelTagModal.

address comments

Jun 30 2024, 6:45 PM

Jun 28 2024

ginsu updated the summary of D12566: [web] introduce CreateFarcasterChannelTagModal.
Jun 28 2024, 12:26 PM
ginsu added inline comments to D12534: [lib/native/web] introduce RemoveTagButton.
Jun 28 2024, 12:25 PM
ginsu attached a referenced file: F2135695: Screenshot 2024-06-28 at 3.22.51 PM.png.
Jun 28 2024, 12:24 PM
ginsu attached a referenced file: F2135697: Screenshot 2024-06-28 at 3.23.11 PM.png.
Jun 28 2024, 12:24 PM
ginsu retitled D12534: [lib/native/web] introduce RemoveTagButton from [web] introduce RemoveTagButton to [lib/native/web] introduce RemoveTagButton.
Jun 28 2024, 12:24 PM
ginsu updated the diff for D12534: [lib/native/web] introduce RemoveTagButton.

address comments

Jun 28 2024, 12:22 PM
ginsu closed D12561: [web] Dropdown component improvements.
Jun 28 2024, 12:00 PM
ginsu committed rCOMMf2154b3a376d: [web] Dropdown component improvements (authored by ginsu).
[web] Dropdown component improvements
Jun 28 2024, 12:00 PM
ginsu added a comment to D12561: [web] Dropdown component improvements.

Removing this diff from the stack so that I can land it now

Jun 28 2024, 11:56 AM
ginsu updated the summary of D12561: [web] Dropdown component improvements.
Jun 28 2024, 11:56 AM
ginsu updated the diff for D12561: [web] Dropdown component improvements.

address comments

Jun 28 2024, 11:55 AM
ginsu closed D12565: [lib/native] lift tagFarcasterChannelErrorMessages into lib.
Jun 28 2024, 11:50 AM
ginsu committed rCOMM44723816bd0f: [lib/native] lift tagFarcasterChannelErrorMessages into lib (authored by ginsu).
[lib/native] lift tagFarcasterChannelErrorMessages into lib
Jun 28 2024, 11:50 AM
ginsu closed D12530: [web] introduce TagFarcasterChannelModal.
Jun 28 2024, 11:50 AM
ginsu committed rCOMM084003ee186f: [web] introduce TagFarcasterChannelModal (authored by ginsu).
[web] introduce TagFarcasterChannelModal
Jun 28 2024, 11:50 AM
ginsu updated the summary of D12565: [lib/native] lift tagFarcasterChannelErrorMessages into lib.
Jun 28 2024, 11:47 AM
ginsu updated the diff for D12565: [lib/native] lift tagFarcasterChannelErrorMessages into lib.

rebase before landing now because I need this to address feedback in subsquent diffs

Jun 28 2024, 11:47 AM
ginsu updated the diff for D12530: [web] introduce TagFarcasterChannelModal.

address comments

Jun 28 2024, 10:52 AM

Jun 27 2024

ginsu requested review of D12602: [web] fix colors in calendar history modal.
Jun 27 2024, 7:05 PM
ginsu requested review of D12600: [native] introduce loading logic to RelationshipPrompt.
Jun 27 2024, 2:38 PM
ginsu added inline comments to D12534: [lib/native/web] introduce RemoveTagButton.
Jun 27 2024, 1:58 PM
ginsu added inline comments to D12566: [web] introduce CreateFarcasterChannelTagModal.
Jun 27 2024, 1:57 PM
ginsu attached a referenced file: F2129521: Screenshot 2024-06-27 at 4.31.11 PM.png.
Jun 27 2024, 1:44 PM
ginsu attached a referenced file: F2129520: Screenshot 2024-06-27 at 4.32.40 PM.png.
Jun 27 2024, 1:44 PM
ginsu attached a referenced file: F2129525: Screenshot 2024-06-27 at 4.34.46 PM.png.
Jun 27 2024, 1:44 PM
ginsu attached a referenced file: F2129526: Screenshot 2024-06-27 at 4.35.24 PM.png.
Jun 27 2024, 1:44 PM
ginsu attached a referenced file: F2129553: Screenshot 2024-06-27 at 4.41.25 PM.png.
Jun 27 2024, 1:44 PM
ginsu attached a referenced file: F2129554: Screenshot 2024-06-27 at 4.41.29 PM.png.
Jun 27 2024, 1:44 PM
ginsu added inline comments to D12596: [native] introduce loading logic to relationship prompt button.
Jun 27 2024, 1:44 PM
ginsu retitled D12596: [native] introduce loading logic to relationship prompt button from [native] intorduce loading logic to relationship prompt button to [native] introduce loading logic to relationship prompt button.
Jun 27 2024, 1:19 PM
ginsu requested review of D12596: [native] introduce loading logic to relationship prompt button.
Jun 27 2024, 1:18 PM
ginsu requested review of D12595: [web] intorduce loading logic to relationship prompt button.
Jun 27 2024, 1:07 PM
ginsu requested review of D12593: [lib] introduce loading logic to useRelationshipPrompt.
Jun 27 2024, 12:35 PM
ginsu added inline comments to D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal.
Jun 27 2024, 11:09 AM
ginsu requested review of D12592: [landing] add download icon to mobile nav.
Jun 27 2024, 10:43 AM
ginsu requested review of D12591: [landing] add link to download page in the header.
Jun 27 2024, 10:36 AM
ginsu requested review of D12583: [landing] introduce download page.
Jun 27 2024, 1:21 AM
ginsu requested review of D12582: [web] fix leave channel modal for long thread names.
Jun 27 2024, 1:01 AM
ginsu requested review of D12581: [native] fix empty media gallery in thread settings.
Jun 27 2024, 12:45 AM

Jun 26 2024

ginsu closed D12459: [keysever/lib/native] extend joinThread to handle auto join functionality.
Jun 26 2024, 1:56 PM
ginsu committed rCOMM3e408b3e428d: [keysever/lib/native] extend joinThread to handle auto join functionality (authored by ginsu).
[keysever/lib/native] extend joinThread to handle auto join functionality
Jun 26 2024, 1:56 PM
ginsu updated the diff for D12459: [keysever/lib/native] extend joinThread to handle auto join functionality.

address comments + rebase before landing

Jun 26 2024, 1:04 PM

Jun 25 2024

ginsu updated the summary of D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Jun 25 2024, 10:56 AM

Jun 24 2024

ginsu requested review of D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Jun 24 2024, 11:58 PM
ginsu requested review of D12568: [web] add Tag Farcaster channel option to CommunityActionsMenu.
Jun 24 2024, 11:39 PM
ginsu requested review of D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal.
Jun 24 2024, 11:27 PM
ginsu added a reviewer for D12566: [web] introduce CreateFarcasterChannelTagModal: ashoat.

This diff contains copy that needs to be reviewed

Jun 24 2024, 10:57 PM
ginsu attached a referenced file: F2101684: Screen Recording 2024-06-25 at 1.54.07 AM.mov.
Jun 24 2024, 10:56 PM
ginsu updated the summary of D12566: [web] introduce CreateFarcasterChannelTagModal.
Jun 24 2024, 10:56 PM
ginsu requested review of D12566: [web] introduce CreateFarcasterChannelTagModal.
Jun 24 2024, 10:52 PM
ginsu requested review of D12565: [lib/native] lift tagFarcasterChannelErrorMessages into lib.
Jun 24 2024, 10:45 PM
ginsu updated the summary of D12561: [web] Dropdown component improvements.
Jun 24 2024, 10:29 PM
ginsu updated the diff for D12561: [web] Dropdown component improvements.

update

Jun 24 2024, 10:28 PM
ginsu attached a referenced file: F2101347: Screenshot 2024-06-25 at 1.14.04 AM.png.
Jun 24 2024, 10:18 PM
ginsu attached a referenced file: F2101342: Screen Recording 2024-06-25 at 1.11.14 AM.mov.
Jun 24 2024, 10:18 PM
ginsu attached a referenced file: F2101343: Screenshot 2024-06-25 at 1.12.59 AM.png.
Jun 24 2024, 10:18 PM
ginsu updated the summary of D12561: [web] Dropdown component improvements.
Jun 24 2024, 10:18 PM
ginsu requested review of D12561: [web] Dropdown component improvements.
Jun 24 2024, 9:45 PM
ginsu closed D12542: [native] fix error handling in TagFarcasterChannelByName.
Jun 24 2024, 10:26 AM
ginsu committed rCOMM0ce162712b13: [native] fix error handling in TagFarcasterChannelByName (authored by ginsu).
[native] fix error handling in TagFarcasterChannelByName
Jun 24 2024, 10:26 AM
ginsu closed D12541: [native] handle loading state in TagFarcasterChannelByName.
Jun 24 2024, 10:25 AM
ginsu committed rCOMMeb88aad04d8d: [native] handle loading state in TagFarcasterChannelByName (authored by ginsu).
[native] handle loading state in TagFarcasterChannelByName
Jun 24 2024, 10:25 AM
ginsu closed D12540: [native] fix indexing in tag channel button action sheet.
Jun 24 2024, 10:25 AM
ginsu committed rCOMM614524f8ce9f: [native] fix indexing in tag channel button action sheet (authored by ginsu).
[native] fix indexing in tag channel button action sheet
Jun 24 2024, 10:25 AM
ginsu updated the diff for D12542: [native] fix error handling in TagFarcasterChannelByName.

rebase before landing

Jun 24 2024, 10:24 AM
ginsu updated the diff for D12541: [native] handle loading state in TagFarcasterChannelByName.

rebase before landing

Jun 24 2024, 10:22 AM
ginsu updated the diff for D12540: [native] fix indexing in tag channel button action sheet.

rebase before landing

Jun 24 2024, 10:21 AM
ginsu accepted D12549: [web] fix uncaught exception when user cancels SIWE.
Jun 24 2024, 10:17 AM
ginsu accepted D12546: [web] inform password users that they need to log in from native to claim username.

Looks good, but is there a follow up task/diff to address the janky ui?

Jun 24 2024, 10:16 AM

Jun 21 2024

ginsu added a comment to D12534: [lib/native/web] introduce RemoveTagButton.

I can see in invite links modal, that when an error appears we change the size of the modal to add the additional needed space

Jun 21 2024, 1:42 PM
ginsu added inline comments to D12542: [native] fix error handling in TagFarcasterChannelByName.
Jun 21 2024, 1:38 PM
ginsu requested review of D12542: [native] fix error handling in TagFarcasterChannelByName.
Jun 21 2024, 1:36 PM
ginsu updated the summary of D12541: [native] handle loading state in TagFarcasterChannelByName.
Jun 21 2024, 12:29 PM
ginsu updated the diff for D12541: [native] handle loading state in TagFarcasterChannelByName.

update

Jun 21 2024, 12:25 PM
ginsu requested review of D12541: [native] handle loading state in TagFarcasterChannelByName.
Jun 21 2024, 11:53 AM
ginsu requested review of D12540: [native] fix indexing in tag channel button action sheet.
Jun 21 2024, 11:44 AM
ginsu updated the summary of D12534: [lib/native/web] introduce RemoveTagButton.
Jun 21 2024, 11:26 AM
ginsu closed D12535: [lib/native] introduce useCreateFarcasterChannelTag.
Jun 21 2024, 11:23 AM
ginsu committed rCOMMed338cd1770c: [lib/native] introduce useCreateFarcasterChannelTag (authored by ginsu).
[lib/native] introduce useCreateFarcasterChannelTag
Jun 21 2024, 11:23 AM
ginsu updated the diff for D12535: [lib/native] introduce useCreateFarcasterChannelTag.

rebase before landing

Jun 21 2024, 11:22 AM
ginsu added a comment to D12535: [lib/native] introduce useCreateFarcasterChannelTag.

Removed from stack so I can land as is. Confirmed that this is safe + does not cause any merge conflicts when rebasing

Jun 21 2024, 11:21 AM
ginsu updated the summary of D12535: [lib/native] introduce useCreateFarcasterChannelTag.
Jun 21 2024, 11:21 AM
ginsu closed D12533: [native] fix button container height in RemoveTagButton.
Jun 21 2024, 11:20 AM
ginsu committed rCOMMf772adbc5483: [native] fix button container height in RemoveTagButton (authored by ginsu).
[native] fix button container height in RemoveTagButton
Jun 21 2024, 11:20 AM
ginsu closed D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
Jun 21 2024, 11:20 AM
ginsu committed rCOMMd58a4b0c065e: [lib/native] introduce useRemoveFarcasterChannelTag (authored by ginsu).
[lib/native] introduce useRemoveFarcasterChannelTag
Jun 21 2024, 11:19 AM
ginsu updated the diff for D12533: [native] fix button container height in RemoveTagButton.

rebase before landing

Jun 21 2024, 11:19 AM
ginsu updated the diff for D12532: [lib/native] introduce useRemoveFarcasterChannelTag.

rebase before landing

Jun 21 2024, 11:18 AM
ginsu added a comment to D12532: [lib/native] introduce useRemoveFarcasterChannelTag.

Removed from stack so I can land as is. Confirmed that this is safe + does not cause any merge conflicts when rebasing

Jun 21 2024, 11:17 AM
ginsu updated the summary of D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
Jun 21 2024, 11:17 AM
ginsu added inline comments to D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
Jun 21 2024, 11:17 AM
ginsu closed D12500: [native/web] fix manage farcaster channel tag permission migration.
Jun 21 2024, 9:59 AM
ginsu closed D12503: [keyserver/lib/native] flip the switch for farcaster channel tagging.
Jun 21 2024, 9:59 AM
ginsu committed rCOMMb8a0c977b46b: [keyserver/lib/native] flip the switch for farcaster channel tagging (authored by ginsu).
[keyserver/lib/native] flip the switch for farcaster channel tagging
Jun 21 2024, 9:59 AM
ginsu committed rCOMM8fc5e88db124: [native/web] fix manage farcaster channel tag permission migration (authored by ginsu).
[native/web] fix manage farcaster channel tag permission migration
Jun 21 2024, 9:59 AM