Rebase
Feed All Stories
Dec 10 2024
Dec 10 2024
ashoat updated the diff for D13984: [lib] Fix incorrect timestamps for sidebars.
ashoat updated the diff for D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
Rebase
ashoat updated the diff for D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
Rebase
ashoat updated the diff for D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.
Rebase
ashoat updated the summary of D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.
ashoat updated the diff for D13912: [lib] Extract getLastUpdatedTime to a separate file.
Rebase
ashoat committed rCOMMd0de5a7dc2b1: Revert "[lib] Introduce MessageSpec.getLastUpdatedTime" (authored by ashoat).
Revert "[lib] Introduce MessageSpec.getLastUpdatedTime"
ashoat committed rCOMMed098ff1dcae: Revert "[lib] Extract getLastUpdatedTime to a separate file" (authored by ashoat).
Revert "[lib] Extract getLastUpdatedTime to a separate file"
Revert "[lib] Extract getSidebarItems"
ashoat added a reverting change for rCOMM481690308381: [lib] Extract getSidebarItems: rCOMMd5b919ba29cf: Revert "[lib] Extract getSidebarItems".
ashoat added a reverting change for D13914: [lib] Extract getSidebarItems: rCOMMd5b919ba29cf: Revert "[lib] Extract getSidebarItems".
ashoat committed rCOMM00bb994d4b7b: Revert "[lib][native][web] Update useSidebarInfos to include… (authored by ashoat).
Revert "[lib][native][web] Update useSidebarInfos to include…
ashoat committed rCOMM161c29088a75: Revert "[lib][web] Await lastUpdatedTime and update ChatThreadItems if… (authored by ashoat).
Revert "[lib][web] Await lastUpdatedTime and update ChatThreadItems if…
ashoat added a reverting change for D13984: [lib] Fix incorrect timestamps for sidebars: rCOMMf7172048c7fe: Revert "[lib] Fix incorrect timestamps for sidebars".
ashoat committed rCOMMf7172048c7fe: Revert "[lib] Fix incorrect timestamps for sidebars" (authored by ashoat).
Revert "[lib] Fix incorrect timestamps for sidebars"
ashoat added a comment to D14084: [native] Create a restore backup screen.
Looks okay. Would be nice to be able to show progress, but I recognize we'll probably need to wait on backup size calculation for that.
ashoat added a comment to D13907: [native] Introduce a restore screen.
Either one looks good to me!
tomek updated the diff for D14090: [native] Navigate to a SIWE backup screen.
Rebase
tomek added a comment to D14084: [native] Create a restore backup screen.
We're using a library https://www.npmjs.com/package/react-native-progress for displaying the multimedia upload progress, and we can consider using it here. I updated the diff with one of the options, but the NPM page presents some alternatives.
tomek updated the summary of D14084: [native] Create a restore backup screen.
tomek updated the diff for D14084: [native] Create a restore backup screen.
Update backup details and a loading indicator
tomek added a comment to D13907: [native] Introduce a restore screen.
Updated the color to match the registration flow
We can also consider making it a little less white
tomek updated the diff for D13907: [native] Introduce a restore screen.
Update the icon color
tomek updated the diff for D14038: [native] Navigate from the QR screen to the restore screen.
Rebase
tomek updated the diff for D14064: [native] Make QR screen style consistent with the registration flow.
Use window dimensions hook
Dec 9 2024
Dec 9 2024
will committed rCOMMd2804563a8f1: [lib] include embeds in neynar client's postCast method (authored by will).
[lib] include embeds in neynar client's postCast method
will committed rCOMM96fd3eb8966c: [keyserver] replace farcaster bot reply text with frame (authored by will).
[keyserver] replace farcaster bot reply text with frame
will committed rCOMM56ad401d2bc1: [keyserver] setup reverse proxy from keyserver router to frog hono server (authored by will).
[keyserver] setup reverse proxy from keyserver router to frog hono server
will committed rCOMM406616992f71: [keyserver] use default channel cover image stored on in keyserver/images in… (authored by will).
[keyserver] use default channel cover image stored on in keyserver/images in…
will committed rCOMM9135d719942e: [keyserver/lib] Change frame image from hello world to channel image (authored by will).
[keyserver/lib] Change frame image from hello world to channel image
will committed rCOMMc74348d9a0c0: [keyserver] Add Thread Invitation box to the frame (authored by will).
[keyserver] Add Thread Invitation box to the frame
will committed rCOMM05d0d8f070f9: [keyserver] implement invite link button to frog hono route (authored by will).
[keyserver] implement invite link button to frog hono route
[keyserver] frog hello world example
will committed rCOMM556454795e08: [keyserver] Have @babel/preset-react use automatic runtime (authored by will).
[keyserver] Have @babel/preset-react use automatic runtime
will committed rCOMMa28293029a01: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies (authored by will).
[keyserver] add frog, hono, @hono/node-server as keyserver dependencies
will updated the diff for D14093: [keyserver] replace farcaster bot reply text with frame.
rebase before landing
will updated the diff for D13985: [keyserver/lib] Change frame image from hello world to channel image.
fix frog callback return type to be Promise<FrogResponse> | FrogResponse
will added inline comments to D13985: [keyserver/lib] Change frame image from hello world to channel image.
will updated the diff for D14093: [keyserver] replace farcaster bot reply text with frame.
rebase
will updated the diff for D14092: [lib] include embeds in neynar client's postCast method.
fix setting parent
will updated the diff for D14093: [keyserver] replace farcaster bot reply text with frame.
rebase
will updated the diff for D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.
rebase
will updated the diff for D14093: [keyserver] replace farcaster bot reply text with frame.
rebase
will updated the diff for D14092: [lib] include embeds in neynar client's postCast method.
rebase
will added a comment to D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.
ashoat added a comment to D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.
I haven't actually seen this utilized when we render the frame on the validator or warpcast, so I don't believe the title matters too much
will added inline comments to D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.
will updated the diff for D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.
rebase
will updated the diff for D13947: [keyserver] frog hello world example.
change frame title to "Comm Frame" instead of "Comm Frame App"
will added inline comments to D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.
will added inline comments to D14093: [keyserver] replace farcaster bot reply text with frame.
will attached a referenced file: F3438064: image.png.
will attached a referenced file: F3438038: image.png.
will attached a referenced file: F3438029: Screenshot 2024-12-09 at 2.59.33 PM.png.
will added inline comments to D14093: [keyserver] replace farcaster bot reply text with frame.
will added inline comments to D14093: [keyserver] replace farcaster bot reply text with frame.
ashoat added inline comments to D14093: [keyserver] replace farcaster bot reply text with frame.
will added inline comments to D14093: [keyserver] replace farcaster bot reply text with frame.
ashoat added a comment to D13907: [native] Introduce a restore screen.
But I don't know how to display this flow in this mode. I modified the colorsSelector so that I can see how it looks like.
tomek added a comment to D13907: [native] Introduce a restore screen.
The dark mode
tomek updated the diff for D13907: [native] Introduce a restore screen.
Use the new icon
Looks great! Thanks for iterating on this :)
ashoat added inline comments to D14092: [lib] include embeds in neynar client's postCast method.
ashoat added inline comments to D13985: [keyserver/lib] Change frame image from hello world to channel image.
ashoat added a comment to D13907: [native] Introduce a restore screen.
Added a placeholder icon. Will update the diff after https://linear.app/comm/issue/OPS-305/mockup-icon-for-restore-account-screen finalizes the design.
tomek added a comment to D14084: [native] Create a restore backup screen.
- The styling of the three fields looks strange. It's not clear to me if the values there should be updating, and I feel like the spacing should be improved. Do we want bullet points here?
- What are "backup details"?
The backup details is a header for the two fields that are displayed. Based on the discussion from https://linear.app/comm/issue/ENG-9680/create-a-restoration-screen it seems like getting the size might take some time, so if we decide to support only the timestamp for now, we shouldn't display the backup details header and the bullet points.
tomek updated the diff for D14038: [native] Navigate from the QR screen to the restore screen.
Rebase
ashoat added a comment to D14079: [identity] fix `lastPrimarySignature` attribute.
Thanks for explaning :)
tomek added a comment to D14064: [native] Make QR screen style consistent with the registration flow.
The QR code size was made to depend on the screen width, which is always less than the height. This allows the user to always be able to see the full QR even for the most uncommon aspect rations (sometimes the user would need to scroll this screen). Tested on two devices, one of which has 16:9 aspect.
tomek updated the summary of D14064: [native] Make QR screen style consistent with the registration flow.
tomek updated the diff for D14064: [native] Make QR screen style consistent with the registration flow.
Update the design