address comments

address comments

update useEffect

address comments

fix comm logo svg

Realized that I misnamed the edit-filled icon in the description/test plan but @kuba you should be good now!

Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?

address comments and remove logoImageURL field (since we are using svgs now)

address comments

create z-index css variables

address ashoats comments

Maybe I'm missing something, but could we just have the MobileNav set to display: none at higher breakpoint?

address comments

update breakpoint width

address comments (the comments regarding the typography were adddressed in the design channel where we decided to continue using the current implmentation)

remove unnecessary classes

address comments

rebase

address comments

Would be good to test this sort of thing in a couple of browsers (I usually do Safari/Chrome/FireFox). It's probably totally fine, but just to make sure there's no inconsistency

remove memoization around mobile nav component

@ashoat will abandon this diff and fix the memoization concern in D7781, but let's talk more about this in our next 1on1

Would be good to test this sort of thing in a couple of browsers (I usually do Safari/Chrome/FireFox). It's probably totally fine, but just to make sure there's no inconsistency

No, that's not it. The issue is that the children prop you're passing to <div className={css.innerContainer}> will get recreated anyways every time as <>{header}{activePage}{footer}{modals}</>. You're not successfully memoizing any prop passed to any component, so there is no benefit here. You would have to memoize the entirety of <>{header}{activePage}{footer}{modals}</> for it to have any effect.