rebase before landing
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 23 2023
Jun 23 2023
ginsu updated the diff for D8284: [native] introudce selectMultipleEmojis and alreadySelectedEmojis to EmojiKeyboard component.
rebase before landing
rebase before landing
ginsu published D8310: [native] change color theme of the emoji keyboard based on the app theme for review.
ginsu updated the diff for D8284: [native] introudce selectMultipleEmojis and alreadySelectedEmojis to EmojiKeyboard component.
rebase/address merge conflict
address feedback
Jun 22 2023
Jun 22 2023
ginsu added inline comments to D8288: [lib/native] introduce getViewerAlreadySelectedMessageReactions.
This makes sense, but one question inline
Jun 21 2023
Jun 21 2023
ginsu added inline comments to D8288: [lib/native] introduce getViewerAlreadySelectedMessageReactions.
ginsu updated the summary of D8288: [lib/native] introduce getViewerAlreadySelectedMessageReactions.
ginsu added inline comments to D8284: [native] introudce selectMultipleEmojis and alreadySelectedEmojis to EmojiKeyboard component.
Jun 16 2023
Jun 16 2023
ginsu committed rCOMMaa6411766696: [native] add recently used category to emoji picker (authored by ginsu).
[native] add recently used category to emoji picker
[native] introduce EmojiSelection type
rebase before landing
ginsu retitled D8227: [native] introduce EmojiSelection type from [native] introduce EmojiType to [native] introduce EmojiSelection type.
address comments
Jun 15 2023
Jun 15 2023
move categoryOrder to be above the types
[landing] remove max from team page
move categories array into the top level scope
add search bar to emoji keyboard
Jun 14 2023
Jun 14 2023
ginsu added inline comments to D8213: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`.
Code looks good, but pls see comment inline
[native] introduce emoji keyboard component
[native] remove avatar feature flag logic
rebase before landing
@ginsu, I think it could be good if we could "abstract away" these platform-specific quirks
Jun 13 2023
Jun 13 2023
Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience
ginsu added inline comments to D8156: [native] Create a new screen that will show the role change information.
address comments
ginsu requested changes to D8156: [native] Create a new screen that will show the role change information.
Requesting changes for Android action/bottom sheet implementation. Here is the doc for android action/bottom sheet best practices
Jun 12 2023
Jun 12 2023
[web] remove avatar feature flag logic
rebase before landing
forgot to remove unused class
Jun 9 2023
Jun 9 2023
ginsu requested review of D8175: [landing] fix the scroll to top behavior and animation on keyserver page.
looks good thanks for addressing my feedback!
update --modal-overlay color value to match a value on web (this was the closet color to the original #010101bf)