Page MenuHomePhabricator
Feed Advanced Search

Apr 4 2024

ginsu closed D11561: [native] calculate snap points for connect farcaster bottom sheet.
Apr 4 2024, 8:06 PM
ginsu closed D11560: [native] implement connect farcaster bottom sheet ui.
Apr 4 2024, 8:06 PM
ginsu committed rCOMM9a7c9bac9bb4: [native] implement connect farcaster bottom sheet ui (authored by ginsu).
[native] implement connect farcaster bottom sheet ui
Apr 4 2024, 8:06 PM
ginsu committed rCOMM120db72b9482: [native] calculate snap points for connect farcaster bottom sheet (authored by ginsu).
[native] calculate snap points for connect farcaster bottom sheet
Apr 4 2024, 8:06 PM
ginsu closed D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.
Apr 4 2024, 8:06 PM
ginsu committed rCOMMc813111a7acd: [native] introduce barebones connect farcaster bottom sheet to root navigator (authored by ginsu).
[native] introduce barebones connect farcaster bottom sheet to root navigator
Apr 4 2024, 8:06 PM
ginsu updated the diff for D11561: [native] calculate snap points for connect farcaster bottom sheet.

address comments + rebase before landing

Apr 4 2024, 7:27 PM
ginsu updated the diff for D11560: [native] implement connect farcaster bottom sheet ui.

address comments + rebase before landing

Apr 4 2024, 7:24 PM
ginsu updated the diff for D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.

rebase before landing

Apr 4 2024, 7:22 PM
ginsu accepted D11558: [keyserver][lib][web] Update SIWE package.
Apr 4 2024, 6:41 PM
ginsu accepted D11555: [web] Lift WagmiProvider higher up the component tree.
Apr 4 2024, 2:03 PM
ginsu accepted D11554: [lib][landing][web] Update Wagmi to 2.5.18.
Apr 4 2024, 2:03 PM
ginsu published D11561: [native] calculate snap points for connect farcaster bottom sheet for review.

will make sure ci passes before landing

Apr 4 2024, 12:22 PM
ginsu requested review of D11560: [native] implement connect farcaster bottom sheet ui.

will make sure ci passes before landing

Apr 4 2024, 12:22 PM
ginsu requested review of D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.

will make sure ci passes before landing

Apr 4 2024, 12:22 PM
ginsu accepted D11557: [landing][lib][web] Add buffer polyfill for webworkers.
Apr 4 2024, 11:59 AM

Apr 3 2024

ginsu accepted D11529: [native][web] read aux user store on app startup.

seems reasonable

Apr 3 2024, 10:40 PM
ginsu resigned from D11528: [lib] Introduce aux user store reducer and action types.

Overall looks good, just a few comments inline. Going to resign as reviewer so other reviewers can also take a look too

Apr 3 2024, 10:37 PM
ginsu closed D11513: [native] unauth from farcaster.
Apr 3 2024, 9:49 AM
ginsu committed rCOMM296be49bd4b4: [native] unauth from farcaster (authored by ginsu).
[native] unauth from farcaster
Apr 3 2024, 9:49 AM
ginsu closed D11512: [native] build out UI for farcaster account settings screen.
Apr 3 2024, 9:49 AM
ginsu closed D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Apr 3 2024, 9:49 AM
ginsu committed rCOMMb5530714c2a9: [native] update FarcasterPrompt based on if the fid is set or not (authored by ginsu).
[native] update FarcasterPrompt based on if the fid is set or not
Apr 3 2024, 9:49 AM
ginsu committed rCOMM00a8b91431f3: [native] build out UI for farcaster account settings screen (authored by ginsu).
[native] build out UI for farcaster account settings screen
Apr 3 2024, 9:49 AM
ginsu closed D11483: [native] introduce farcaster account settings profile row.
Apr 3 2024, 9:49 AM
ginsu committed rCOMMaf0bb9f6dfcf: [native] introduce farcaster account settings profile row (authored by ginsu).
[native] introduce farcaster account settings profile row
Apr 3 2024, 9:49 AM
ginsu updated the diff for D11513: [native] unauth from farcaster.

rebase before landing + confirm keyserver ci build works

Apr 3 2024, 9:26 AM
ginsu updated the diff for D11512: [native] build out UI for farcaster account settings screen.

rebase before landing

Apr 3 2024, 9:25 AM
ginsu updated the diff for D11484: [native] update FarcasterPrompt based on if the fid is set or not.

rebase before landing + make sure keyserver build ci works

Apr 3 2024, 9:25 AM
ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

rebase before landing

Apr 3 2024, 9:24 AM

Apr 2 2024

ginsu updated the diff for D11513: [native] unauth from farcaster.

rebase before landing

Apr 2 2024, 10:27 PM
ginsu updated the diff for D11484: [native] update FarcasterPrompt based on if the fid is set or not.

address comments

Apr 2 2024, 10:25 PM
ginsu accepted D11527: [native] Patch react-native to avoid FlatList this.props error.
Apr 2 2024, 1:38 PM

Apr 1 2024

ginsu requested review of D11512: [native] build out UI for farcaster account settings screen.
Apr 1 2024, 12:52 PM
ginsu requested review of D11513: [native] unauth from farcaster.
Apr 1 2024, 12:47 PM
ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.
Apr 1 2024, 12:28 PM
ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

fix eslint ci issue

Apr 1 2024, 12:27 PM
ginsu requested review of D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Making @ashoat blocking reviewer since this diff does have copy changes

Apr 1 2024, 12:10 PM
ginsu attached a referenced file: F1452474: IMG_6793.PNG.
Apr 1 2024, 12:09 PM
ginsu attached a referenced file: F1452475: IMG_6792.PNG.
Apr 1 2024, 12:09 PM
ginsu attached a referenced file: F1452477: RPReplay_Final1711998516.MP4.
Apr 1 2024, 12:09 PM
ginsu updated the summary of D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Apr 1 2024, 12:09 PM
ginsu added a comment to D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Will this affect the experience when FarcasterPrompt is used from the registration flow?

Apr 1 2024, 12:01 PM
ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.
Apr 1 2024, 11:58 AM
ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

update farcaster account gate logic

Apr 1 2024, 11:57 AM
ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.
Apr 1 2024, 11:56 AM
ginsu accepted D11494: [lib][native] Update useRegistrationServerCall to set FID in FIDContext.
Apr 1 2024, 11:38 AM
ginsu accepted D11492: [lib] Add Coinbase Wallet support.
Apr 1 2024, 9:28 AM
ginsu accepted D11491: [native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates.
Apr 1 2024, 9:26 AM
ginsu accepted D11490: [lib][web][landing] Don't include injectedWallet in mobile experience.
Apr 1 2024, 9:25 AM
ginsu accepted D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.
Apr 1 2024, 9:24 AM
ginsu accepted D11493: [buildkite] Update image used in Buildkite JS workflows to Node 20.
Apr 1 2024, 9:19 AM
ginsu accepted D11488: [native] Allow us to open a bunch of other wallets.
Apr 1 2024, 9:18 AM
ginsu accepted D11487: [lib] Allow getNamesForAddresses to be called without ReverseRecords smart contract.
Apr 1 2024, 9:17 AM
ginsu accepted D11486: [lib] Switch to Sepolia for ENSCache unit tests.
Apr 1 2024, 9:14 AM
ginsu accepted D11485: [lib][native][web][keyserver][landing] Update to Ethers.js 6.
Apr 1 2024, 9:13 AM

Mar 29 2024

ginsu planned changes to D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Mar 29 2024, 3:09 PM
ginsu requested review of D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Mar 29 2024, 2:52 PM
ginsu requested review of D11483: [native] introduce farcaster account settings profile row.
Mar 29 2024, 2:45 PM
ginsu closed D11463: [native] introduce already connected button to farcaster connect.
Mar 29 2024, 2:20 PM
ginsu committed rCOMMddfda1a8134d: [native] introduce already connected button to farcaster connect (authored by ginsu).
[native] introduce already connected button to farcaster connect
Mar 29 2024, 2:20 PM
ginsu closed D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.
Mar 29 2024, 2:20 PM
ginsu committed rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step (authored by ginsu).
[native] implement onSuccess callback for ConnectFarcaster registration step
Mar 29 2024, 2:20 PM
ginsu closed D11461: [native] add the connect farcaster step into the registration flow.
Mar 29 2024, 2:20 PM
ginsu committed rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow (authored by ginsu).
[native] add the connect farcaster step into the registration flow
Mar 29 2024, 2:20 PM
ginsu closed D11442: [native] introduce ConnectFarcaster registration screen.
Mar 29 2024, 2:20 PM
ginsu committed rCOMMc29ed7da457a: [native] introduce ConnectFarcaster registration screen (authored by ginsu).
[native] introduce ConnectFarcaster registration screen
Mar 29 2024, 2:20 PM
ginsu closed D11441: [native] introduce FarcasterPrompt.
Mar 29 2024, 2:20 PM
ginsu committed rCOMMe2063fce5e81: [native] introduce FarcasterPrompt (authored by ginsu).
[native] introduce FarcasterPrompt
Mar 29 2024, 2:20 PM
ginsu closed D11479: [keyserver] add file-type dep.
Mar 29 2024, 1:58 PM
ginsu committed rCOMM194afd3f0228: [keyserver] add file-type dep (authored by ginsu).
[keyserver] add file-type dep
Mar 29 2024, 1:58 PM
ginsu requested review of D11479: [keyserver] add file-type dep.
Mar 29 2024, 1:15 PM

Mar 28 2024

ginsu requested review of D11463: [native] introduce already connected button to farcaster connect.

will make sure the ci passes before landing

Mar 28 2024, 10:09 PM
ginsu requested review of D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.

will make sure ci passes before landing

Mar 28 2024, 9:47 PM
ginsu requested review of D11461: [native] add the connect farcaster step into the registration flow.
Mar 28 2024, 9:45 PM
ginsu accepted D11457: [lib] Fix `UpdateRelationshipMessageSpec.validator`.
Mar 28 2024, 8:43 PM
ginsu accepted D11455: [lib] Update `rawMessageInfoFromClientDB` to support `RawUpdateRelationshipMessageInfo`.
Mar 28 2024, 8:43 PM
ginsu accepted D11452: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated `UpdateRelationship` message type.
Mar 28 2024, 8:32 PM
ginsu accepted D11443: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`.
Mar 28 2024, 8:26 PM
ginsu accepted D11439: [lib] Update union types in `message-types` to include `UpdateRelationship` types.
Mar 28 2024, 8:25 PM
ginsu accepted D11438: [lib] Introduce bare minimum `messageTypes.UPDATE_RELATIONSHIP`.

lgtm

Mar 28 2024, 8:24 PM
ginsu accepted D11460: [lib] Hook everything together in FarcasterDataHandler.
Mar 28 2024, 8:21 PM
ginsu added inline comments to D11442: [native] introduce ConnectFarcaster registration screen.
Mar 28 2024, 12:45 PM
ginsu updated the diff for D11442: [native] introduce ConnectFarcaster registration screen.

update

Mar 28 2024, 12:44 PM
ginsu closed D11434: [native] introduce FarcasterLogo.
Mar 28 2024, 10:58 AM
ginsu closed D11432: [landing/lib/native] introduce FarcasterWebView.
Mar 28 2024, 10:58 AM
ginsu committed rCOMM3941d90cb605: [native] introduce FarcasterLogo (authored by ginsu).
[native] introduce FarcasterLogo
Mar 28 2024, 10:58 AM
ginsu committed rCOMMaabf91724a80: [landing/lib/native] introduce FarcasterWebView (authored by ginsu).
[landing/lib/native] introduce FarcasterWebView
Mar 28 2024, 10:58 AM
ginsu closed D11429: [landing] introduce /connect-farcaster route.
Mar 28 2024, 10:58 AM
ginsu closed D11428: [landing] introduce ConnectFarcaster.
Mar 28 2024, 10:58 AM
ginsu committed rCOMM1aceccccbaf3: [landing] introduce /connect-farcaster route (authored by ginsu).
[landing] introduce /connect-farcaster route
Mar 28 2024, 10:58 AM
ginsu committed rCOMMc48488d8c8cd: [landing] introduce ConnectFarcaster (authored by ginsu).
[landing] introduce ConnectFarcaster
Mar 28 2024, 10:58 AM
ginsu closed D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.
Mar 28 2024, 10:58 AM
ginsu committed rCOMM62b3601c95c9: [keyserver/landing] add @babel/plugin-transform-private-methods to list of… (authored by ginsu).
[keyserver/landing] add @babel/plugin-transform-private-methods to list of…
Mar 28 2024, 10:58 AM
ginsu requested review of D11442: [native] introduce ConnectFarcaster registration screen.
Mar 28 2024, 10:06 AM
ginsu requested review of D11441: [native] introduce FarcasterPrompt.
Mar 28 2024, 9:42 AM
ginsu updated the diff for D11434: [native] introduce FarcasterLogo.

address feedback

Mar 28 2024, 9:23 AM
ginsu updated the diff for D11432: [landing/lib/native] introduce FarcasterWebView.

address comments

Mar 28 2024, 9:21 AM
ginsu updated the diff for D11428: [landing] introduce ConnectFarcaster.

address feedback

Mar 28 2024, 9:05 AM
ginsu abandoned D11159: [DO NOT LAND][web] add @neynar/nodejs-sdk dep.

we ended up building our own neynar api client in house so we can abandon this

Mar 28 2024, 9:00 AM