Don't see any smells, would like bartek to take a look as well
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 31 2023
Jan 31 2023
• jon added a reviewer for D6284: [tunnelbroker-client] Adding `publish_message` client function: bartek.
• jon added inline comments to D6284: [tunnelbroker-client] Adding `publish_message` client function.
• jon added a reviewer for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method: bartek.
• jon requested changes to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
• jon added a reviewer for D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor: bartek.
• jon committed rCOMMa9c0e4be3baf: [Services] Use clap to provide configurable cli experience to blob service (authored by • jon).
[Services] Use clap to provide configurable cli experience to blob service
[Services] Add blob cli crates
Jan 30 2023
Jan 30 2023
• jon updated the diff for D6464: [Services] Use clap to provide configurable cli experience to blob service.
Address clippy feedback
• jon requested review of D6464: [Services] Use clap to provide configurable cli experience to blob service.
[Nix] Install watchman through homebrew
Jan 27 2023
Jan 27 2023
Rebase on master
So the "nested nix develop" might not get this installed, but presumably when the user exits the top-level nix develop and reenters, THEN brew install watchman will get run
[Nix] Fix undeclared failure
Jan 26 2023
Jan 26 2023
Not clear what you mean by "new usages of nix develop". Presumably the "old usages of nix develop" won't even be running this code, so I'm really confused what the distinction you're introducing here.
[Nix] Add dev shell to .envrc
Jan 25 2023
Jan 25 2023
[Nix] Add easy way to start/stop localstack
[Nix] Prompt user to install direnv
Fix indentation
Fixup some debugging inclusions
Avoid prompting when in a non-interactive shell
Jan 24 2023
Jan 24 2023
Update usage
Jan 23 2023
Jan 23 2023
Install shell hook for bash and zsh
[Nix] Install homebrew on nix develop
• jon committed rCOMM947857cfda6b: [Android] Glob over individual commoncpp directories (authored by • jon).
[Android] Glob over individual commoncpp directories
[Direnv] Use nix-direnv if possible
• jon committed rCOMM6e7cd78375b5: [Nix Docs] Ensure Xcode install comes before yarn cleaninstall (authored by • jon).
[Nix Docs] Ensure Xcode install comes before yarn cleaninstall
Jan 20 2023
Jan 20 2023
bash looks fine to me, I'll defer to someone else on js best practices.
• jon added inline comments to D6316: [Nix Docs] Ensure Xcode install comes before yarn cleaninstall.
Remove link to removed section
Shouldn't matter much in the context of this particular diff, just a side note when looking at the test plan. In non-M1 mac, Homebrew uses /usr/local/bin, but for M1 (Apple silicon in general) it is /opt/homebrew/bin
If they need access to the macOS native version of clang, this makes sense.
Jan 19 2023
Jan 19 2023
[Nix] Add awscli2 to dev shell
[Nix] Re-instate nixConfig
Jan 17 2023
Jan 17 2023
Looks like I was under false assumptions.
Rebase on android gate fixes
• jon committed rCOMMfc298a32512c: [CI] Prevent all protobuf tests from being build (authored by • jon).
[CI] Prevent all protobuf tests from being build
• jon added inline comments to D5796: [keyserver] implement registerUser rpc with napi-rs/tonic/opaque-ke.
• jon requested changes to D6282: [buildkite] Adding CI test for the Tunnelbroker client shared library.
• jon accepted D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
Compiling tunnelbroker-client v0.1.0 (/home/jon/comm/comm/shared/tunnelbroker-client) Compiling h2 v0.3.15 Compiling tower v0.4.13 Compiling tower-http v0.3.5 Compiling hyper v0.14.23 Compiling hyper-timeout v0.4.1 Compiling tonic v0.8.3 Finished dev [unoptimized + debuginfo] target(s) in 48.53s
• jon added inline comments to D6282: [buildkite] Adding CI test for the Tunnelbroker client shared library.
Android failure should be solved by https://phab.comm.dev/D6288
From the logs, no testing target being built:
[ 98%] [32mBuilding CXX object CMakeFiles/libprotoc.dir/workdir/protobuf/src/google/protobuf/compiler/zip_writer.cc.o[0m [ 98%] [32m[1mLinking CXX shared library libprotoc.so[0m [ 98%] Built target libprotoc [ 99%] [32mBuilding CXX object CMakeFiles/protoc.dir/workdir/protobuf/src/google/protobuf/compiler/main.cc.o[0m [100%] [32m[1mLinking CXX executable protoc[0m [100%] Built target protoc [36mInstall the project...[0m -- Install configuration: "" -- Installing: /usr/local/lib/libprotobuf-lite.so.3.15.8.0 -- Set runtime path of "/usr/local/lib/libprotobuf-lite.so.3.15.8.0" to "$ORIGIN" -- Installing: /usr/local/lib/libprotobuf-lite.so -- Installing: /usr/local/lib/libprotobuf.so.3.15.8.0 -- Set runtime path of "/usr/local/lib/libprotobuf.so.3.15.8.0" to "$ORIGIN" -- Installing: /usr/local/lib/libprotobuf.so -- Installing: /usr/local/lib/libprotoc.so.3.15.8.0 -- Set runtime path of "/usr/local/lib/libprotoc.so.3.15.8.0" to "$ORIGIN" -- Installing: /usr/local/lib/libprotoc.so -- Installing: /usr/local/bin/protoc-3.15.8.0 -- Installing: /usr/local/bin/protoc
• jon committed rCOMM780bb1b1022a: [Nix Docs] Add section on using alternate shells (authored by • jon).
[Nix Docs] Add section on using alternate shells
[Nix] Use vanilla direnv
Jan 13 2023
Jan 13 2023
otherwise LGTM, I'll defer to tomek