In D7789#231358, @ashoat wrote:

Can you link to where you got these types from? Eg. docs or TypeScript types?

Changed discard alert content

In D7630#227524, @ashoat wrote:

There's a lot of imperative logic in this diff having to do with isExitingEditMode. I didn't review this code very closely on the first round... looking at it now, I have some comments:

1. The names could be clearer. For instance, isExitingEditMode makes me think we are leaving edit mode and going to draft mode. But from reading the code, it appears that it is more like "is exiting the page while in edit mode". How about isExitingDuringEditMode?

Addressed review

I modified the solution, and now it covers:

• blocks going to sidebar/thread settings,
• if the edited message is unedited, it doesn't show the alert,
• if the edited message is edited, it shows a confirmation alert,
• in both cases, it restores the draft.

Rewritten

Addressed feedback

Updated version in persist.js

Address comments. I've also changed the minVersion to match next version.

In D7518#224505, @ashoat wrote:

It works similarly to inlineEngagementLeftStyle and other styles in chat-constants.js, without adding it to height measurement

Thanks for explaining, @kuba! Indeed I can see it works similarly to that... both inlineEngagementLeftStyle and your new inlineEngagementLabelStyle.topOffset are used to define styles, but are not used for height calculation.

One question before I accept – can you explain a little bit why inlineEngagementLeftStyle and inlineEngagementLabelStyle.topOffset are not used in height calculations?

Might be helpful to include visuals with lines indicating what these values handle, and how they are handled already elsewhere!

Address feedback

In D7520#223110, @inka wrote:

I think it would be better to indeed check if there are any changes, for consistency with exiting edit mode in other ways (D7349).
Can you either

• do it in this diff
• do it in another diff
• create a task to do it

?

Used constant in the styling

Fixed issue, where highlight appeared on messages that didn't have id yet

Fixed glitch on Android, swapped View and TouchableOpacity order

On Android TouchableOpacity caused a visual glitch.

Addressed review

Merge imports

Add callback when exiting editMode

Fix typos

Removed redundant useGetEditedMessage function

Addressed review comments

In D7349#220108, @tomek wrote:

Could you also share a screenshot from Android?

Addressed review

Added styling to discard button

Requesting review after the changes. Now if the draft message is empty, the send button will be hidden.

Hide send button, if the draft is empty

In D7301#217546, @inka wrote:

It would be nice if you could explain a bit more precisely what the problem was. From your fix it seems the problem was with a pending thread only? But from the description of the problem it seems that the problem was with opening any tooltip. Does it work in other cases?

New function to display labels

Moved useCallback change to the earlier diff

Added useCallback, and addressed other comments

Removed some unnecessary lines

Renamed isMessageEdited function

Address @inka comments

Rebase to master

Changed useMemo usage

Matched edited label color with the designs

Moved editedText to useMemo

Matched editedLabelHeight with new fontSize

Add explicitly fontSize for label to prevent messageHeight error

Created new color in theme for messageLabel

Update test plan: https://phab.comm.dev/D7066#214478

In D7066#214942, @inka wrote:

Thank you for adding the link to the task. The DES task you linked is for Desktop though, and this is Native. Was it decided anywhere that we should use Desktop designs for Native?

Removed redundant SQL query, used fetchLatestEditMessageContentByIDs in fetchLatestEditMessageContentByID