Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Thu, Apr 18

atul updated the diff for D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

rebase and land

Thu, Apr 18, 1:20 PM

atul updated the diff for D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

rebase and land

Thu, Apr 18, 1:20 PM

atul added a comment to D11624: [lib] Fix `farcasterRelationshipRequestValidator`.

In D11624#334284, @tomek wrote:

Do we need a dedicated validator for UpdateRelationshipMessage?

Thu, Apr 18, 1:19 PM

atul added inline comments to D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.

Thu, Apr 18, 1:18 PM

atul closed D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual`.

Thu, Apr 18, 1:11 PM

atul committed rCOMM1bae5d5e9484: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle… (authored by atul).

[lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle…

Thu, Apr 18, 1:11 PM

atul updated the diff for D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual`.

land

Thu, Apr 18, 1:09 PM

atul closed D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual`.

Thu, Apr 18, 1:05 PM

atul committed rCOMM0b125c91012d: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle… (authored by atul).

[lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle…

Thu, Apr 18, 1:05 PM

atul updated the diff for D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual`.

land

Thu, Apr 18, 1:05 PM

atul closed D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Thu, Apr 18, 12:38 PM

atul committed rCOMM06f7b1904d97: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update… (authored by atul).

[lib] Include `[creator/target]FID` in `messageContentForServerDB` when update…

Thu, Apr 18, 12:38 PM

atul added inline comments to D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Thu, Apr 18, 12:37 PM

atul added inline comments to D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Thu, Apr 18, 11:50 AM

atul closed D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Thu, Apr 18, 11:48 AM

atul committed rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update… (authored by atul).

[lib] Split `UpdateRelationshipMessageInfo` into `Update…

Thu, Apr 18, 11:48 AM

atul attached a referenced file: F1520661: 8c0f7f.png.

Thu, Apr 18, 11:43 AM

atul updated the diff for D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

rebase and aldn

Thu, Apr 18, 11:43 AM

atul attached a referenced file: F1572505: 158a3d.png.

Thu, Apr 18, 11:39 AM

atul added inline comments to D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Thu, Apr 18, 11:07 AM

atul added inline comments to D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Thu, Apr 18, 11:05 AM

Wed, Apr 17

atul closed D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

Wed, Apr 17, 1:17 PM

atul committed rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate… (authored by atul).

[lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate…

Wed, Apr 17, 1:17 PM

atul updated the diff for D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

address feedback and land

Wed, Apr 17, 1:10 PM

atul updated the diff for D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

rebase BEFORE addressing feedback

Wed, Apr 17, 12:58 PM

atul closed D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

Wed, Apr 17, 12:42 PM

atul committed rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`… (authored by atul).

[lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`…

Wed, Apr 17, 12:42 PM

atul added a comment to D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

This is safe to land since we don't have equivalent to https://github.com/CommE2E/comm/commit/7024301fcda748efefa900bd952cd8e127aac87d landed on master yet so these messages aren't currently getting created.

Wed, Apr 17, 12:41 PM

atul updated the diff for D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

address @tomek's feedback

Wed, Apr 17, 12:40 PM

atul added inline comments to D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

Wed, Apr 17, 12:37 PM

atul added a comment to D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

JK, we need D11606 to land this

Wed, Apr 17, 12:24 PM

atul updated the diff for D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

rebase and land

Wed, Apr 17, 12:15 PM

atul added a comment to D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

This diff is safe to land since we're just narrowing flow types on the clients. No runtime changes so this shouldn't break anything.

Wed, Apr 17, 12:13 PM

atul closed D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

Wed, Apr 17, 12:10 PM

atul committed rCOMMef12de0da55f: [keyserver] Update `createPersonalThreads` to support both `… (authored by atul).

[keyserver] Update `createPersonalThreads` to support both `…

Wed, Apr 17, 12:10 PM

atul updated the diff for D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

rebase and land

Wed, Apr 17, 12:08 PM

atul added a comment to D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

This diff is safe to land as is as it broadens what arguments createPersonalThreads can accept and TraditionalRelationshipRequests will continue to work as expected.

Wed, Apr 17, 12:04 PM

atul published D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB for review.

Wed, Apr 17, 11:55 AM

atul updated the test plan for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Wed, Apr 17, 11:18 AM

atul attached a referenced file: F1559388: 6e04a6.png.

Wed, Apr 17, 11:16 AM

atul published D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages for review.

Wed, Apr 17, 11:16 AM

atul accepted D11672: create new aux user store action for clearing fids.

Looks good

Wed, Apr 17, 9:37 AM

atul added inline comments to D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Wed, Apr 17, 9:35 AM

Tue, Apr 16

atul updated the diff for D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

remove hack from stack

Tue, Apr 16, 12:43 PM

atul published D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages for review.

Tue, Apr 16, 12:27 PM

atul updated the summary of D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Tue, Apr 16, 12:22 PM

atul accepted D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.

Tue, Apr 16, 11:35 AM

atul added inline comments to D11667: [lib] Fix legacy register and SIWE.

Tue, Apr 16, 11:33 AM

atul accepted D11667: [lib] Fix legacy register and SIWE.

Tue, Apr 16, 11:31 AM

atul updated the diff for D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

fix TUnion import

Tue, Apr 16, 10:51 AM

Mon, Apr 15

atul accepted D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.

Looks good, let's definitely memoize return value of TagFarcasterChannelNavigator.

Mon, Apr 15, 4:36 PM

atul accepted D11613: [lib/native] introduce connect farcaster alert handler.

Code changes look good, would be good to make sure all other notes left by other reviewers are addressed/responded to before landing.

Mon, Apr 15, 4:33 PM

Fri, Apr 12

atul published D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual` for review.

Fri, Apr 12, 1:12 PM

atul published D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual` for review.

Fri, Apr 12, 12:59 PM

atul updated the test plan for D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Fri, Apr 12, 12:27 PM

atul published D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual` for review.

Fri, Apr 12, 12:26 PM

atul requested review of D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Fri, Apr 12, 12:03 PM

Thu, Apr 11

atul requested review of D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

Thu, Apr 11, 8:58 PM

atul published D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData` for review.

Thu, Apr 11, 8:06 PM

atul accepted D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Thu, Apr 11, 6:53 PM

atul accepted D11637: Implement JSI getter and setter for siwe backup secrets.

Looks good. (There shouldn't be any WASM stuff that needs to be generated for the non-DB code here right?)

Thu, Apr 11, 6:42 PM

atul added a comment to D11636: Implement screen to create backup mesage and its signature.

Would also be good to include some screenshots of what it looks like in Test Plan so reviewers can side-by-side with the Figma designs

Thu, Apr 11, 6:38 PM

atul added a reviewer for D11636: Implement screen to create backup mesage and its signature: ginsu.

Thu, Apr 11, 6:38 PM

atul accepted D11636: Implement screen to create backup mesage and its signature.

Thu, Apr 11, 6:37 PM

atul accepted D11635: Handle backup message type with different user texts in siwe.reac.js.

Thu, Apr 11, 6:25 PM

atul accepted D11628: [lib] Make synced metadata name field an enum.

Thu, Apr 11, 6:21 PM

atul accepted D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.

Thu, Apr 11, 6:18 PM

atul accepted D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

Thu, Apr 11, 6:18 PM

atul accepted D11618: [native][web] Read thread activity entries from SQLite on app start.

Thu, Apr 11, 6:18 PM

atul accepted D11616: [native] migrate threadActivityStore to SQLite.

Thu, Apr 11, 6:16 PM

atul accepted D11634: Introduce user texts for siwe backup message creation.

Thu, Apr 11, 12:23 PM

atul accepted D11633: Introduce SIWE message types.

Looks clean!

Thu, Apr 11, 12:15 PM

atul accepted D11640: [lib] rewrite integrityInfos ThreadHashes.

Thu, Apr 11, 12:04 PM

Wed, Apr 10

atul requested review of D11624: [lib] Fix `farcasterRelationshipRequestValidator`.

Wed, Apr 10, 1:25 PM

atul updated the diff for D11612: [lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`.

rebase

Wed, Apr 10, 12:22 PM

atul updated the diff for D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.

rebasing

Wed, Apr 10, 12:22 PM

atul updated the diff for D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.

rebasing

Wed, Apr 10, 12:22 PM

atul updated the diff for D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

address @tomek's feedback

Wed, Apr 10, 12:20 PM

atul added inline comments to D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

Wed, Apr 10, 12:20 PM

atul attached a referenced file: F1510994: 3cf86a.png.

Wed, Apr 10, 12:18 PM

atul updated the diff for D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

rebasing stack

Wed, Apr 10, 12:18 PM

atul added inline comments to D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

Wed, Apr 10, 12:18 PM

atul updated the diff for D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

address @ashoat's feedback

Wed, Apr 10, 12:14 PM

atul added inline comments to D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

Wed, Apr 10, 12:10 PM

atul updated the diff for D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

address @tomek's feedback

Wed, Apr 10, 12:06 PM

atul closed D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.

Wed, Apr 10, 11:55 AM

atul committed rCOMMeef5dc5615bc: [lib] Re-introduce `RelationshipRequest` and replace… (authored by atul).

[lib] Re-introduce `RelationshipRequest` and replace…

Wed, Apr 10, 11:54 AM

atul updated the diff for D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.

land

Wed, Apr 10, 11:54 AM

atul closed D11603: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.

Wed, Apr 10, 11:51 AM

atul committed rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*` (authored by atul).

[lib] Rename `sansFarcaster` variable names and types to `Traditional*`

Wed, Apr 10, 11:51 AM

atul updated the diff for D11603: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.

land

Wed, Apr 10, 11:39 AM

atul attached a referenced file: F1510592: fbb9f4.png.

Wed, Apr 10, 11:36 AM

atul added a comment to D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

As discussed offline it might make sense to do something like

Wed, Apr 10, 11:35 AM

atul closed D11602: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`.

Wed, Apr 10, 11:28 AM

atul committed rCOMMc18881ba3684: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest` (authored by atul).

[lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`

Wed, Apr 10, 11:28 AM

atul updated the diff for D11602: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`.

land

Wed, Apr 10, 11:27 AM

atul accepted D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.

jk, you already handled this in stack

Wed, Apr 10, 10:43 AM

atul requested changes to D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.

Might be missing something, but don't we also need to update default states? For example in defaultWebState?

Wed, Apr 10, 10:41 AM

atul accepted D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.

Wed, Apr 10, 10:39 AM

atul accepted D11599: [lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file.

Wed, Apr 10, 10:05 AM