Adding debounce to persisting,
I set up the database for drafts and persist was not called on each character changed but was debounced as expected.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 31 2023
add debounce
Mar 30 2023
Requesting changes to push it back to you, but if I am missing something re-request review and I will unblock this as soon as possible.
separate code for two diffs
fix query format
fix type and query format
fix query formatting
address nit
Mar 28 2023
Looks good!!
In the test plan for the Confirm migration for new clients already with the column works
I'm not entirely sure if we really even need to consider a case where a new client will already have the column besides me in development work, so I can also just remove that check entirely and just add the column. I ran into this inconsistency while working off of my modified schema and running a migration on top of that
Mar 27 2023
When you're modifying SQLite database on native you should do two things:
- Update create_schema - this code is running on a fresh install/logout user (you did it properly)
- Add new migration which will update this table when existing users will update the app to a newer version. We were adding NOT EXISTS everywhere because of multiple crashes at that time, but I think it should work without this constraint (a lot of refactors were done to avoid problems). If you really want to make this code resistant you can use PRAGMA table_info() to check if the column exists and then execute ALTER TABLE.
Mar 25 2023
rebase
address review
FYI By mistake, two diffs had different order in the stack than in my branch on git - that's why I needed to fix parent/child revisions because arcanist didn't allow me to arc diff but this has no influence on the code itself
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
reabse before landing
Mar 24 2023
Mar 23 2023
add import, improve query format
In D7118#212107, @ashoat wrote:We should not be polluting the global namespace in D7101. You should not be able to use QueryExecResult without importing it unless it's in the Flow lib.
add import
rebase
address code review
Mar 22 2023
update type
update type
Mar 21 2023
rename function to be more detailed