rebase + land
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 6 2023
Mar 6 2023
atul added inline comments to D6822: Sign concatenation of public and notif keypairs using private key of public identity.
atul updated the diff for D6956: [lib] Add `getSignedIdentityKeysBlob` to `getClientResponsesSelector`.
Address review
atul published D6956: [lib] Add `getSignedIdentityKeysBlob` to `getClientResponsesSelector` for review.
Mar 5 2023
Mar 5 2023
• jon added a comment to D6955: [keyserver] change how we load config for the identity service client.
not sure why i reviewed knowing full well it was relating to the keyserver code, then responded about the server.
atul updated the diff for D6952: [keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator`.
rebase + land
atul added a comment to D6952: [keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator`.
In D6952#206965, @ashoat wrote:I'd probably include this with another diff tbh... I think it's easier to see stuff like this combined with the usage, and it's easier to put a concrete test plan too
ashoat accepted D6952: [keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator`.
I'd probably include this with another diff tbh... I think it's easier to see stuff like this combined with the usage, and it's easier to put a concrete test plan too
• jon added a comment to D6955: [keyserver] change how we load config for the identity service client.
I think short term this is fine.
Mar 4 2023
Mar 4 2023
Seems reasonable, defer to others on Rust
varun updated the diff for D6955: [keyserver] change how we load config for the identity service client.
map camelCase JSON to snake_case struct
varun requested review of D6955: [keyserver] change how we load config for the identity service client.
atul updated the diff for D6951: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types.
fix typo
atul updated the diff for D6951: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types.
rebase
I'll sneak this in D6951
In D6954#206917, @varun wrote:stat-padding smh
Mar 3 2023
Mar 3 2023
Please wait for CI before landing
Move unneeded parameters to protobuf message creation
Harbormaster failed remote builds in B17118: Diff 23445 for D6939: [Identity] Implment update_user endpoint on server!
Consolidate imports
Harbormaster failed remote builds in B17116: Diff 23443 for D6944: [Keyserver/identity] Call identity service update_user!
Apply error and typo feedback
Address varuns feedback
please address the typos and import consolidation before landing, i'm fine with deferring the error logging/Status stuff and creating a linear task for it
atul updated the diff for D6950: [lib] Introduce `identityKeysBlobValidator` and use in `login`/`register`/`siwe_auth` responders.
land
back to your queue to address feedback on previous revision
atul updated the diff for D6950: [lib] Introduce `identityKeysBlobValidator` and use in `login`/`register`/`siwe_auth` responders.
rebase after addressing merge conflict
LGTM
Explicitly await update user action
Harbormaster failed remote builds in B17109: Diff 23435 for D6944: [Keyserver/identity] Call identity service update_user!
Restore rng parameter
Restore rng parameter
I'm good with backlogging my suggestions, just want to make sure we call them all out specifically in the linear task so we don't lose track of small things
Rebase on master
Rebase on master
Rebase on master
Apply feedback, rebase on master
Let's capitalize Identity Service everywhere in the .proto file for consistency. otherwise looks good
ashoat added inline comments to D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.