address feedback
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 3 2023
Mar 3 2023
varun updated the diff for D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.
atul published D6952: [keyserver] Add `SIGNED_IDENTITY_KEYS_BLOB` to `clientResponseInputValidator` for review.
looks fine to me rust wise
varun added inline comments to D6945: [identity] db and siwe verification changes to handle login requests from keyserver.
• jon accepted D6945: [identity] db and siwe verification changes to handle login requests from keyserver.
otherwise looks fine rust wise
In D6944#206752, @atul wrote:In D6944#206737, @ashoat wrote:but identity build seems to have failed CI
Looks like this was because of issues with Buildkite Agent API, restarted the workflows.
In D6943#206753, @ashoat wrote:Why is socialProof separate from siweMessage + siweSignature? Is it for the same reason that we pull signingPublicKey from sessionInitializationInfo (convenience)?
Why is socialProof separate from siweMessage + siweSignature? Is it for the same reason that we pull signingPublicKey from sessionInitializationInfo (convenience)?
In D6944#206737, @ashoat wrote:but identity build seems to have failed CI
Make logging and errors more consistent
ashoat added inline comments to D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.
ashoat added inline comments to D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.
JS looks good, but identity build seems to have failed CI. Adding @varun as blocking for the Rust side of things
Harbormaster failed remote builds in B17101: Diff 23421 for D6944: [Keyserver/identity] Call identity service update_user!
varun added inline comments to D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.
address feedback
Handle promises more gracefully
ashoat accepted D6951: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types.
Please wait on relevant parts of CI
atul published D6951: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types for review.
atul added inline comments to D6950: [lib] Introduce `identityKeysBlobValidator` and use in `login`/`register`/`siwe_auth` responders.
varun updated the diff for D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.
address feedback
Just got to the point of a successful update, still need to address feedback
Serialize messages in correct order
varun added a comment to D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.
Realizing my comment from last time probably doesn't make sense to Flow
varun updated the diff for D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.
address feedback
ashoat added a reviewer for D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint: atul.
ashoat added a reviewer for D6941: [keyserver] call Identity service RegisterUser RPC from createAccount: atul.
ashoat accepted D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.
Just one nit. Realizing my comment from last time probably doesn't make sense to Flow, and passing in the primary ed25519 twice (in signingPublicKey and sessionInitializationInfo) lets Rust avoid having to re-parse the JSON
Defer to you guys, I don't know enough about PAKE to comment on the .proto, and I don't know Rust so can't comment on the rest
Harbormaster failed remote builds in B17095: Diff 23405 for D6919: Remove relevant notification from notifications center when receiving rescind in NSE!
marcin updated the diff for D6919: Remove relevant notification from notifications center when receiving rescind in NSE.
Post semaphore once and only once. Give lambda a better name
Remove artificial body property
Improve parsing and error handling
tomek requested review of D6947: [services][feature-flags] Serve application/json instead of text/plain.
Restricted Repository Identity closed D6927: [desktop CI] Inherit secrets in github release workflow.
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM9bce5caf7b62: [desktop CI] Inherit secrets in github release workflow.
I'm still working on one remaining issue with message ordering, but wanted the diff to be up so varun had more time to review
We talked about the usage of access tokens, and decided that we can defer doing access_token validation when the client (not keyserver) is able to provide them.
We talked about the usage of access tokens, and decided that we can defer doing access_token validation when the client (not keyserver) is able to provide them.