Rebase

Rebase

Update errors in lib/hooks/input-state-container-hooks.js

Adding more reviewers here - maybe there is more edge-cases that worth testing too

In D13880#387505, @ashoat wrote:

Great find here!! Is it possible that this fixes ENG-8780 as well? I think that one is also a permissions issue.

Nice find!

Alternatively, we can download only backupID and read backupDataKey and backupLogDataKey (it should exist on primary always) to avoid downloading User Keys - but curious about @bartek's perspective as I don't fully remember why it was implemented that way,

Nice!

In D13885#387606, @varun wrote:

We normally wait a day before promoting a version from staging to prod

I don't love that we're breaking precedent here, but since we are, I compared 0.44 and 0.45 on GitHub to make sure we're not accidentally including any other changes. I don't see any changes to shared/ or services/identity besides the ones in D13883, so this appears safe

We normally wait a day before promoting a version from staging to prod

1. I'll confirm that staging successfully deploys without issue
2. Once staging is deployed, I'll confirm that I'm still able to log in to staging identity

I won't land this until both are confirmed.

In D13874#387555, @angelika wrote:

Are you sure this improves performance?

Tag published here

Removed my suggestion, your solution is good

Will wait on identity CI to pass before landing

Are you sure this improves performance? Did you measure it after making this change and compared it with before the change? Performance improvements are tricky.
As far as I understand useThreadsWithPermission will be called every time useThreadHasPermission is called, even with useMemo. This is a hook, not a component.
Here is a snack with this code but simplified: https://snack.expo.dev/@angelikaserwa/suspicious-violet-tortillas
After you press the button, the app will re-render and useThreadsWithPermission will be called, even with memo.

Doesn't look like this worked, unfortunately

D13882

This was an unsafe change and is causing deployment failures in production. I think @varun was wrong in his assessment that the port could be skipped for web.comm.app.

For SLDs I've always included www.. Probably not as relevant anymore, but in the past it was something that some computers and some people would include when navigating to an SLD

do you need the www URL?

LGTM, but setting @bartek as blocking since @kamil has asked for his thoughts above

left a question inline

rebase

rebase

fix typo

rename

Review changes

Rebase

Rebase