Page MenuHomePhabricator
Feed All Stories

Thu, Nov 7

ashoat committed rCOMMcaf1601b898e: [lib] Fix useThreadsWithPermission check (authored by ashoat).
[lib] Fix useThreadsWithPermission check
Thu, Nov 7, 6:22 AM
ashoat closed D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.
Thu, Nov 7, 6:22 AM
ashoat committed rCOMMe17a45b3ef95: [lib] Avoid creating new array on every invocation of useThreadHasPermission (authored by ashoat).
[lib] Avoid creating new array on every invocation of useThreadHasPermission
Thu, Nov 7, 6:22 AM
ashoat updated the diff for D13886: [lib] Fix useThreadsWithPermission check.

Add code comment

Thu, Nov 7, 6:20 AM
ashoat added inline comments to D13886: [lib] Fix useThreadsWithPermission check.
Thu, Nov 7, 6:15 AM
ashoat accepted D13892: [native][web] Clean up dead conditions for media encryption.

It seems like we can delete commStaffCommunity and threadInfoInsideCommunity from the codebase as well. What do you think?

Thu, Nov 7, 5:35 AM
ashoat accepted D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.
Thu, Nov 7, 5:32 AM
ashoat accepted D13890: [native][web] Stop limiting media encryption to staff community.
Thu, Nov 7, 5:32 AM
ashoat accepted D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
Thu, Nov 7, 5:31 AM
ashoat accepted D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Thu, Nov 7, 5:29 AM
ashoat added a comment to D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.

I compiled some notes that we can go through in our next 1:1. Ahead of that, I figured it might help to share a list of React render cycles issues solved by adding React.useMemos like this:

Thu, Nov 7, 5:13 AM
bartek added inline comments to D13892: [native][web] Clean up dead conditions for media encryption.
Thu, Nov 7, 4:52 AM
bartek published D13892: [native][web] Clean up dead conditions for media encryption for review.
Thu, Nov 7, 4:51 AM
bartek published D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads for review.
Thu, Nov 7, 4:51 AM
bartek published D13890: [native][web] Stop limiting media encryption to staff community for review.
Thu, Nov 7, 4:50 AM
bartek published D13889: [native][web] Add migration to unshim Blob-hosted multimedia for review.
Thu, Nov 7, 4:50 AM
bartek published D13888: [lib] Stop shimming Blob-hosted multimedia messages for review.
Thu, Nov 7, 4:50 AM
ashoat added inline comments to D13886: [lib] Fix useThreadsWithPermission check.
Thu, Nov 7, 4:45 AM
ashoat added a comment to D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.

Ok, it makes sense, though it's a bit weird to me. This useMemo affects how another hook is calculated.

Thu, Nov 7, 4:39 AM
kamil closed D13857: [backup] add code comment to `UserKeys` definition explaining Olm account might be out of date.
Thu, Nov 7, 4:36 AM
kamil closed D13893: [terraform] deploy backup 0.5.0 to staging.
Thu, Nov 7, 4:36 AM
kamil committed rCOMMd8b209715799: [backup] add code comment to `UserKeys` definition explaining Olm account might… (authored by kamil).
[backup] add code comment to `UserKeys` definition explaining Olm account might…
Thu, Nov 7, 4:36 AM
kamil committed rCOMM4c2bf6a62dff: [terraform] deploy backup 0.5.0 to staging (authored by kamil).
[terraform] deploy backup 0.5.0 to staging
Thu, Nov 7, 4:36 AM
tomek accepted D13886: [lib] Fix useThreadsWithPermission check.
Thu, Nov 7, 4:34 AM
angelika accepted D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.

I probably should have explained this differently. What I meant is that we're currently forcing the useMemo in useThreadsWithPermission to be recalculated on every call from useThreadHasPermission. This diff fixes that.

Ok, it makes sense, though it's a bit weird to me. This useMemo affects how another hook is calculated. Maybe a comment would be useful?

Thu, Nov 7, 4:27 AM
bartek accepted D13893: [terraform] deploy backup 0.5.0 to staging.
Thu, Nov 7, 4:16 AM
kamil updated the diff for D13857: [backup] add code comment to `UserKeys` definition explaining Olm account might be out of date.

remove extra line

Thu, Nov 7, 4:14 AM
kamil published D13893: [terraform] deploy backup 0.5.0 to staging for review.
Thu, Nov 7, 4:13 AM
tomek accepted D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.
Thu, Nov 7, 4:09 AM
kamil closed D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
Thu, Nov 7, 4:07 AM
kamil closed D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately.
Thu, Nov 7, 4:07 AM
kamil closed D13876: [backup-service] implement endpoint to upload User Keys.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM82729d054cba: [backup-service][commtest] implement integration tests for uploading User Keys… (authored by kamil).
[backup-service][commtest] implement integration tests for uploading User Keys…
Thu, Nov 7, 4:07 AM
kamil closed D13877: [backup-service] implement endpoint to upload User Data.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM8561f8e86b3e: [backup-service] make `user_data` and `user_keys` optional in `BackupData` (authored by kamil).
[backup-service] make `user_data` and `user_keys` optional in `BackupData`
Thu, Nov 7, 4:07 AM
kamil committed rCOMM556469ea7e45: [backup-service] implement endpoint to upload User Data (authored by kamil).
[backup-service] implement endpoint to upload User Data
Thu, Nov 7, 4:07 AM
kamil closed D13875: [backup-service] make `user_data` optional in `BackupItem`.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM3eeef1e77029: [backup-service] implement endpoint to upload User Keys (authored by kamil).
[backup-service] implement endpoint to upload User Keys
Thu, Nov 7, 4:07 AM
kamil closed D13873: [backup-service] refactor uploading function in `/backups` endpoint.
Thu, Nov 7, 4:07 AM
kamil committed rCOMMe8f80a8bdb8c: [backup-service] make `user_data` optional in `BackupItem` (authored by kamil).
[backup-service] make `user_data` optional in `BackupItem`
Thu, Nov 7, 4:07 AM
kamil committed rCOMMb8c417d81cec: [backup-service] refactor uploading function in `/backups` endpoint (authored by kamil).
[backup-service] refactor uploading function in `/backups` endpoint
Thu, Nov 7, 4:07 AM
kamil closed D13872: [commtest] refactor backup service integration tests.
Thu, Nov 7, 4:07 AM
kamil closed D13850: [native_rust_library] remove `backupID` from `SIWEBackupData`.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM045eb2371305: [commtest] refactor backup service integration tests (authored by kamil).
[commtest] refactor backup service integration tests
Thu, Nov 7, 4:07 AM
kamil committed rCOMMd629425cb3f3: [native_rust_library] remove `backupID` from `SIWEBackupData` (authored by kamil).
[native_rust_library] remove `backupID` from `SIWEBackupData`
Thu, Nov 7, 4:07 AM
kamil closed D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM0cdb17b3921e: [CommCoreModule][native_rust_library] update downloading User Keys to support… (authored by kamil).
[CommCoreModule][native_rust_library] update downloading User Keys to support…
Thu, Nov 7, 4:07 AM
kamil closed D13847: [native] update Secondary Device Auth flow to support SIWE users.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM1960a4d944f8: [native] update Secondary Device Auth flow to support SIWE users (authored by kamil).
[native] update Secondary Device Auth flow to support SIWE users
Thu, Nov 7, 4:07 AM
kamil closed D13846: [CommCoreModule][native_rust_library] deprecate SIWE related backup code.
Thu, Nov 7, 4:07 AM
kamil closed D13844: [native] unify username and wallet backup restore.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM0504d518f7f1: [CommCoreModule][native_rust_library] deprecate SIWE related backup code (authored by kamil).
[CommCoreModule][native_rust_library] deprecate SIWE related backup code
Thu, Nov 7, 4:07 AM
kamil closed D13840: [backup-client] make `backupID` mandatory when restoring backup.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM5a8e0d6d32c6: [native] unify username and wallet backup restore (authored by kamil).
[native] unify username and wallet backup restore
Thu, Nov 7, 4:07 AM
kamil committed rCOMM955ec0a26dea: [backup-client] make `backupID` mandatory when restoring backup (authored by kamil).
[backup-client] make `backupID` mandatory when restoring backup
Thu, Nov 7, 4:07 AM
kamil closed D13839: [native] make it possible to test retrieving latest backup info.
Thu, Nov 7, 4:07 AM
kamil closed D13838: [CommCoreModule] expose method to retrieve latest backup info.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM98b8c540afcb: [native] make it possible to test retrieving latest backup info (authored by kamil).
[native] make it possible to test retrieving latest backup info
Thu, Nov 7, 4:07 AM
kamil closed D13837: [native_rust_library] implement method to retrieve latest backup info.
Thu, Nov 7, 4:07 AM
kamil committed rCOMMa32506b148da: [CommCoreModule] expose method to retrieve latest backup info (authored by kamil).
[CommCoreModule] expose method to retrieve latest backup info
Thu, Nov 7, 4:07 AM
kamil closed D13836: [backup-client] refactor `SIWEBackupData` type.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info (authored by kamil).
[native_rust_library] implement method to retrieve latest backup info
Thu, Nov 7, 4:07 AM
kamil committed rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type (authored by kamil).
[backup-client] refactor `SIWEBackupData` type
Thu, Nov 7, 4:07 AM
kamil closed D13809: [backup-service][backup-client] update `/latest` endpoint to return both `backupID` and `userID`.
Thu, Nov 7, 4:07 AM
kamil closed D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM8f72e02e2b90: [backup-service][backup-client] update `/latest` endpoint to return both… (authored by kamil).
[backup-service][backup-client] update `/latest` endpoint to return both…
Thu, Nov 7, 4:07 AM
kamil committed rCOMMa966b4320fa6: [backup-service][backup-client] rename `username` -> `user_identifier` (authored by kamil).
[backup-service][backup-client] rename `username` -> `user_identifier`
Thu, Nov 7, 4:07 AM
kamil closed D13807: [backup-service] use `username` instead of `userID` when downloading backup.
Thu, Nov 7, 4:07 AM
kamil committed rCOMMf10da684e155: [backup-service] use `username` instead of `userID` when downloading backup (authored by kamil).
[backup-service] use `username` instead of `userID` when downloading backup
Thu, Nov 7, 4:07 AM
kamil closed D13817: [docker-compose] configure Identity endpoint for backup in commtest.
Thu, Nov 7, 4:07 AM
kamil committed rCOMM0422e7595594: [docker-compose] configure Identity endpoint for backup in commtest (authored by kamil).
[docker-compose] configure Identity endpoint for backup in commtest
Thu, Nov 7, 4:07 AM
kamil closed D13806: [backup-service] implement calling `FindUserID` RPC from Backup.
Thu, Nov 7, 4:07 AM
kamil closed D13805: [commtest] use registered `UserIdentity` in backup tests.
Thu, Nov 7, 4:07 AM
kamil committed rCOMMe7b7c5923a85: [backup-service] implement calling `FindUserID` RPC from Backup (authored by kamil).
[backup-service] implement calling `FindUserID` RPC from Backup
Thu, Nov 7, 4:07 AM
kamil committed rCOMMc44768a780d3: [commtest] use registered `UserIdentity` in backup tests (authored by kamil).
[commtest] use registered `UserIdentity` in backup tests
Thu, Nov 7, 4:06 AM
kamil closed D13803: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`.
Thu, Nov 7, 4:06 AM
kamil committed rCOMMaa69c9069ff7: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib` (authored by kamil).
[identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
Thu, Nov 7, 4:06 AM
Harbormaster failed remote builds in B32567: Diff 45654 for D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately!
Thu, Nov 7, 3:31 AM
kamil updated the diff for D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately.

rebase before landing

Thu, Nov 7, 3:25 AM
angelika closed D13887: [lib] Add staff alert for missing device keys.
Thu, Nov 7, 3:23 AM
angelika committed rCOMM7ded1af90f7e: [lib] Add staff alert for missing device keys (authored by angelika).
[lib] Add staff alert for missing device keys
Thu, Nov 7, 3:23 AM
kamil added inline comments to D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
Thu, Nov 7, 2:11 AM
kamil updated the diff for D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.

address review

Thu, Nov 7, 2:11 AM
kamil added inline comments to D13876: [backup-service] implement endpoint to upload User Keys.
Thu, Nov 7, 2:08 AM
kamil added a comment to D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier.

Alternatively, we can download only backupID and read backupDataKey and backupLogDataKey (it should exist on primary always) to avoid downloading User Keys - but curious about @bartek's perspective as I don't fully remember why it was implemented that way,

I don't remember either. Your changes make sense though

Thu, Nov 7, 2:04 AM
Harbormaster failed remote builds in B32565: Diff 45651 for D13836: [backup-client] refactor `SIWEBackupData` type!
Thu, Nov 7, 2:03 AM
kamil updated the diff for D13836: [backup-client] refactor `SIWEBackupData` type.

address nit

Thu, Nov 7, 1:56 AM
kamil accepted D13887: [lib] Add staff alert for missing device keys.
Thu, Nov 7, 12:56 AM
bartek accepted D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
Thu, Nov 7, 12:38 AM

Wed, Nov 6

bartek accepted D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately.
Wed, Nov 6, 9:41 PM
bartek added inline comments to D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
Wed, Nov 6, 9:40 PM
bartek accepted D13877: [backup-service] implement endpoint to upload User Data.
Wed, Nov 6, 9:32 PM
angelika requested review of D13887: [lib] Add staff alert for missing device keys.
Wed, Nov 6, 1:49 PM
angelika closed D13863: [lib] Remove unecessary utils-copy-error dependency.
Wed, Nov 6, 6:41 AM
angelika closed D13864: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers.
Wed, Nov 6, 6:41 AM
angelika committed rCOMM3f50d089ad51: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers (authored by angelika).
[lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers
Wed, Nov 6, 6:41 AM
angelika committed rCOMM90e919811458: [lib] Remove unecessary utils-copy-error dependency (authored by angelika).
[lib] Remove unecessary utils-copy-error dependency
Wed, Nov 6, 6:41 AM
angelika closed D13862: [lib] Replace cloneError() with SendMessageError.
Wed, Nov 6, 6:41 AM
angelika committed rCOMM715cdf31911a: [lib] Replace cloneError() with SendMessageError (authored by angelika).
[lib] Replace cloneError() with SendMessageError
Wed, Nov 6, 6:41 AM
bartek accepted D13876: [backup-service] implement endpoint to upload User Keys.
Wed, Nov 6, 6:13 AM