Review changes
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Tue, Nov 5
Tue, Nov 5
I like this new approach 👌
Mon, Nov 4
Mon, Nov 4
bartek retitled D13838: [CommCoreModule] expose method to retrieve latest backup info from [CommCoreModule] expose method retrieve latest backup info to [CommCoreModule] expose method to retrieve latest backup info.
ashoat committed rCOMM5218ac3a7cf0: [terraform] Bump keyserver image to 1.0.140 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.140
Love to see a dependency get removed!!
Can you add a specific message to each SendMessageError error? I realize it wasn't there before, but it might be helpful here to have some additional context
[web][keyserver] codeVersion -> 140
ashoat requested review of D13871: [native] Get rid of bottomSheetPaddingTop in ConnectFarcasterBottomSheet.
will committed rCOMMbae9f43c5bb6: [keyserver] replace sidebar source message quotes with markdown quotes (authored by will).
[keyserver] replace sidebar source message quotes with markdown quotes
will committed rCOMM6cee524642a6: [keyserver] change channel text from channel name to slash channel id (authored by will).
[keyserver] change channel text from channel name to slash channel id
ashoat requested review of D13869: [native] Fix incorrectly set verticalBounds in UserProfileAvatar.
ashoat requested review of D13867: [native] Consider BottomSheetHandle size when setting snapPoints.
will updated the summary of D13866: [keyserver] replace sidebar source message quotes with markdown quotes.
will updated the summary of D13865: [keyserver] change channel text from channel name to slash channel id.
ashoat added a comment to D13865: [keyserver] change channel text from channel name to slash channel id.
Can you link the Linear task(s) you're addressing? Please always link in both directions (Linear to Phabricator, Phabricator to Linear)
ashoat added a comment to D13866: [keyserver] replace sidebar source message quotes with markdown quotes.
Can you link the Linear task(s) you're addressing? Please always link in both directions (Linear to Phabricator, Phabricator to Linear)
ashoat added a comment to D13125: [native] add ability to remove devices from linked devices bottom sheet.
I put up a stack of diffs here: D13871
ashoat added a comment to D13125: [native] add ability to remove devices from linked devices bottom sheet.
I looked at this more closely and indeed it appears that the prior revision is a hack.
will requested review of D13866: [keyserver] replace sidebar source message quotes with markdown quotes.
will requested review of D13865: [keyserver] change channel text from channel name to slash channel id.
angelika requested review of D13864: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers.
ashoat requested changes to D13262: [native] only display remove device button if current device is primary device.
Due to issues in D13125, I ended up checking out this stack locally. While testing I found the experience confusing due to inconsistency between the behavior of primary and non-primary device pills
Rebase
ashoat requested changes to D13125: [native] add ability to remove devices from linked devices bottom sheet.
This solution is ringing alarm bells. It feels like a hack... seems like you just added some padding to push the content up, but it's unclear to me why this padding needs to be added (what is it making up for?)
Include thread info in the notif data
bartek accepted D13809: [backup-service][backup-client] update `/latest` endpoint to return both `backupID` and `userID`.
Neat idea with this rename to backup info
bartek updated the diff for D13125: [native] add ability to remove devices from linked devices bottom sheet.
Add missing bottom padding
bartek attached a referenced file: F3146598: Simulator Screenshot - iPhone 15 Pro - 2024-10-25 at 10.25.13.png.
bartek added a comment to D13125: [native] add ability to remove devices from linked devices bottom sheet.
In D13125#384627, @ashoat wrote:Thanks for sharing the video! Unfortunately, the button appears over the home pill. Can you make sure that the button appears above the home pill? As an example, take a look at the use of useSafeAreaInsets in KeyserverSelectionBottomSheet
kamil updated the test plan for D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier.
Sun, Nov 3
Sun, Nov 3
kamil requested review of D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
Fri, Nov 1
Fri, Nov 1
ashoat committed rCOMMdf2e75f1bfe8: [terraform] Bump keyserver image to 1.0.139 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.139
varun requested changes to D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
ashoat committed rCOMM765732e3efd9: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
[native] codeVersion -> 436
ashoat committed rCOMM3ac08195fbc6: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
[native] codeVersion -> 435
[web][keyserver] codeVersion -> 139
will committed rCOMM9849ba9bdc80: [keyserver] add link back to original warpcast cast in farcaster bot sidebar… (authored by will).
[keyserver] add link back to original warpcast cast in farcaster bot sidebar…
[keyserver] deconstruct sidebarCast fields
will added inline comments to D13855: [keyserver] add link back to original warpcast cast in farcaster bot sidebar source message.
ashoat added inline comments to D13855: [keyserver] add link back to original warpcast cast in farcaster bot sidebar source message.
will added inline comments to D13855: [keyserver] add link back to original warpcast cast in farcaster bot sidebar source message.
will updated the diff for D13855: [keyserver] add link back to original warpcast cast in farcaster bot sidebar source message.
review feedback
ashoat requested changes to D13855: [keyserver] add link back to original warpcast cast in farcaster bot sidebar source message.
Line length. Please check this yourself going forward – I don't want to keep having to mention it
varun attached a referenced file: F3122660: Simulator Screen Recording - iPhone 16 Pro Max - 2024-11-01 at 13.49.33.mp4.
Please update the test plan to reflect your recent changes. Would be good to see a video of the whole experience
ashoat requested changes to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
I think it might be confusing to people on the team that fetchThreadInfos used to mean something, but now it means something else