Page MenuHomePhabricator
Feed All Stories

Fri, Nov 1

ashoat requested changes to D13852: [keyserver] new fetchPrivilegedThreadInfos function.

This won't work without addressing the KNOW_OF issue

Fri, Nov 1, 8:32 AM
ashoat added a comment to D13853: [keyserver] add know_of permission if viewer.isScriptViewer.

This is a hacky solution. I don't think it's a good approach

Fri, Nov 1, 8:32 AM

Thu, Oct 31

varun updated the diff for D13493: [native] scaffolding for CommunityJoinerModal.

small fixes

Thu, Oct 31, 11:22 PM
varun added inline comments to D13493: [native] scaffolding for CommunityJoinerModal.
Thu, Oct 31, 11:21 PM
varun added a comment to D13493: [native] scaffolding for CommunityJoinerModal.

fixing the avatars here is tracked in https://linear.app/comm/issue/ENG-9834/get-farcaster-thread-avatars-to-render-correctly-in-new-modals

Thu, Oct 31, 11:18 PM
varun attached a referenced file: F3117719: Simulator Screenshot - iPhone 16 Pro Max - 2024-11-01 at 02.15.52.png.
Thu, Oct 31, 11:17 PM
varun added a comment to D13493: [native] scaffolding for CommunityJoinerModal.

Simulator Screenshot - iPhone 16 Pro Max - 2024-11-01 at 02.15.52.png (2×1 px, 306 KB)

Thu, Oct 31, 11:17 PM
varun added a reviewer for D13853: [keyserver] add know_of permission if viewer.isScriptViewer: ashoat.
Thu, Oct 31, 11:12 PM
varun planned changes to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
Thu, Oct 31, 11:12 PM
varun published D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames for review.
Thu, Oct 31, 11:12 PM
varun planned changes to D13853: [keyserver] add know_of permission if viewer.isScriptViewer.
Thu, Oct 31, 11:11 PM
varun requested review of D13853: [keyserver] add know_of permission if viewer.isScriptViewer.
Thu, Oct 31, 11:04 PM
varun requested review of D13852: [keyserver] new fetchPrivilegedThreadInfos function.
Thu, Oct 31, 10:58 PM
varun requested review of D13851: [keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos.
Thu, Oct 31, 10:57 PM
varun updated the diff for D13493: [native] scaffolding for CommunityJoinerModal.

update modal

Thu, Oct 31, 10:50 PM
ashoat committed rCOMMbce09c171266: [terraform] Bump keyserver image to 1.0.138 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.138
Thu, Oct 31, 12:49 PM
ashoat committed rCOMM45e8f62fa580: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Oct 31, 12:38 PM
ashoat added a reverting change for rCOMMcd92f0842760: [native] Temporary changes for staff release: rCOMM45e8f62fa580: Revert "[native] Temporary changes for staff release".
Thu, Oct 31, 12:38 PM
ashoat committed rCOMM968ae53eecf7: [native] codeVersion -> 434 (authored by ashoat).
[native] codeVersion -> 434
Thu, Oct 31, 12:38 PM
ashoat committed rCOMMcd92f0842760: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Oct 31, 12:38 PM
ashoat committed rCOMM1ba29962798b: [native] codeVersion -> 433 (authored by ashoat).
[native] codeVersion -> 433
Thu, Oct 31, 12:38 PM
ashoat committed rCOMMfe2df6af7cbb: [web][keyserver] codeVersion -> 138 (authored by ashoat).
[web][keyserver] codeVersion -> 138
Thu, Oct 31, 12:38 PM
ashoat committed rCOMM215144be15c0: [keyserver] Update NEXT_CODE_VERSION (authored by ashoat).
[keyserver] Update NEXT_CODE_VERSION
Thu, Oct 31, 12:38 PM
will closed D13785: [keyserver] reply on farcaster with invite link.
Thu, Oct 31, 12:19 PM
will committed rCOMM6f4b8cee79bc: [keyserver] reply on farcaster with invite link (authored by will).
[keyserver] reply on farcaster with invite link
Thu, Oct 31, 12:19 PM
will closed D13784: [lib] add post cast to neynar client.
Thu, Oct 31, 12:19 PM
will closed D13783: [keyserver] create invite link based on newly created sidebar.
Thu, Oct 31, 12:19 PM
will committed rCOMMdb09962901fb: [keyserver] create invite link based on newly created sidebar (authored by will).
[keyserver] create invite link based on newly created sidebar
Thu, Oct 31, 12:19 PM
will closed D13782: [keyserver] create message and sidebar based on cast.
Thu, Oct 31, 12:19 PM
will committed rCOMMe2c7376fd405: [lib] add post cast to neynar client (authored by will).
[lib] add post cast to neynar client
Thu, Oct 31, 12:19 PM
will committed rCOMM65ca88236580: [keyserver] create message and sidebar based on cast (authored by will).
[keyserver] create message and sidebar based on cast
Thu, Oct 31, 12:19 PM
will closed D13815: [keyserver] check if viewer role is positive for updateThread.
Thu, Oct 31, 12:19 PM
will closed D13775: [keyserver] add community creation logic to farcaster webhook responder.
Thu, Oct 31, 12:19 PM
will committed rCOMM360d7061a36b: [keyserver] check if viewer role is positive for updateThread (authored by will).
[keyserver] check if viewer role is positive for updateThread
Thu, Oct 31, 12:19 PM
will closed D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.
Thu, Oct 31, 12:19 PM
will committed rCOMM818349ebd001: [keyserver] add community creation logic to farcaster webhook responder (authored by will).
[keyserver] add community creation logic to farcaster webhook responder
Thu, Oct 31, 12:19 PM
will committed rCOMM18fbb1159924: [keyserver] Run num admin change checks in updateRole only if intended role is… (authored by will).
[keyserver] Run num admin change checks in updateRole only if intended role is…
Thu, Oct 31, 12:19 PM
will closed D13833: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRole.
Thu, Oct 31, 12:19 PM
will committed rCOMM8af524910694: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for… (authored by will).
[keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for…
Thu, Oct 31, 12:19 PM
will closed D13832: [keyserver] do not filter by role in fetchCommunityInfos calls for script viewers.
Thu, Oct 31, 12:19 PM
will committed rCOMMd395d144ab4c: [keyserver] do not filter by role in fetchCommunityInfos calls for script… (authored by will).
[keyserver] do not filter by role in fetchCommunityInfos calls for script…
Thu, Oct 31, 12:19 PM
will closed D13811: [keyserver] add function to grab comm userID for given fid if on keyserver.
Thu, Oct 31, 12:19 PM
will closed D13781: [keyserver] add comm config for authoritative facaster bot boolean variable.
Thu, Oct 31, 12:19 PM
will closed D13819: [keyserver] add the addViewerAsGhost option to createThread.
Thu, Oct 31, 12:19 PM
will committed rCOMM2ba2879020f9: [keyserver] add comm config for authoritative facaster bot boolean variable (authored by will).
[keyserver] add comm config for authoritative facaster bot boolean variable
Thu, Oct 31, 12:19 PM
will committed rCOMM53a7aa8f514e: [keyserver] add the addViewerAsGhost option to createThread (authored by will).
[keyserver] add the addViewerAsGhost option to createThread
Thu, Oct 31, 12:19 PM
will committed rCOMM2d0616b88268: [keyserver] add function to grab comm userID for given fid if on keyserver (authored by will).
[keyserver] add function to grab comm userID for given fid if on keyserver
Thu, Oct 31, 12:19 PM
will closed D13774: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator.
Thu, Oct 31, 12:19 PM
will closed D13773: [keyserver] return status code from blob download function.
Thu, Oct 31, 12:19 PM
will committed rCOMM7fe438a0da72: [keyserver] return status code from blob download function (authored by will).
[keyserver] return status code from blob download function
Thu, Oct 31, 12:19 PM
will committed rCOMM4204d20c64d4: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with… (authored by will).
[keyserver] implemented FarcasterChannelTagBlob type for upload payload with…
Thu, Oct 31, 12:19 PM
will closed D13762: [lib] implement fetchFarcasterCastByHash for neynar client.
Thu, Oct 31, 12:18 PM
will committed rCOMM429176c4d843: [lib] implement fetchFarcasterCastByHash for neynar client (authored by will).
[lib] implement fetchFarcasterCastByHash for neynar client
Thu, Oct 31, 12:18 PM
will closed D13756: [keyserver] verify webhook event with webhook secret.
Thu, Oct 31, 12:18 PM
will closed D13755: [keyserver] moving getting neynar config to function.
Thu, Oct 31, 12:18 PM
will committed rCOMM7166879e117a: [keyserver] verify webhook event with webhook secret (authored by will).
[keyserver] verify webhook event with webhook secret
Thu, Oct 31, 12:18 PM
will committed rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function (authored by will).
[keyserver] moving getting neynar config to function
Thu, Oct 31, 12:18 PM
will closed D13754: [keyserver] accept webhook cast created events tagging comm.
Thu, Oct 31, 12:18 PM
will closed D13841: [keyserver] add regex #createathread check.
Thu, Oct 31, 12:18 PM
will committed rCOMMccb5664fb0dd: [keyserver] accept webhook cast created events tagging comm (authored by will).
[keyserver] accept webhook cast created events tagging comm
Thu, Oct 31, 12:18 PM
will committed rCOMMd2f70e0fe779: [keyserver] add regex #createathread check (authored by will).
[keyserver] add regex #createathread check
Thu, Oct 31, 12:18 PM
will closed D13701: [keyserver] add signer_uuid and neynar webhook secret.
Thu, Oct 31, 12:18 PM
will committed rCOMM4628129f5d87: [keyserver] add signer_uuid and neynar webhook secret (authored by will).
[keyserver] add signer_uuid and neynar webhook secret
Thu, Oct 31, 12:18 PM
will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.
Thu, Oct 31, 12:07 PM
will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

rebase before landing

Thu, Oct 31, 11:58 AM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

rebase

Thu, Oct 31, 11:48 AM
will added inline comments to D13774: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator.
Thu, Oct 31, 11:44 AM
ashoat closed D13831: [lib] Fetch older messages when showInMessagePreview rejects messages in local store.
Thu, Oct 31, 11:38 AM
ashoat committed rCOMMed21b47bc85e: [lib] Fetch older messages when showInMessagePreview rejects messages in local… (authored by ashoat).
[lib] Fetch older messages when showInMessagePreview rejects messages in local…
Thu, Oct 31, 11:38 AM
ashoat closed D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.
Thu, Oct 31, 11:38 AM
ashoat closed D13827: [lib] Introduce MessageSpec.showInMessagePreview.
Thu, Oct 31, 11:38 AM
ashoat committed rCOMMa54049acc670: [lib][native][web] Ignore showInMessagePreview if no messages found (authored by ashoat).
[lib][native][web] Ignore showInMessagePreview if no messages found
Thu, Oct 31, 11:38 AM
ashoat closed D13826: [lib] Fetch message to preview from MessagePreview.
Thu, Oct 31, 11:38 AM
ashoat committed rCOMM726d17a73e0f: [lib] Introduce MessageSpec.showInMessagePreview (authored by ashoat).
[lib] Introduce MessageSpec.showInMessagePreview
Thu, Oct 31, 11:38 AM
ashoat committed rCOMMd436a37a6e69: [lib] Fetch message to preview from MessagePreview (authored by ashoat).
[lib] Fetch message to preview from MessagePreview
Thu, Oct 31, 11:38 AM
ashoat closed D13825: [native] Handle rendering "No messages" inside MessagePreview.
Thu, Oct 31, 11:38 AM
ashoat committed rCOMM2d8f294a5d38: [native] Handle rendering "No messages" inside MessagePreview (authored by ashoat).
[native] Handle rendering "No messages" inside MessagePreview
Thu, Oct 31, 11:38 AM
ashoat closed D13823: [lib][web] Introduce useCreateChatThreadItem.
Thu, Oct 31, 11:38 AM
ashoat closed D13824: [lib] Inline createChatThreadItem.
Thu, Oct 31, 11:38 AM
ashoat committed rCOMMfd009c90168e: [lib] Inline createChatThreadItem (authored by ashoat).
[lib] Inline createChatThreadItem
Thu, Oct 31, 11:38 AM
ashoat committed rCOMMa2be3e24f9a3: [lib][web] Introduce useCreateChatThreadItem (authored by ashoat).
[lib][web] Introduce useCreateChatThreadItem
Thu, Oct 31, 11:38 AM
ashoat closed D13822: [web] Convert activeChatThreadItem to a hook.
Thu, Oct 31, 11:38 AM
ashoat closed D13821: [lib] Inline getChatThreadItems.
Thu, Oct 31, 11:38 AM
ashoat committed rCOMMcad0197a05f5: [web] Convert activeChatThreadItem to a hook (authored by ashoat).
[web] Convert activeChatThreadItem to a hook
Thu, Oct 31, 11:38 AM
ashoat committed rCOMM43fefb0fa3a7: [lib] Inline getChatThreadItems (authored by ashoat).
[lib] Inline getChatThreadItems
Thu, Oct 31, 11:38 AM
ashoat closed D13820: [lib] Remove chatListData.
Thu, Oct 31, 11:38 AM
ashoat committed rCOMM799c4bba79ed: [lib] Remove chatListData (authored by ashoat).
[lib] Remove chatListData
Thu, Oct 31, 11:38 AM
will updated the diff for D13841: [keyserver] add regex #createathread check.

move regex to top level

Thu, Oct 31, 11:37 AM
ashoat updated the diff for D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.

Avoid unnecessary second pass

Thu, Oct 31, 11:33 AM
ashoat updated the summary of D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.
Thu, Oct 31, 11:33 AM
ashoat added inline comments to D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.
Thu, Oct 31, 11:32 AM
will added inline comments to D13841: [keyserver] add regex #createathread check.
Thu, Oct 31, 11:29 AM
ashoat updated the diff for D13823: [lib][web] Introduce useCreateChatThreadItem.

Rebase

Thu, Oct 31, 11:25 AM
ashoat added inline comments to D13822: [web] Convert activeChatThreadItem to a hook.
Thu, Oct 31, 11:24 AM
ashoat updated the diff for D13822: [web] Convert activeChatThreadItem to a hook.

Reuse useChatThreadItem

Thu, Oct 31, 11:23 AM
kamil accepted D13845: [lib] Delete remove members spec.
Thu, Oct 31, 11:03 AM
ashoat accepted D13841: [keyserver] add regex #createathread check.
Thu, Oct 31, 10:44 AM
will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

use eventChannel from prior diff instead of event.data.channel

Thu, Oct 31, 10:22 AM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

add channel to deconstruct

Thu, Oct 31, 10:20 AM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

rebase

Thu, Oct 31, 10:15 AM