Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Thu, Oct 31

will updated the diff for D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.

rebase

Thu, Oct 31, 10:14 AM

tomek requested review of D13848: [lib] Propagate thread infos to the notifs generating code.

Thu, Oct 31, 10:11 AM

will updated the diff for D13841: [keyserver] add regex #createathread check.

word boundry fix

Thu, Oct 31, 10:09 AM

tomek requested review of D13843: [lib] Merge generating notifs data with processing operations.

Thu, Oct 31, 10:03 AM

tomek requested review of D13845: [lib] Delete remove members spec.

Thu, Oct 31, 9:56 AM

ashoat closed D13835: [lib][native][web] Stop running ID schema migration on notifs.

Thu, Oct 31, 9:49 AM

ashoat committed rCOMMc5489b0b75f3: [lib][native][web] Stop running ID schema migration on notifs (authored by ashoat).

[lib][native][web] Stop running ID schema migration on notifs

Thu, Oct 31, 9:49 AM

ashoat added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.

Thu, Oct 31, 9:48 AM

will updated the diff for D13841: [keyserver] add regex #createathread check.

use regex with word boundries

Thu, Oct 31, 9:48 AM

will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.

Thu, Oct 31, 9:36 AM

tomek added a comment to D13842: [lib] Tighten utils type to contain only thick threads.

Created https://linear.app/comm/issue/ENG-9826/validate-the-ids-from-the-dm-operations to track the validation and assigned it to the cycle.

Thu, Oct 31, 9:34 AM

will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

rebase and add destruction syntax for code clarity

Thu, Oct 31, 9:25 AM

will updated the diff for D13841: [keyserver] add regex #createathread check.

use .includes instead of regex

Thu, Oct 31, 9:16 AM

will planned changes to D13841: [keyserver] add regex #createathread check.

Thinking about this. I think we should likely go with a non-regex solution as this is such a simple check. Going to change in next rebase

Thu, Oct 31, 9:09 AM

kamil added inline comments to D13847: [native] update Secondary Device Auth flow to support SIWE users.

Thu, Oct 31, 9:03 AM

kamil published D13850: [native_rust_library] remove `backupID` from `SIWEBackupData` for review.

Thu, Oct 31, 8:57 AM

kamil published D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier for review.

Thu, Oct 31, 8:57 AM

kamil published D13847: [native] update Secondary Device Auth flow to support SIWE users for review.

Thu, Oct 31, 8:54 AM

kamil published D13846: [CommCoreModule][native_rust_library] deprecate SIWE related backup code for review.

Thu, Oct 31, 8:53 AM

kamil published D13844: [native] unify username and wallet backup restore for review.

Thu, Oct 31, 8:52 AM

kamil published D13840: [backup-client] make `backupID` mandatory when restoring backup for review.

Thu, Oct 31, 8:51 AM

kamil published D13839: [native] make it possible to test retrieving latest backup info for review.

Thu, Oct 31, 8:50 AM

kamil published D13838: [CommCoreModule] expose method to retrieve latest backup info for review.

Thu, Oct 31, 8:48 AM

kamil published D13837: [native_rust_library] implement method to retrieve latest backup info for review.

Thu, Oct 31, 8:48 AM

kamil published D13836: [backup-client] refactor `SIWEBackupData` type for review.

Thu, Oct 31, 8:46 AM

kamil accepted D13835: [lib][native][web] Stop running ID schema migration on notifs.

Thu, Oct 31, 8:40 AM

ashoat added a comment to D13842: [lib] Tighten utils type to contain only thick threads.

Makes sense to me!

Thu, Oct 31, 8:29 AM

tomek added a comment to D13842: [lib] Tighten utils type to contain only thick threads.

In D13842#386643, @ashoat wrote:

This diff introduces a new risk - an attacker can create a new thread with the same ID as an existing thin thread. Not sure how useful this attack could be. Protecting against it is handled in https://linear.app/comm/issue/ENG-9468/introduce-additional-validation-of-operations.

I'm a bit skeptical about introducing this regression. The task you linked is unlikely to be prioritized anytime soon.

Thu, Oct 31, 8:27 AM

ashoat added a comment to D13842: [lib] Tighten utils type to contain only thick threads.

This diff introduces a new risk - an attacker can create a new thread with the same ID as an existing thin thread. Not sure how useful this attack could be. Protecting against it is handled in https://linear.app/comm/issue/ENG-9468/introduce-additional-validation-of-operations.

Thu, Oct 31, 8:24 AM

tomek requested review of D13842: [lib] Tighten utils type to contain only thick threads.

Thu, Oct 31, 8:17 AM

will added a comment to D13841: [keyserver] add regex #createathread check.

In D13841#386565, @ashoat wrote:

Do we really need a RegExp if we're just checking if the string contains another string?

Maybe the best argument for RegExp would be if we're trying to match on word boundaries.

Thu, Oct 31, 7:41 AM

ashoat added a comment to D13841: [keyserver] add regex #createathread check.

Do we really need a RegExp if we're just checking if the string contains another string?

Thu, Oct 31, 7:29 AM

will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

rebase

Thu, Oct 31, 7:19 AM

will published D13841: [keyserver] add regex #createathread check for review.

Thu, Oct 31, 7:17 AM

will updated the summary of D13755: [keyserver] moving getting neynar config to function.

Thu, Oct 31, 7:16 AM

tomek accepted D13831: [lib] Fetch older messages when showInMessagePreview rejects messages in local store.

This approach sounds dangerous because it can potentially result in fetching a huge number of messages into memory. However, the scenario in which that could happen is almost impossible.

Thu, Oct 31, 6:15 AM

tomek accepted D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.

Thu, Oct 31, 6:12 AM

will added inline comments to D13782: [keyserver] create message and sidebar based on cast.

Thu, Oct 31, 6:10 AM

ashoat added inline comments to D13826: [lib] Fetch message to preview from MessagePreview.

Thu, Oct 31, 6:09 AM

will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

remove trimText code duplication with sidebar thread name function

Thu, Oct 31, 6:06 AM

tomek accepted D13829: [lib] Hide membership robotext from MessagePreview in thin threads.

Thu, Oct 31, 6:06 AM

will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

address nit

Thu, Oct 31, 6:00 AM

tomek accepted D13828: [lib] Only show reactions to viewer's messages in MessagePreview.

Thu, Oct 31, 5:57 AM

tomek accepted D13827: [lib] Introduce MessageSpec.showInMessagePreview.

Thu, Oct 31, 5:56 AM

tomek accepted D13826: [lib] Fetch message to preview from MessagePreview.

Thu, Oct 31, 5:51 AM

tomek accepted D13825: [native] Handle rendering "No messages" inside MessagePreview.

Thu, Oct 31, 5:37 AM

tomek accepted D13824: [lib] Inline createChatThreadItem.

Thu, Oct 31, 5:35 AM

tomek accepted D13823: [lib][web] Introduce useCreateChatThreadItem.

Thu, Oct 31, 5:34 AM

tomek accepted D13822: [web] Convert activeChatThreadItem to a hook.

Thu, Oct 31, 5:26 AM

tomek accepted D13821: [lib] Inline getChatThreadItems.

Thu, Oct 31, 5:22 AM

tomek accepted D13820: [lib] Remove chatListData.

Thu, Oct 31, 5:21 AM

Wed, Oct 30

ashoat accepted D13785: [keyserver] reply on farcaster with invite link.

Wed, Oct 30, 7:11 PM

will updated the diff for D13783: [keyserver] create invite link based on newly created sidebar.

rebase

Wed, Oct 30, 7:10 PM

will added inline comments to D13785: [keyserver] reply on farcaster with invite link.

Wed, Oct 30, 7:05 PM

will added inline comments to D13785: [keyserver] reply on farcaster with invite link.

Wed, Oct 30, 7:02 PM

will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

feedback

Wed, Oct 30, 7:01 PM

will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

rebase

Wed, Oct 30, 6:36 PM

ashoat accepted D13775: [keyserver] add community creation logic to farcaster webhook responder.

Wed, Oct 30, 6:35 PM

will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.

Wed, Oct 30, 6:12 PM

will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

review feedback

Wed, Oct 30, 6:10 PM

ashoat requested review of D13835: [lib][native][web] Stop running ID schema migration on notifs.

Wed, Oct 30, 2:59 PM

ashoat requested changes to D13785: [keyserver] reply on farcaster with invite link.

Wed, Oct 30, 2:56 PM

ashoat added inline comments to D13783: [keyserver] create invite link based on newly created sidebar.

Wed, Oct 30, 2:53 PM

ashoat requested changes to D13775: [keyserver] add community creation logic to farcaster webhook responder.

Wed, Oct 30, 2:50 PM

ashoat accepted D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.

Wed, Oct 30, 2:41 PM

ashoat accepted D13833: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRole.

Wed, Oct 30, 2:40 PM

ashoat accepted D13832: [keyserver] do not filter by role in fetchCommunityInfos calls for script viewers.

Wed, Oct 30, 2:40 PM

ashoat accepted D13782: [keyserver] create message and sidebar based on cast.

Wed, Oct 30, 2:39 PM

will retitled D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin from [keyserver] Run num admin change checks in updateRole only if request is not by an admin to [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.

Wed, Oct 30, 2:18 PM

will added inline comments to D13784: [lib] add post cast to neynar client.

Wed, Oct 30, 1:52 PM

will updated the diff for D13784: [lib] add post cast to neynar client.

fix nit

Wed, Oct 30, 1:52 PM

will requested review of D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.

Wed, Oct 30, 1:47 PM

will added inline comments to D13783: [keyserver] create invite link based on newly created sidebar.

Wed, Oct 30, 1:47 PM

will updated the diff for D13815: [keyserver] check if viewer role is positive for updateThread.

remove as

Wed, Oct 30, 1:46 PM

will added inline comments to D13815: [keyserver] check if viewer role is positive for updateThread.

Wed, Oct 30, 1:45 PM

will updated the diff for D13754: [keyserver] accept webhook cast created events tagging comm.

rebase

Wed, Oct 30, 1:41 PM

will updated the diff for D13756: [keyserver] verify webhook event with webhook secret.

rebase

Wed, Oct 30, 1:40 PM

ashoat requested review of D13827: [lib] Introduce MessageSpec.showInMessagePreview.

Wed, Oct 30, 1:40 PM

will requested review of D13833: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRole.

Wed, Oct 30, 1:36 PM

will added inline comments to D13756: [keyserver] verify webhook event with webhook secret.

Wed, Oct 30, 1:34 PM

will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.

Wed, Oct 30, 1:31 PM

will requested review of D13832: [keyserver] do not filter by role in fetchCommunityInfos calls for script viewers.

Wed, Oct 30, 1:28 PM

will added inline comments to D13785: [keyserver] reply on farcaster with invite link.

Wed, Oct 30, 1:26 PM

will updated the test plan for D13785: [keyserver] reply on farcaster with invite link.

Wed, Oct 30, 1:24 PM

will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

review feedback and changes

Wed, Oct 30, 1:23 PM

will updated the summary of D13782: [keyserver] create message and sidebar based on cast.

Wed, Oct 30, 1:22 PM

ashoat requested review of D13831: [lib] Fetch older messages when showInMessagePreview rejects messages in local store.

Wed, Oct 30, 1:20 PM

will added inline comments to D13782: [keyserver] create message and sidebar based on cast.

Wed, Oct 30, 1:19 PM

will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

accidentally left a console.log

Wed, Oct 30, 1:18 PM

will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

feedback and rebase

Wed, Oct 30, 1:16 PM

will added inline comments to D13782: [keyserver] create message and sidebar based on cast.

Wed, Oct 30, 1:16 PM

ashoat requested review of D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.

Wed, Oct 30, 1:12 PM

will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

feedback and rebase

Wed, Oct 30, 1:07 PM

will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.

Wed, Oct 30, 1:07 PM

ashoat requested review of D13829: [lib] Hide membership robotext from MessagePreview in thin threads.

Wed, Oct 30, 1:05 PM

ashoat requested review of D13828: [lib] Only show reactions to viewer's messages in MessagePreview.

Wed, Oct 30, 12:57 PM

ashoat requested review of D13826: [lib] Fetch message to preview from MessagePreview.

Wed, Oct 30, 12:32 PM

ashoat requested review of D13825: [native] Handle rendering "No messages" inside MessagePreview.

Wed, Oct 30, 12:24 PM

ashoat requested review of D13824: [lib] Inline createChatThreadItem.

Wed, Oct 30, 12:16 PM

ashoat requested review of D13823: [lib][web] Introduce useCreateChatThreadItem.

Wed, Oct 30, 12:08 PM