Abandoning this diff. We're going with the approach introduced in https://phab.comm.dev/D13819 where commbot is added as a ghost
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Wed, Oct 30
Wed, Oct 30
will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.
[terraform] bump prod identity to 0.44
Abandoning with new approach in setting the viewer as a ghost
kamil published D13808: [backup-service][backup-client] rename `username` -> `user_identifier` for review.
kamil published D13807: [backup-service] use `username` instead of `userID` when downloading backup for review.
kamil published D13817: [docker-compose] configure Identity endpoint for backup in commtest for review.
kamil published D13803: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib` for review.
[lib] SyncCommunityStoreHandler
angelika committed rCOMM9360b1f7fff5: [lib] Wait with processing inbound messages for Tunnelbroker connection (authored by angelika).
[lib] Wait with processing inbound messages for Tunnelbroker connection
angelika committed rCOMMb51dd5e5ad70: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read (authored by angelika).
[lib] Make sure PeerToPeerMessageHandler is run after persisted state is read
angelika committed rCOMM93fb2e536ff6: [lib] Add `canProcess` parameter to `useActionsQueue` (authored by angelika).
[lib] Add `canProcess` parameter to `useActionsQueue`
angelika committed rCOMMe2ed1f3642f5: [lib] Move usePersistedStateLoaded() to lib package (authored by angelika).
[lib] Move usePersistedStateLoaded() to lib package
angelika added a comment to D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
In D13802#386045, @ashoat wrote:You can't update the commit message with arc diff. Instead, you should edit the revision on Phabricator, and then run arc amend locally to update the commit text based on what's on Phabricator. (I think this last step also gets run automatically as part of arc land.)
ashoat added a comment to D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
You can't update the commit message with arc diff. Instead, you should edit the revision on Phabricator, and then run arc amend locally to update the commit text based on what's on Phabricator. (I think this last step also gets run automatically as part of arc land.)
angelika updated the diff for D13792: [lib] Wait with processing inbound messages for Tunnelbroker connection.
Update commit message
angelika updated the diff for D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
Update commit message
kamil added inline comments to D13792: [lib] Wait with processing inbound messages for Tunnelbroker connection.
ashoat added inline comments to D13792: [lib] Wait with processing inbound messages for Tunnelbroker connection.
kamil added 1 blocking reviewer(s) for D13814: [lib] Add `canProcess` parameter to `useActionsQueue`: tomek.
Actually, would like to have @tomek opinion too
Tue, Oct 29
Tue, Oct 29
will abandoned D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
Abandoning. We're no longer planning to override permissions
address feedback
will added inline comments to D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
will added inline comments to D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
See feedback in D13812 – we wouldn't need to remove commbot if we never add them to the thread
ashoat added inline comments to D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
angelika updated the summary of D13792: [lib] Wait with processing inbound messages for Tunnelbroker connection.
angelika updated the summary of D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
angelika updated the diff for D13792: [lib] Wait with processing inbound messages for Tunnelbroker connection.
Rebase and implement requested changes
angelika updated the diff for D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
Rebase and implement requested changes
Rebase
There’s a risk here that if a community root ends up in the thread store, but its keyserver isn’t returning it when queried here, then we could end up querying over and over. Can you make sure that we only trigger a query once for each ID? We have something similar in UserInfosHandler: https://github.com/CommE2E/comm/blob/603f6924736f20014f39c6b57dffe4e39c9ba7d4/lib/handlers/user-infos-handler.react.js#L43
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
will planned changes to D13775: [keyserver] add community creation logic to farcaster webhook responder.
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.
rebase and review feedback
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
undo debounce, which didn't seem to work as expected
debounce fetch community infos
angelika committed rCOMM603f6924736f: [lib] Close tunnelbroker socket when app is in background (authored by angelika).
[lib] Close tunnelbroker socket when app is in background
will updated the diff for D13811: [keyserver] add function to grab comm userID for given fid if on keyserver.
review feedback
angelika committed rCOMMba0f863b53c4: [lib] Add staff alert for decryption related errors (authored by angelika).
[lib] Add staff alert for decryption related errors
[lib] Factor out useStaffAlert()
varun added inline comments to D13811: [keyserver] add function to grab comm userID for given fid if on keyserver.
var startTime = performance.now()
will published D13811: [keyserver] add function to grab comm userID for given fid if on keyserver for review.
will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.
ashoat committed rCOMMb66626ca8b8a: [native] Add loading button state to CreateSIWEBackupMessageBase (authored by ashoat).
[native] Add loading button state to CreateSIWEBackupMessageBase
ashoat committed rCOMM7c5ae6377226: [lib][keyserver][native] Stop sending passwords to authoritative keyserver on… (authored by ashoat).
[lib][keyserver][native] Stop sending passwords to authoritative keyserver on…
ashoat requested review of D13804: [native] Add loading button state to CreateSIWEBackupMessageBase.
kamil requested changes to D13792: [lib] Wait with processing inbound messages for Tunnelbroker connection.
I would prefer a slightly different approach, where we could read Inbound messages and add them to the queue, there is no point in deffering this - but instead wait with actual processing, to achieve that we might need to modify useActionsQueue to be able to conditionally start processing, what do you think?
ashoat accepted D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
Makes sense, thanks for explaining!
angelika added a comment to D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
In D13802#385659, @ashoat wrote:Question about the test plan:
After this patch there should be less of them
Did some of errors still appear? What's your theory for why that is?
In D13793#385651, @tomek wrote:This implementation has a performance consequence - in the original implementation, we were only stringifying when an alert was shown. Now we're stringifying the object even for users who will never see an alert. We could consider keeping the JSON.stringify inside showAlertToStaff, but I'm not sure if it is really that important.