Question about the test plan:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Tue, Oct 29
Tue, Oct 29
ashoat added a comment to D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.
I think it would've been easier to review this one if you had broken it down further: one diff that renames storeLoaded to initialStateLoaded on native, and another that does the rest
This implementation has a performance consequence - in the original implementation, we were only stringifying when an alert was shown. Now we're stringifying the object even for users who will never see an alert. We could consider keeping the JSON.stringify inside showAlertToStaff, but I'm not sure if it is really that important.
Mon, Oct 28
Mon, Oct 28
will updated subscribers of D13774: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator.
will added inline comments to D13781: [keyserver] add comm config for authoritative facaster bot boolean variable.
will updated the diff for D13781: [keyserver] add comm config for authoritative facaster bot boolean variable.
review feedback
Rebase
Remove showOperationAlertToStaff
move getNeynarConfig to own file
feedback
ashoat committed rCOMM5b1ddea9fbe3: [landing] Remove invalid size prop in TeamProfile (authored by ashoat).
[landing] Remove invalid size prop in TeamProfile
[landing] Bump GitHub link to the front
ashoat committed rCOMM7096f8594f92: [landing] Add Farcaster link to team profiles (authored by ashoat).
[landing] Add Farcaster link to team profiles
[landing] Add Farcaster link to header
[landing] Update team page
In D13795#385497, @varun wrote:I don’t see the screenshot but JSX looks right
I don’t see the screenshot but JSX looks right
[terraform] bump staging identity to 0.44
I didn't notice any issues, but I'm not very familiar with this logic – would appreciate if @kamil could also take a look
Revert actions queue change
Finally
Readonly
Simplify the queueing code. This revision still has an issue where leaving a thread casues an exception while sending the notifs. Regardless, it is an improvement comparing to the master, because it fixes sending messages in quick succession. The notifs issue will be fixed in the next diff.
Sun, Oct 27
Sun, Oct 27
Oct 25 2024
Oct 25 2024
angelika requested review of D13792: [lib] Wait with processing inbound messages for Tunnelbroker connection.
varun committed rCOMM9644fafebfb1: [identity] bump native min supported version and add web min supported version (authored by varun).
[identity] bump native min supported version and add web min supported version
varun committed rCOMM7fa23109af41: [lib] reduce thread updates from createOrUpdateFarcasterChannelTag and… (authored by varun).
[lib] reduce thread updates from createOrUpdateFarcasterChannelTag and…
varun committed rCOMM5ca379f72a5c: reset avatar when deleteFarcasterChannelTag is called (authored by varun).
reset avatar when deleteFarcasterChannelTag is called
varun committed rCOMMe97081be5b6f: set farcaster avatar and channel description in db during… (authored by varun).
set farcaster avatar and channel description in db during…
varun updated the diff for D13788: [lib] reduce thread updates from createOrUpdateFarcasterChannelTag and deleteFarcasterChannelTag.
we do want to reduce the messages too
Oct 24 2024
Oct 24 2024
ashoat committed rCOMM89b1635c297c: [terraform] Bump keyserver image to 1.0.137 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.137
ashoat committed rCOMMeff42f9f24b3: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
[native] codeVersion -> 432
ashoat committed rCOMM971e67f4d4d4: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
[native] codeVersion -> 431
[web][keyserver] codeVersion -> 137
ashoat committed rCOMM82f71c892c56: [keyserver][landing] Fix reset preamble for landing SIWE (authored by ashoat).
[keyserver][landing] Fix reset preamble for landing SIWE
ashoat added inline comments to D13778: set farcaster avatar and channel description in db during createOrUpdateFarcasterChannelTag.
varun added inline comments to D13778: set farcaster avatar and channel description in db during createOrUpdateFarcasterChannelTag.
ashoat requested changes to D13788: [lib] reduce thread updates from createOrUpdateFarcasterChannelTag and deleteFarcasterChannelTag.
I looked at the type of ChangeThreadSettingsResult. It has two properties, one of which is newMessageInfos.
varun added inline comments to D13778: set farcaster avatar and channel description in db during createOrUpdateFarcasterChannelTag.
address feedback
varun updated the diff for D13778: set farcaster avatar and channel description in db during createOrUpdateFarcasterChannelTag.
address feedback
[native] Fix sending videos on iOS 18
[keyserver] Delete invalid invite links