Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (129 w, 4 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Today

bartek published D14501: [identity] Skip keyserver during primary logout and restore for review.
Tue, Mar 25, 7:45 AM
bartek published D14500: [identity] Refactor devices data deletion to allow filtering for review.
Tue, Mar 25, 7:44 AM
bartek published D14499: [identity] Fix OTK removal in clean_up_devices_data for review.
Tue, Mar 25, 7:43 AM
bartek published D14498: [identity] Split OTK deletion into smaller functions for review.
Tue, Mar 25, 7:43 AM
bartek published D14497: [identity] Allow excluding devices in CSAT deletion func for review.
Tue, Mar 25, 7:43 AM
bartek published D14496: [identity] Make function names more accurate for review.
Tue, Mar 25, 7:41 AM

Yesterday

bartek closed D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo.
Mon, Mar 24, 6:55 AM
bartek committed rCOMM598630cb095b: [lib][native] Add keyserverDeviceID to LatestBackupInfo (authored by bartek).
[lib][native] Add keyserverDeviceID to LatestBackupInfo
Mon, Mar 24, 6:55 AM
bartek closed D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mon, Mar 24, 6:55 AM
bartek closed D14466: [grpc-clients] Add helpers for services grpc client.
Mon, Mar 24, 6:55 AM
bartek committed rCOMMbefb888d494e: [backup] Return keyserver device ID in latest backup info endpoint (authored by bartek).
[backup] Return keyserver device ID in latest backup info endpoint
Mon, Mar 24, 6:55 AM
bartek committed rCOMM17fde856cadc: [grpc-clients] Add helpers for services grpc client (authored by bartek).
[grpc-clients] Add helpers for services grpc client
Mon, Mar 24, 6:55 AM
bartek closed D14465: [identity] Support service-to-service token in auth RPCs.
Mon, Mar 24, 6:55 AM
bartek committed rCOMMa241d420bbb6: [identity] Support service-to-service token in auth RPCs (authored by bartek).
[identity] Support service-to-service token in auth RPCs
Mon, Mar 24, 6:55 AM
bartek published D14492: [protos][identity] Remove primary device info from GetKeyserverKeys for review.
Mon, Mar 24, 6:32 AM
bartek updated the diff for D14467: [backup] Return keyserver device ID in latest backup info endpoint.

Add serde rename directive

Mon, Mar 24, 6:08 AM
bartek added inline comments to D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mon, Mar 24, 6:07 AM
bartek added inline comments to D14465: [identity] Support service-to-service token in auth RPCs.
Mon, Mar 24, 6:04 AM
bartek published D14490: [identity] Support tuples in device list verification for review.
Mon, Mar 24, 4:53 AM
bartek published D14491: [native] Add keyserver to device list during restore for review.
Mon, Mar 24, 4:42 AM
bartek published D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo for review.
Mon, Mar 24, 3:41 AM

Sun, Mar 23

bartek added inline comments to D14481: [native] Remove ffmpeg dependency.
Sun, Mar 23, 11:55 PM
bartek published D14467: [backup] Return keyserver device ID in latest backup info endpoint for review.
Sun, Mar 23, 11:51 PM
bartek published D14466: [grpc-clients] Add helpers for services grpc client for review.
Sun, Mar 23, 11:48 PM
bartek published D14465: [identity] Support service-to-service token in auth RPCs for review.
Sun, Mar 23, 11:48 PM
bartek accepted D14470: [ios] Implement getVideoInfo() function on iOS.
Sun, Mar 23, 11:48 PM
bartek accepted D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Looks much cleaner now

Sun, Mar 23, 11:45 PM
bartek requested changes to D14478: [android] Implement transcodeVideo() function on Android.

Requesting changes because of these null checks which might lead to crash

Sun, Mar 23, 11:40 PM

Fri, Mar 21

bartek accepted D14481: [native] Remove ffmpeg dependency.

Wondering how much smaller our binaries will be without ffmpeg 😀

Fri, Mar 21, 8:57 AM
bartek accepted D14479: [ios] Implement transcodeVideo() function on iOS.

Nice work!

Fri, Mar 21, 8:52 AM
bartek accepted D14487: [ci] Update mac runner image in github workflows.

If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?

Fri, Mar 21, 8:32 AM
bartek added inline comments to D14478: [android] Implement transcodeVideo() function on Android.
Fri, Mar 21, 2:19 AM
bartek accepted D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.
Fri, Mar 21, 2:00 AM
bartek accepted D14476: [ios] Implement generateThumbnail() function on iOS.
Fri, Mar 21, 1:57 AM
bartek accepted D14475: [android] Implement generateThumbnail() function on Android.
Fri, Mar 21, 1:56 AM
bartek accepted D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.
Fri, Mar 21, 1:53 AM
bartek accepted D14473: [ios] Implement hasMultipleFrames() function on iOS.
Fri, Mar 21, 1:52 AM
bartek accepted D14472: [android] Implement hasMultipleFrames() function on Android.
Fri, Mar 21, 1:51 AM
bartek accepted D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.

Looking at this diff, the thing you did with format seems right

Fri, Mar 21, 1:50 AM
bartek added inline comments to D14470: [ios] Implement getVideoInfo() function on iOS.
Fri, Mar 21, 1:48 AM
bartek accepted D14469: [android] Implement getVideoInfo() function on Android.
Fri, Mar 21, 1:42 AM
bartek accepted D14468: [native] Add MediaModule expo module.
Fri, Mar 21, 1:40 AM

Wed, Mar 19

bartek accepted D14464: [keyserver] call `free()` on Olm objects in finally block.
Wed, Mar 19, 11:56 AM
bartek closed D14461: [terraform] Bump staging Identity to 0.51.2.
Wed, Mar 19, 8:46 AM
bartek committed rCOMMd8cd93d28714: [terraform] Bump staging Identity to 0.51.2 (authored by bartek).
[terraform] Bump staging Identity to 0.51.2
Wed, Mar 19, 8:46 AM
bartek published D14461: [terraform] Bump staging Identity to 0.51.2 for review.
Wed, Mar 19, 8:00 AM

Tue, Mar 18

bartek closed D14460: [identity] Verify prekeys in RefreshUserPrekeys RPC.
Tue, Mar 18, 7:07 AM
bartek committed rCOMM42d533bb18be: [identity] Verify prekeys in RefreshUserPrekeys RPC (authored by bartek).
[identity] Verify prekeys in RefreshUserPrekeys RPC
Tue, Mar 18, 7:07 AM
bartek closed D14459: [commtest] Generate valid prekeys with mock Olm account.
Tue, Mar 18, 7:07 AM
bartek committed rCOMM7ae949faf297: [commtest] Generate valid prekeys with mock Olm account (authored by bartek).
[commtest] Generate valid prekeys with mock Olm account
Tue, Mar 18, 7:07 AM
bartek added a comment to D14460: [identity] Verify prekeys in RefreshUserPrekeys RPC.

It might be good to test it on staging before publishing it to prod:

  • trigger PrekeysHandler to test client
  • trigger cron job on keyserver

A test both correct and malformed keys

Tue, Mar 18, 7:05 AM
bartek published D14459: [commtest] Generate valid prekeys with mock Olm account for review.
Tue, Mar 18, 2:50 AM
bartek published D14460: [identity] Verify prekeys in RefreshUserPrekeys RPC for review.
Tue, Mar 18, 2:50 AM

Fri, Mar 14

bartek closed D14432: [native] Move ErrorBoundary inside Identity and Tunnelbroker context.
Fri, Mar 14, 1:58 AM
bartek committed rCOMMc019d4dbe1e7: [native] Move ErrorBoundary inside Identity and Tunnelbroker context (authored by bartek).
[native] Move ErrorBoundary inside Identity and Tunnelbroker context
Fri, Mar 14, 1:58 AM
bartek closed D14431: [native] Remove dangling device after QR auth failure.
Fri, Mar 14, 1:58 AM
bartek committed rCOMMb322cf848bb5: [native] Remove dangling device after QR auth failure (authored by bartek).
[native] Remove dangling device after QR auth failure
Fri, Mar 14, 1:58 AM

Fri, Mar 7

bartek updated the diff for D14431: [native] Remove dangling device after QR auth failure.

Wrap in ignorePromiseRejections

Fri, Mar 7, 1:48 AM

Thu, Mar 6

bartek published D14432: [native] Move ErrorBoundary inside Identity and Tunnelbroker context for review.
Thu, Mar 6, 2:06 AM
bartek published D14431: [native] Remove dangling device after QR auth failure for review.
Thu, Mar 6, 1:26 AM

Wed, Mar 5

bartek closed D14423: [terraform] Bump RabbitMQ engine_version to 3.13.7.
Wed, Mar 5, 11:08 AM
bartek committed rCOMMd2b3b9c85abc: [terraform] Bump RabbitMQ engine_version to 3.13.7 (authored by kamil).
[terraform] Bump RabbitMQ engine_version to 3.13.7
Wed, Mar 5, 11:08 AM
bartek commandeered D14423: [terraform] Bump RabbitMQ engine_version to 3.13.7.
Wed, Mar 5, 11:02 AM

Mon, Mar 3

bartek closed D14428: [terraform] Bump staging services with new CORS config.
Mon, Mar 3, 6:47 AM
bartek committed rCOMM0466b59eda89: [terraform] Bump staging services with new CORS config (authored by bartek).
[terraform] Bump staging services with new CORS config
Mon, Mar 3, 6:47 AM
bartek published D14428: [terraform] Bump staging services with new CORS config for review.
Mon, Mar 3, 2:34 AM
bartek closed D14422: [comm-lib] Add comm.software to CORS config.
Mon, Mar 3, 1:43 AM
bartek committed rCOMMdc964512859e: [comm-lib] Add comm.software to CORS config (authored by bartek).
[comm-lib] Add comm.software to CORS config
Mon, Mar 3, 1:43 AM
bartek accepted D14427: [native] Fix types in navigate call inside ThreadSettingsMediaGallery.
Mon, Mar 3, 1:08 AM
bartek accepted D14426: [native] Allow useIntentionalSaveMedia to be called with messageInfo IDs.
Mon, Mar 3, 1:08 AM

Fri, Feb 28

bartek accepted D14423: [terraform] Bump RabbitMQ engine_version to 3.13.7.
Fri, Feb 28, 5:05 AM
bartek closed D14419: [proto] Add comment about siwe fields being social proof.
Fri, Feb 28, 3:27 AM
bartek committed rCOMM1e9a700a7121: [proto] Add comment about siwe fields being social proof (authored by bartek).
[proto] Add comment about siwe fields being social proof
Fri, Feb 28, 3:27 AM
bartek closed D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.
Fri, Feb 28, 3:27 AM
bartek committed rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC (authored by bartek).
[lib] Handle user_not_found returned by GetKeyserverKeys RPC
Fri, Feb 28, 3:27 AM
bartek closed D14415: [lib][native] Respect login flow in useLogIn and useIdentityLogOut.
Fri, Feb 28, 3:27 AM
bartek committed rCOMMb218da0df38f: [lib][native] Respect login flow in useLogIn and useIdentityLogOut (authored by bartek).
[lib][native] Respect login flow in useLogIn and useIdentityLogOut
Fri, Feb 28, 3:27 AM
bartek published D14422: [comm-lib] Add comm.software to CORS config for review.
Fri, Feb 28, 2:58 AM
bartek added inline comments to D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.
Fri, Feb 28, 12:56 AM

Thu, Feb 27

bartek accepted D14414: [native] Fix copying encrypted images on iOS.

I'm worried about using Clipboard.setImageFromBase64 for large media files... I suspect it will be passing a massive string over the legacy React Native bridge, and so I feel obliged to do some performance testing on that, and I don't have the time to do that for an approach that I suspect might end up not working for us.

Thu, Feb 27, 12:17 PM
bartek published D14419: [proto] Add comment about siwe fields being social proof for review.
Thu, Feb 27, 8:31 AM
bartek published D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC for review.
Thu, Feb 27, 8:30 AM
bartek published D14415: [lib][native] Respect login flow in useLogIn and useIdentityLogOut for review.
Thu, Feb 27, 3:03 AM
bartek closed D14404: [scripts] Script to reset keyserver owner in DDB.
Thu, Feb 27, 2:25 AM
bartek committed rCOMM20e275c76839: [scripts] Script to reset keyserver owner in DDB (authored by bartek).
[scripts] Script to reset keyserver owner in DDB
Thu, Feb 27, 2:25 AM
bartek closed D14403: [nix] Add jq tool to dev shell.
Thu, Feb 27, 2:25 AM
bartek committed rCOMM49223dae4753: [nix] Add jq tool to dev shell (authored by bartek).
[nix] Add jq tool to dev shell
Thu, Feb 27, 2:25 AM
bartek added inline comments to D14404: [scripts] Script to reset keyserver owner in DDB.
Thu, Feb 27, 1:57 AM
bartek updated the diff for D14404: [scripts] Script to reset keyserver owner in DDB.

Invert confirmation prompt logic to make script more error-proof

Thu, Feb 27, 1:56 AM
bartek attached a referenced file: F4398714: Screenshot 2025-02-27 at 10.27.11.png.
Thu, Feb 27, 1:46 AM
bartek accepted D14413: Upgrade to Rust 1.85.

Rust update looks good to me

Thu, Feb 27, 1:46 AM

Wed, Feb 26

bartek accepted D14412: [native] Fall back to v1 login after `use_v1_flow` response.
Wed, Feb 26, 5:46 AM

Tue, Feb 25

bartek updated the diff for D14404: [scripts] Script to reset keyserver owner in DDB.

Add AWS_REGION export, remove check for jq being installed

Tue, Feb 25, 8:10 AM
bartek accepted D14398: [native] disable navigation in `RestoreBackupScreen`.
Tue, Feb 25, 1:28 AM
bartek published D14404: [scripts] Script to reset keyserver owner in DDB for review.
Tue, Feb 25, 1:15 AM
bartek published D14403: [nix] Add jq tool to dev shell for review.
Tue, Feb 25, 1:01 AM

Feb 20 2025

bartek accepted D14393: [native] Wait with registration and restoration for the logout to conclude.
Feb 20 2025, 7:18 AM
bartek closed D14394: [terraform] Bump prod Identity to 0.51.1.
Feb 20 2025, 6:54 AM
bartek committed rCOMMe22a35c3a2b9: [terraform] Bump prod Identity to 0.51.1 (authored by bartek).
[terraform] Bump prod Identity to 0.51.1
Feb 20 2025, 6:54 AM
bartek closed D14392: [terraform] Bump staging Identity to 0.51.1.
Feb 20 2025, 6:54 AM