Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (116 w, 1 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Yesterday

bartek published D14179: [lib] Refactor useLogOut to auto-detect logout flow for review.
Fri, Dec 20, 4:59 AM
bartek published D14178: [terraform] Bump staging Identity to 0.48 for review.
Fri, Dec 20, 12:12 AM
bartek published D14177: [terraform] Bump prod Identity to 0.47 for review.
Fri, Dec 20, 12:12 AM

Thu, Dec 19

bartek closed D14174: [identity] Optimize Tunnelbroker device data removal.
Thu, Dec 19, 11:55 PM
bartek committed rCOMMc44920a6ca59: [identity] Optimize Tunnelbroker device data removal (authored by bartek).
[identity] Optimize Tunnelbroker device data removal
Thu, Dec 19, 11:55 PM
bartek closed D14173: [identity] Force v1 primary logout for authoritative keyserver owner.
Thu, Dec 19, 11:55 PM
bartek committed rCOMM6fd253e5bc1d: [identity] Force v1 primary logout for authoritative keyserver owner (authored by bartek).
[identity] Force v1 primary logout for authoritative keyserver owner
Thu, Dec 19, 11:55 PM
bartek closed D14172: [identity] Allow v1 login for authoritative keyserver.
Thu, Dec 19, 11:55 PM
bartek committed rCOMM58bf345631bc: [identity] Allow v1 login for authoritative keyserver (authored by bartek).
[identity] Allow v1 login for authoritative keyserver
Thu, Dec 19, 11:55 PM
bartek added inline comments to D14173: [identity] Force v1 primary logout for authoritative keyserver owner.
Thu, Dec 19, 11:49 PM
bartek accepted D14171: [native] move `<Auth*` components to a `/auth-components` directory.
Thu, Dec 19, 5:20 AM
bartek accepted D14170: [native] rename `<Registration*` components to `<Auth*` components.
Thu, Dec 19, 5:19 AM
bartek accepted D14169: [native] rename `QRAuthContext` to `PrimaryDeviceQRAuthContext`.
Thu, Dec 19, 5:18 AM
bartek published D14174: [identity] Optimize Tunnelbroker device data removal for review.
Thu, Dec 19, 5:18 AM
bartek published D14173: [identity] Force v1 primary logout for authoritative keyserver owner for review.
Thu, Dec 19, 5:18 AM
bartek accepted D14166: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`.
Thu, Dec 19, 5:17 AM
bartek published D14172: [identity] Allow v1 login for authoritative keyserver for review.
Thu, Dec 19, 2:05 AM
bartek closed D14088: [identity] Verify new flow migration device list update.
Thu, Dec 19, 1:55 AM
bartek committed rCOMMefd40b9457f6: [identity] Verify new flow migration device list update (authored by bartek).
[identity] Verify new flow migration device list update
Thu, Dec 19, 1:55 AM
bartek closed D14148: [native] Handler for migrating to signed device lists.
Thu, Dec 19, 1:55 AM
bartek committed rCOMM94ed0be6468c: [native] Handler for migrating to signed device lists (authored by bartek).
[native] Handler for migrating to signed device lists
Thu, Dec 19, 1:55 AM
bartek updated the diff for D14148: [native] Handler for migrating to signed device lists.

Address comments

Thu, Dec 19, 12:59 AM
bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.
Thu, Dec 19, 12:58 AM
bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.
Thu, Dec 19, 12:43 AM

Tue, Dec 17

bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.
Tue, Dec 17, 2:49 AM
bartek updated the diff for D14148: [native] Handler for migrating to signed device lists.

Address feedback

Tue, Dec 17, 2:45 AM
bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.
Tue, Dec 17, 2:06 AM

Mon, Dec 16

bartek closed D14147: [native][web] Merge logout buttons for old and new flows.
Mon, Dec 16, 6:48 AM
bartek committed rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows (authored by bartek).
[native][web] Merge logout buttons for old and new flows
Mon, Dec 16, 6:48 AM
bartek closed D14146: [native] Enable linked devices screen when using restore flow.
Mon, Dec 16, 6:48 AM
bartek committed rCOMMd0002b3eff79: [native] Enable linked devices screen when using restore flow (authored by bartek).
[native] Enable linked devices screen when using restore flow
Mon, Dec 16, 6:48 AM
bartek added inline comments to D14147: [native][web] Merge logout buttons for old and new flows.
Mon, Dec 16, 6:45 AM
bartek published D14148: [native] Handler for migrating to signed device lists for review.
Mon, Dec 16, 6:18 AM
bartek updated the test plan for D14088: [identity] Verify new flow migration device list update.
Mon, Dec 16, 6:04 AM
bartek published D14088: [identity] Verify new flow migration device list update for review.
Mon, Dec 16, 4:24 AM

Thu, Dec 12

bartek published D14146: [native] Enable linked devices screen when using restore flow for review.
Thu, Dec 12, 11:28 PM
bartek published D14147: [native][web] Merge logout buttons for old and new flows for review.
Thu, Dec 12, 11:28 PM
bartek accepted D14097: [CommCoreModule] avoid triggering backup upload on SQLite changes.
Thu, Dec 12, 12:34 AM

Wed, Dec 11

bartek accepted D14096: [native] make sure `start_backup_handler` is called only once in `BackupHandler`.
Wed, Dec 11, 10:43 PM
bartek accepted D14095: [native_rust_library] make `start_backup_handler` thread-safe.
Wed, Dec 11, 10:40 PM

Mon, Dec 9

bartek added a comment to D14079: [identity] fix `lastPrimarySignature` attribute.

How serious is this issue? Wondering what the product impact was, if any

I think there wasn't any product impact, the first time we used this was during restore protocol, and I added it later in this stack (D14083), I don't think any existing logic depends on this, but perhaps @bartek has a better view on this.

Mon, Dec 9, 1:42 AM

Fri, Dec 6

bartek closed D14087: [identity] Reset device list and services data during password reset.
Fri, Dec 6, 4:46 AM
bartek committed rCOMMcedacdf005d4: [identity] Reset device list and services data during password reset (authored by bartek).
[identity] Reset device list and services data during password reset
Fri, Dec 6, 4:46 AM
bartek closed D14076: [identity] Update V1 logout to handle new flow users.
Fri, Dec 6, 4:46 AM
bartek committed rCOMM312165799170: [identity] Update V1 logout to handle new flow users (authored by bartek).
[identity] Update V1 logout to handle new flow users
Fri, Dec 6, 4:46 AM
bartek closed D14075: [identity] Return use_v1_flow in new-flow-only RPCs.
Fri, Dec 6, 4:46 AM
bartek closed D14073: [identity] Add function to check user login flow.
Fri, Dec 6, 4:46 AM
bartek closed D14074: [identity] Return use_new_flow in V1 login RPCs.
Fri, Dec 6, 4:46 AM
bartek committed rCOMMd91394b8f101: [identity] Return use_v1_flow in new-flow-only RPCs (authored by bartek).
[identity] Return use_v1_flow in new-flow-only RPCs
Fri, Dec 6, 4:46 AM
bartek committed rCOMM8944ea4f6bfa: [identity] Add function to check user login flow (authored by bartek).
[identity] Add function to check user login flow
Fri, Dec 6, 4:46 AM
bartek committed rCOMMa8129cf7fd19: [identity] Return use_new_flow in V1 login RPCs (authored by bartek).
[identity] Return use_new_flow in V1 login RPCs
Fri, Dec 6, 4:46 AM
bartek closed D14071: [identity] Remove outdated comment from constants.
Fri, Dec 6, 4:46 AM
bartek closed D14072: [identity] Add function to check if user has backup.
Fri, Dec 6, 4:46 AM
bartek committed rCOMM7877d5b11018: [identity] Remove outdated comment from constants (authored by bartek).
[identity] Remove outdated comment from constants
Fri, Dec 6, 4:46 AM
bartek committed rCOMM88f7830fc53e: [identity] Add function to check if user has backup (authored by bartek).
[identity] Add function to check if user has backup
Fri, Dec 6, 4:46 AM
bartek closed D14078: [native] Memoize logOutOptions.
Fri, Dec 6, 4:45 AM
bartek committed rCOMM58cdeac3bb64: [native] Memoize logOutOptions (authored by bartek).
[native] Memoize logOutOptions
Fri, Dec 6, 4:45 AM
bartek updated the diff for D14076: [identity] Update V1 logout to handle new flow users.

Rebase

Fri, Dec 6, 4:07 AM
bartek updated the diff for D14075: [identity] Return use_v1_flow in new-flow-only RPCs.

Rebase

Fri, Dec 6, 4:06 AM
bartek updated the diff for D14074: [identity] Return use_new_flow in V1 login RPCs.

Rebase

Fri, Dec 6, 4:06 AM
bartek updated the diff for D14073: [identity] Add function to check user login flow.

Add missing changes, apply suggestion

Fri, Dec 6, 4:00 AM
bartek added a comment to D14072: [identity] Add function to check if user has backup.

Generally I think this is not perfect and we could create a dedicated backup service endpoint for this which would query directly by user_id and be callable only by other services

Fri, Dec 6, 3:56 AM
bartek updated the summary of D14087: [identity] Reset device list and services data during password reset.
Fri, Dec 6, 3:50 AM
bartek accepted D14089: [terraform] identity 0.47 staging deployment.
Fri, Dec 6, 2:53 AM
bartek accepted D14081: [lib] add Identity Restore action type.
Fri, Dec 6, 2:30 AM
bartek accepted D14080: [lib] refactor `useClientBackup` to not use user identifier from the store.
Fri, Dec 6, 2:26 AM
bartek published D14087: [identity] Reset device list and services data during password reset for review.
Fri, Dec 6, 2:11 AM
bartek accepted D14079: [identity] fix `lastPrimarySignature` attribute.
Fri, Dec 6, 1:44 AM

Wed, Dec 4

bartek published D14078: [native] Memoize logOutOptions for review.
Wed, Dec 4, 8:09 AM

Tue, Dec 3

bartek published D14076: [identity] Update V1 logout to handle new flow users for review.
Tue, Dec 3, 9:53 AM
bartek accepted D14077: [native] remove comment from `BackupHandler`.
Tue, Dec 3, 9:47 AM
bartek published D14075: [identity] Return use_v1_flow in new-flow-only RPCs for review.
Tue, Dec 3, 9:47 AM
bartek published D14074: [identity] Return use_new_flow in V1 login RPCs for review.
Tue, Dec 3, 9:47 AM
bartek published D14073: [identity] Add function to check user login flow for review.
Tue, Dec 3, 3:58 AM
bartek published D14072: [identity] Add function to check if user has backup for review.
Tue, Dec 3, 3:55 AM
bartek published D14071: [identity] Remove outdated comment from constants for review.
Tue, Dec 3, 3:51 AM
bartek accepted D14065: [native] regenerate backup on every password change.
Tue, Dec 3, 12:29 AM

Fri, Nov 29

bartek closed D14037: [native] Show version unsupported when opened QR screen.
Fri, Nov 29, 5:03 AM
bartek closed D14036: [native][web] Show version unsupported modal when received use_new_flow on logout.
Fri, Nov 29, 5:03 AM
bartek committed rCOMMa9ed6112cc26: [native][web] Show version unsupported modal when received use_new_flow on… (authored by bartek).
[native][web] Show version unsupported modal when received use_new_flow on…
Fri, Nov 29, 5:03 AM
bartek closed D14035: [native] Extract showing version unsupported alert to separate hook.
Fri, Nov 29, 5:03 AM
bartek committed rCOMMce616cfd2327: [native] Show version unsupported when opened QR screen (authored by bartek).
[native] Show version unsupported when opened QR screen
Fri, Nov 29, 5:03 AM
bartek committed rCOMMf848902ef915: [native] Extract showing version unsupported alert to separate hook (authored by bartek).
[native] Extract showing version unsupported alert to separate hook
Fri, Nov 29, 5:03 AM
bartek closed D14034: [lib] Handle use_new_flow for Identity V1 logout.
Fri, Nov 29, 5:03 AM
bartek closed D14033: [lib] Extract hook to send logout message to primary device.
Fri, Nov 29, 5:03 AM
bartek committed rCOMMdda09d0009bd: [lib] Handle use_new_flow for Identity V1 logout (authored by bartek).
[lib] Handle use_new_flow for Identity V1 logout
Fri, Nov 29, 5:03 AM
bartek closed D14032: [native][web] Handle use_new_flow for Identity V1 login calls.
Fri, Nov 29, 5:03 AM
bartek committed rCOMM4e352b153d3c: [lib] Extract hook to send logout message to primary device (authored by bartek).
[lib] Extract hook to send logout message to primary device
Fri, Nov 29, 5:03 AM
bartek committed rCOMM430be00c2a11: [native][web] Handle use_new_flow for Identity V1 login calls (authored by bartek).
[native][web] Handle use_new_flow for Identity V1 login calls
Fri, Nov 29, 5:03 AM
bartek closed D13954: [identity] Introduce the use_new_flow response code.
Fri, Nov 29, 5:03 AM
bartek closed D14031: [lib] Handle invalid CSAT in Identity Search context.
Fri, Nov 29, 5:03 AM
bartek committed rCOMM3438b0648a70: [identity] Introduce the use_new_flow response code (authored by bartek).
[identity] Introduce the use_new_flow response code
Fri, Nov 29, 5:03 AM
bartek closed D14030: [keyserver] Handle invalid CSAT in Tunnelbroker socket.
Fri, Nov 29, 5:03 AM
bartek committed rCOMMe6ee808615e7: [lib] Handle invalid CSAT in Identity Search context (authored by bartek).
[lib] Handle invalid CSAT in Identity Search context
Fri, Nov 29, 5:03 AM
bartek closed D14029: [keyserver] Handle invalid CSAT for Identity RPCs.
Fri, Nov 29, 5:03 AM
bartek closed D14028: [keyserver] Extract getInboundKeys to a separate function.
Fri, Nov 29, 5:03 AM
bartek committed rCOMM4ff096b69971: [keyserver] Handle invalid CSAT in Tunnelbroker socket (authored by bartek).
[keyserver] Handle invalid CSAT in Tunnelbroker socket
Fri, Nov 29, 5:03 AM
bartek committed rCOMM4b22d08db3ad: [keyserver] Handle invalid CSAT for Identity RPCs (authored by bartek).
[keyserver] Handle invalid CSAT for Identity RPCs
Fri, Nov 29, 5:03 AM
bartek committed rCOMMd6994b2823f0: [keyserver] Extract getInboundKeys to a separate function (authored by bartek).
[keyserver] Extract getInboundKeys to a separate function
Fri, Nov 29, 5:03 AM
bartek closed D14027: [keyserver] Extract publishPrekeys to a separate function.
Fri, Nov 29, 5:03 AM