Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (132 w, 4 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Today

bartek accepted D14575: [native] update `persistConfig` comment.
Tue, Apr 15, 5:36 AM

Yesterday

bartek accepted D14574: [native] Fix uploading transcoded media.
Mon, Apr 14, 6:45 AM
bartek closed D14569: [native] Make missing AuthMetadata message more accurate.
Mon, Apr 14, 4:39 AM
bartek committed rCOMMcc686935acdd: [native] Make missing AuthMetadata message more accurate (authored by bartek).
[native] Make missing AuthMetadata message more accurate
Mon, Apr 14, 4:39 AM
bartek closed D14568: [native] Fetch platform details during restore flow.
Mon, Apr 14, 4:39 AM
bartek committed rCOMMbf90254c736c: [native] Fetch platform details during restore flow (authored by bartek).
[native] Fetch platform details during restore flow
Mon, Apr 14, 4:39 AM
bartek added a comment to D14566: [native] Fix uploading images with ph-upload:// scheme.

That's right. There was a mistake here. During the review, I was comparing changes in this diff with changes from D14512 and I misunderstood changes to initialURI in that diff, making me think this diff is correct.

Mon, Apr 14, 3:39 AM
bartek updated the diff for D14568: [native] Fetch platform details during restore flow.

Remove redundant code

Mon, Apr 14, 3:09 AM
bartek added inline comments to D14568: [native] Fetch platform details during restore flow.
Mon, Apr 14, 3:08 AM

Fri, Apr 11

bartek published D14569: [native] Make missing AuthMetadata message more accurate for review.
Fri, Apr 11, 3:43 AM
bartek published D14568: [native] Fetch platform details during restore flow for review.
Fri, Apr 11, 3:39 AM
bartek accepted D14561: [native][web] Add migrations unshimming delete messages.
Fri, Apr 11, 12:20 AM

Thu, Apr 10

bartek accepted D14566: [native] Fix uploading images with ph-upload:// scheme.
Thu, Apr 10, 11:41 PM
bartek closed D14563: [lib] Use AuxUserStore peer list in primary logout.
Thu, Apr 10, 3:56 AM
bartek committed rCOMM2fae88ffe011: [lib] Use AuxUserStore peer list in primary logout (authored by bartek).
[lib] Use AuxUserStore peer list in primary logout
Thu, Apr 10, 3:56 AM
bartek published D14563: [lib] Use AuxUserStore peer list in primary logout for review.
Thu, Apr 10, 3:06 AM
bartek accepted D14562: [native][SQLite] add logging to errors.
Thu, Apr 10, 2:59 AM

Wed, Apr 9

bartek closed D14555: [web] Fix enum casing in sharedWorkerStatuses.
Wed, Apr 9, 1:48 AM
bartek committed rCOMM0cdf8c69748d: [web] Fix enum casing in sharedWorkerStatuses (authored by bartek).
[web] Fix enum casing in sharedWorkerStatuses
Wed, Apr 9, 1:48 AM

Tue, Apr 8

bartek closed D14554: [lib][native][web] Wait for DB reset before generating QR.
Tue, Apr 8, 1:15 AM
bartek committed rCOMM467b918b27d5: [lib][native][web] Wait for DB reset before generating QR (authored by bartek).
[lib][native][web] Wait for DB reset before generating QR
Tue, Apr 8, 1:15 AM
bartek published D14555: [web] Fix enum casing in sharedWorkerStatuses for review.
Tue, Apr 8, 1:07 AM

Mon, Apr 7

bartek added inline comments to D14554: [lib][native][web] Wait for DB reset before generating QR.
Mon, Apr 7, 11:33 PM
bartek updated the diff for D14554: [lib][native][web] Wait for DB reset before generating QR.

Address review feedback:

  • Enum casing
  • Declaration reorder
  • Introduced waitUntilDatabaseReady()
Mon, Apr 7, 11:27 PM
bartek added inline comments to D14554: [lib][native][web] Wait for DB reset before generating QR.
Mon, Apr 7, 11:15 PM
bartek published D14554: [lib][native][web] Wait for DB reset before generating QR for review.
Mon, Apr 7, 4:27 AM
bartek accepted D14531: [native] implement triggering backup compaction on dev.
Mon, Apr 7, 4:22 AM
bartek closed D14553: [terraform] Deploy prod Identity 0.52.1 and Backup 0.6.0.
Mon, Apr 7, 3:18 AM
bartek committed rCOMM99f9c84dcf36: [terraform] Deploy prod Identity 0.52.1 and Backup 0.6.0 (authored by bartek).
[terraform] Deploy prod Identity 0.52.1 and Backup 0.6.0
Mon, Apr 7, 3:18 AM
bartek published D14553: [terraform] Deploy prod Identity 0.52.1 and Backup 0.6.0 for review.
Mon, Apr 7, 2:30 AM
bartek closed D14538: [identity] Add logging to Farcaster RPCs.
Mon, Apr 7, 2:15 AM
bartek committed rCOMM82a43b0fbeff: [identity] Add logging to Farcaster RPCs (authored by bartek).
[identity] Add logging to Farcaster RPCs
Mon, Apr 7, 2:15 AM
bartek closed D14537: [identity] Remove hacks for authoritative keyserver.
Mon, Apr 7, 2:15 AM
bartek committed rCOMM4e97f269881d: [identity] Remove hacks for authoritative keyserver (authored by bartek).
[identity] Remove hacks for authoritative keyserver
Mon, Apr 7, 2:15 AM

Thu, Apr 3

bartek published D14538: [identity] Add logging to Farcaster RPCs for review.
Thu, Apr 3, 11:06 PM
bartek published D14537: [identity] Remove hacks for authoritative keyserver for review.
Thu, Apr 3, 9:13 AM
bartek accepted D14517: [SQLite] implement method to copy table between databases.
Thu, Apr 3, 7:25 AM
bartek accepted D14527: [native] remove old code from `BackupMenu`.
Thu, Apr 3, 5:14 AM
bartek accepted D14526: [web] remove `BackupTestRestoreModal`.
Thu, Apr 3, 5:14 AM
bartek accepted D14533: [lib] attempt restoring User Data after restoring primary device.
Thu, Apr 3, 5:06 AM
bartek accepted D14532: [lib] attempt restoring User Data after QR auth.
Thu, Apr 3, 5:03 AM
bartek added inline comments to D14531: [native] implement triggering backup compaction on dev.
Thu, Apr 3, 5:03 AM
bartek accepted D14530: [native] make it possible to capture logs.
Thu, Apr 3, 4:49 AM
bartek accepted D14529: [native] start backup thread when app is in foreground.
Thu, Apr 3, 4:46 AM
bartek accepted D14528: [lib][native] introduce `fullBackupSupport` flag.
Thu, Apr 3, 4:43 AM
bartek accepted D14525: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI.
Thu, Apr 3, 4:42 AM
bartek accepted D14524: [lib][native] remove `performBackupRestore` from `SecondaryDeviceQRAuthContextProvider`.
Thu, Apr 3, 4:41 AM
bartek accepted D14523: [lib][web][native] implement shared function to execute User Data restore.
Thu, Apr 3, 4:24 AM
bartek accepted D14522: [native] extract constants from `persist.js`.
Thu, Apr 3, 4:22 AM
bartek accepted D14521: [lib][native] refactor login/restore hooks to return `IdentityAuthResult`.
Thu, Apr 3, 3:56 AM
bartek accepted D14520: [lib] add logging to `createMissingSession`.
Thu, Apr 3, 3:52 AM
bartek accepted D14519: [SQLite] copy tables during restore instead of replacing entire database.
Thu, Apr 3, 3:51 AM
bartek accepted D14518: [SQLite] unify `restoreFromMainCompaction` on platforms.
Thu, Apr 3, 3:50 AM
bartek added a comment to D14517: [SQLite] implement method to copy table between databases.

Don't we want this method to take a vector of tables to copy? Looking at D14519, I see you're running this in a loop, so the ATTACH DATABASE ..., DETACH statements are repeated for each table

Thu, Apr 3, 3:50 AM
bartek accepted D14516: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach.
Thu, Apr 3, 3:27 AM
bartek accepted D14515: [SQLite] add logging to `handleSQLiteError`.
Thu, Apr 3, 3:20 AM
bartek closed D14513: [identity] Fix retrying OTK upload transaction.
Thu, Apr 3, 12:51 AM
bartek committed rCOMM8b0b50263e18: [identity] Fix retrying OTK upload transaction (authored by bartek).
[identity] Fix retrying OTK upload transaction
Thu, Apr 3, 12:51 AM
bartek accepted D14512: [native] Fix reading video files for processing.
Thu, Apr 3, 12:47 AM
bartek accepted D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.
Thu, Apr 3, 12:46 AM

Wed, Apr 2

bartek published D14513: [identity] Fix retrying OTK upload transaction for review.
Wed, Apr 2, 7:28 AM

Mon, Mar 31

bartek closed D14509: [protos] Update comment with NEXT_CODE_VERSION.
Mon, Mar 31, 5:59 AM
bartek committed rCOMM826d7be44b93: [protos] Update comment with NEXT_CODE_VERSION (authored by bartek).
[protos] Update comment with NEXT_CODE_VERSION
Mon, Mar 31, 5:59 AM
bartek closed D14508: [identity] Enable strict device list checks.
Mon, Mar 31, 5:59 AM
bartek committed rCOMM021147207d4f: [identity] Enable strict device list checks (authored by bartek).
[identity] Enable strict device list checks
Mon, Mar 31, 5:59 AM

Thu, Mar 27

bartek published D14509: [protos] Update comment with NEXT_CODE_VERSION for review.
Thu, Mar 27, 5:26 AM
bartek published D14508: [identity] Enable strict device list checks for review.
Thu, Mar 27, 5:25 AM
bartek closed D14506: [lib][native] Keep keyserver in device list after primary logout.
Thu, Mar 27, 5:23 AM
bartek closed D14507: [lib] Don't send logout message to keyserver.
Thu, Mar 27, 5:23 AM
bartek committed rCOMMca2408bcde4e: [lib] Don't send logout message to keyserver (authored by bartek).
[lib] Don't send logout message to keyserver
Thu, Mar 27, 5:23 AM
bartek committed rCOMMfc01ada1f576: [lib][native] Keep keyserver in device list after primary logout (authored by bartek).
[lib][native] Keep keyserver in device list after primary logout
Thu, Mar 27, 5:23 AM
bartek closed D14491: [native] Add keyserver to device list during restore.
Thu, Mar 27, 5:23 AM
bartek committed rCOMM1cb201403ab0: [native] Add keyserver to device list during restore (authored by bartek).
[native] Add keyserver to device list during restore
Thu, Mar 27, 5:23 AM
bartek closed D14503: [terraform] Bump staging Identity and Backup.
Thu, Mar 27, 3:48 AM
bartek committed rCOMM168db9273acc: [terraform] Bump staging Identity and Backup (authored by bartek).
[terraform] Bump staging Identity and Backup
Thu, Mar 27, 3:48 AM
bartek closed D14504: [identity] Skip keyserver during privileged password reset.
Thu, Mar 27, 3:48 AM
bartek committed rCOMMd7762e5395a0: [identity] Skip keyserver during privileged password reset (authored by bartek).
[identity] Skip keyserver during privileged password reset
Thu, Mar 27, 3:48 AM
bartek published D14507: [lib] Don't send logout message to keyserver for review.
Thu, Mar 27, 3:15 AM
bartek published D14506: [lib][native] Keep keyserver in device list after primary logout for review.
Thu, Mar 27, 3:15 AM
bartek retitled D14503: [terraform] Bump staging Identity and Backup from [terraform] Bump staging Identity to 0.52.0 to [terraform] Bump staging Identity and Backup.
Thu, Mar 27, 2:49 AM
bartek updated the diff for D14503: [terraform] Bump staging Identity and Backup.

Bump Backup too

Thu, Mar 27, 2:48 AM
bartek published D14503: [terraform] Bump staging Identity and Backup for review.
Thu, Mar 27, 2:39 AM

Wed, Mar 26

bartek closed D14502: [terraform] Bump prod Identity to 0.51.2.
Wed, Mar 26, 8:31 AM
bartek committed rCOMM8a9385222c2c: [terraform] Bump prod Identity to 0.51.2 (authored by bartek).
[terraform] Bump prod Identity to 0.51.2
Wed, Mar 26, 8:31 AM
bartek published D14504: [identity] Skip keyserver during privileged password reset for review.
Wed, Mar 26, 8:29 AM
bartek published D14502: [terraform] Bump prod Identity to 0.51.2 for review.
Wed, Mar 26, 8:23 AM
bartek closed D14492: [protos][identity] Remove primary device info from GetKeyserverKeys.
Wed, Mar 26, 8:01 AM
bartek committed rCOMMd62e2ca88a20: [protos][identity] Remove primary device info from GetKeyserverKeys (authored by bartek).
[protos][identity] Remove primary device info from GetKeyserverKeys
Wed, Mar 26, 8:01 AM
bartek added inline comments to D14492: [protos][identity] Remove primary device info from GetKeyserverKeys.
Wed, Mar 26, 8:00 AM
bartek closed D14501: [identity] Skip keyserver during primary logout and restore.
Wed, Mar 26, 7:55 AM
bartek closed D14500: [identity] Refactor devices data deletion to allow filtering.
Wed, Mar 26, 7:55 AM
bartek committed rCOMM0a82eb871ff8: [identity] Skip keyserver during primary logout and restore (authored by bartek).
[identity] Skip keyserver during primary logout and restore
Wed, Mar 26, 7:55 AM
bartek committed rCOMMca6dc08b6f22: [identity] Refactor devices data deletion to allow filtering (authored by bartek).
[identity] Refactor devices data deletion to allow filtering
Wed, Mar 26, 7:55 AM
bartek closed D14499: [identity] Fix OTK removal in clean_up_devices_data.
Wed, Mar 26, 7:55 AM
bartek closed D14498: [identity] Split OTK deletion into smaller functions.
Wed, Mar 26, 7:55 AM
bartek committed rCOMMcdc293df59ec: [identity] Split OTK deletion into smaller functions (authored by bartek).
[identity] Split OTK deletion into smaller functions
Wed, Mar 26, 7:55 AM
bartek committed rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data (authored by bartek).
[identity] Fix OTK removal in clean_up_devices_data
Wed, Mar 26, 7:55 AM
bartek closed D14496: [identity] Make function names more accurate.
Wed, Mar 26, 7:55 AM
bartek closed D14497: [identity] Allow excluding devices in CSAT deletion func.
Wed, Mar 26, 7:55 AM
bartek committed rCOMM572f0e728323: [identity] Allow excluding devices in CSAT deletion func (authored by bartek).
[identity] Allow excluding devices in CSAT deletion func
Wed, Mar 26, 7:55 AM