Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (111 w, 5 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Today

bartek accepted D13937: [native_rust_library] update creating backup to return `backupID`.
Wed, Nov 20, 8:51 AM
bartek accepted D13936: [CommCoreModule] cleanup methods for creating backup.
Wed, Nov 20, 8:46 AM
bartek accepted D13935: [native] implement creating User Keys backup.
Wed, Nov 20, 7:47 AM
bartek accepted D13934: [CommCoreModule] implement creating User Keys backup.

I implemented 1, which is not the best in terms of transferring data but it's the cleanest one - but I am open to updating. Note, that this API won't be used a lot.

Wed, Nov 20, 7:46 AM
bartek accepted D13963: [lib] create hook to run Device List Update Protocol.

Nice work on the stack 👍

Wed, Nov 20, 6:44 AM
bartek accepted D13968: [native] avoid showing SIWE backup message screen for non-primary devices.
Wed, Nov 20, 6:43 AM
bartek accepted D13967: [lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created.

Nice

Wed, Nov 20, 6:42 AM
bartek accepted D13966: [native][lib] remove `requestBackupKeys` from `SECONDARY_DEVICE_REGISTRATION_SUCCESS`.
Wed, Nov 20, 6:41 AM
bartek accepted D13965: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`.
Wed, Nov 20, 6:40 AM
bartek accepted D13964: [lib] temporary remove code performing backup restore.
Wed, Nov 20, 6:39 AM
bartek published D13973: [reports] Upgrade Postmark crate to fix TLS for review.
Wed, Nov 20, 6:12 AM

Yesterday

bartek accepted D13962: [terraform] upgrade backup prod to 0.5.1.
Tue, Nov 19, 6:47 AM
bartek accepted D13933: [CommCoreModule] remove capturing logs.
Tue, Nov 19, 5:45 AM
bartek accepted D13932: [backup-client][native_rust_library] refactor uploading files to not ignore User Keys.
Tue, Nov 19, 5:45 AM
bartek accepted D13931: [backup-client][native_rust_library] implement creating User Keys backup.
Tue, Nov 19, 5:41 AM
bartek accepted D13930: [backup-client][native_rust_library] update backup client to run cleanup on any failure.
Tue, Nov 19, 5:41 AM
bartek accepted D13929: [backup-client][native_rust_library] update file cleanup to ignore missing files.
Tue, Nov 19, 5:38 AM
bartek accepted D13928: [backup-client] avoid adding `attachments` when uploading User Keys.
Tue, Nov 19, 5:37 AM

Sat, Nov 16

bartek accepted D13944: [terraform] create backup cloudwatch alarms.
Sat, Nov 16, 1:31 AM

Fri, Nov 15

bartek accepted D13942: [backup] add errorType to error logs in backup.
Fri, Nov 15, 2:18 AM
bartek accepted D13942: [backup] add errorType to error logs in backup.
Fri, Nov 15, 2:16 AM
bartek accepted D13943: [terraform] break up alarms into separate terraform files.
Fri, Nov 15, 1:05 AM
bartek accepted D13941: [backup/terraform] use json logs in backup if COMM_SERVICES_USE_JSON_LOGS variable set to true.
Fri, Nov 15, 1:04 AM

Tue, Nov 12

bartek accepted D13904: [terraform] deploy backup 0.5.0 to prod.
Tue, Nov 12, 4:12 AM

Fri, Nov 8

bartek accepted D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Fri, Nov 8, 12:16 PM
bartek closed D13892: [native][web] Clean up dead conditions for media encryption.
Fri, Nov 8, 10:24 AM
bartek committed rCOMM95e169f5657f: [native][web] Clean up dead conditions for media encryption (authored by bartek).
[native][web] Clean up dead conditions for media encryption
Fri, Nov 8, 10:23 AM
bartek closed D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
Fri, Nov 8, 10:23 AM
bartek closed D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.
Fri, Nov 8, 10:23 AM
bartek committed rCOMM39b8726256bc: [native][web] Flip the switch for blob-hosted media/avatar uploads (authored by bartek).
[native][web] Flip the switch for blob-hosted media/avatar uploads
Fri, Nov 8, 10:23 AM
bartek committed rCOMM55b2aca840f8: [native][web] Add migration to unshim Blob-hosted multimedia (authored by bartek).
[native][web] Add migration to unshim Blob-hosted multimedia
Fri, Nov 8, 10:23 AM
bartek closed D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Fri, Nov 8, 10:23 AM
bartek committed rCOMM6ff0c6e70b0b: [lib] Stop shimming Blob-hosted multimedia messages (authored by bartek).
[lib] Stop shimming Blob-hosted multimedia messages
Fri, Nov 8, 10:23 AM
bartek updated the diff for D13892: [native][web] Clean up dead conditions for media encryption.

I was going to create a separate diff for removing the 'uploadMultimedia' but decided to fixup it into this one

Fri, Nov 8, 8:16 AM
bartek closed D13747: [native] Improve device labels on device list screen.
Fri, Nov 8, 6:25 AM
bartek committed rCOMM085f43d75697: [native] Improve device labels on device list screen (authored by bartek).
[native] Improve device labels on device list screen
Fri, Nov 8, 6:25 AM
bartek closed D13262: [native] only display remove device button if current device is primary device.
Fri, Nov 8, 6:25 AM
bartek closed D13125: [native] add ability to remove devices from linked devices bottom sheet.
Fri, Nov 8, 6:25 AM
bartek committed rCOMM89cbd85b1c2a: [native] only display remove device button if current device is primary device (authored by varun).
[native] only display remove device button if current device is primary device
Fri, Nov 8, 6:25 AM
bartek committed rCOMMa4517c9d13ba: [native] add ability to remove devices from linked devices bottom sheet (authored by varun).
[native] add ability to remove devices from linked devices bottom sheet
Fri, Nov 8, 6:25 AM
bartek accepted D13896: Upgrade to Rust 1.81.
Fri, Nov 8, 6:21 AM
bartek added a comment to D13888: [lib] Stop shimming Blob-hosted multimedia messages.

Hmmmm this doesn't look right... the file on the left doesn't seem to be master

Fri, Nov 8, 6:20 AM
bartek updated the diff for D13892: [native][web] Clean up dead conditions for media encryption.

Rebase, add invariants for encrypted uploads, remove more dead code: legacy calls

Fri, Nov 8, 5:29 AM
bartek updated the diff for D13888: [lib] Stop shimming Blob-hosted multimedia messages.

Use version 389 as minimal

Fri, Nov 8, 5:23 AM
bartek updated the diff for D13262: [native] only display remove device button if current device is primary device.
  • Made primary device non-clickable
  • Added pencil icons to editable items
  • Refactored isThisDevice
  • Made type readonly
Fri, Nov 8, 5:20 AM
bartek updated the diff for D13125: [native] add ability to remove devices from linked devices bottom sheet.

Remove padding

Fri, Nov 8, 5:19 AM
bartek attached a referenced file: F3180751: Simulator Screenshot - iPhone 15 Pro - 2024-11-08 at 14.13.50.png.
Fri, Nov 8, 5:16 AM
bartek added a comment to D13262: [native] only display remove device button if current device is primary device.

Neat ideas, I came up with something like this (the first item is not clickable):

Simulator Screenshot - iPhone 15 Pro - 2024-11-08 at 14.13.50.png (2×1 px, 140 KB)

Fri, Nov 8, 5:16 AM
bartek added a comment to D13889: [native][web] Add migration to unshim Blob-hosted multimedia.

I talked with @tomek, and we concluded that I had previously done the test plan wrong, and the migration didn't actually run. In short, I was logging in with state version 85 from the beginning.

Fri, Nov 8, 4:09 AM
bartek added inline comments to D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Fri, Nov 8, 1:42 AM
bartek added inline comments to D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Fri, Nov 8, 1:09 AM

Thu, Nov 7

bartek closed D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.
Thu, Nov 7, 8:25 AM
bartek committed rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads (authored by bartek).
[native][web] Flip the switch for blob-hosted media/avatar uploads
Thu, Nov 7, 8:25 AM
bartek closed D13890: [native][web] Stop limiting media encryption to staff community.
Thu, Nov 7, 8:25 AM
bartek closed D13889: [native][web] Add migration to unshim Blob-hosted multimedia.
Thu, Nov 7, 8:25 AM
bartek committed rCOMMdc9c299698c2: [native][web] Stop limiting media encryption to staff community (authored by bartek).
[native][web] Stop limiting media encryption to staff community
Thu, Nov 7, 8:25 AM
bartek committed rCOMM30f6d90c525a: [native][web] Add migration to unshim Blob-hosted multimedia (authored by bartek).
[native][web] Add migration to unshim Blob-hosted multimedia
Thu, Nov 7, 8:25 AM
bartek closed D13888: [lib] Stop shimming Blob-hosted multimedia messages.
Thu, Nov 7, 8:25 AM
bartek committed rCOMM0b058dcfae34: [lib] Stop shimming Blob-hosted multimedia messages (authored by bartek).
[lib] Stop shimming Blob-hosted multimedia messages
Thu, Nov 7, 8:25 AM
bartek added inline comments to D13892: [native][web] Clean up dead conditions for media encryption.
Thu, Nov 7, 7:23 AM
bartek added inline comments to D13892: [native][web] Clean up dead conditions for media encryption.
Thu, Nov 7, 4:52 AM
bartek published D13892: [native][web] Clean up dead conditions for media encryption for review.
Thu, Nov 7, 4:51 AM
bartek published D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads for review.
Thu, Nov 7, 4:51 AM
bartek published D13890: [native][web] Stop limiting media encryption to staff community for review.
Thu, Nov 7, 4:50 AM
bartek published D13889: [native][web] Add migration to unshim Blob-hosted multimedia for review.
Thu, Nov 7, 4:50 AM
bartek published D13888: [lib] Stop shimming Blob-hosted multimedia messages for review.
Thu, Nov 7, 4:50 AM
bartek accepted D13893: [terraform] deploy backup 0.5.0 to staging.
Thu, Nov 7, 4:16 AM
bartek accepted D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
Thu, Nov 7, 12:38 AM

Wed, Nov 6

bartek accepted D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately.
Wed, Nov 6, 9:41 PM
bartek added inline comments to D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.
Wed, Nov 6, 9:40 PM
bartek accepted D13877: [backup-service] implement endpoint to upload User Data.
Wed, Nov 6, 9:32 PM
bartek accepted D13876: [backup-service] implement endpoint to upload User Keys.
Wed, Nov 6, 6:13 AM
bartek accepted D13880: [native] Fix QR code scanning on Android.

Nice find!

Wed, Nov 6, 2:53 AM
bartek accepted D13875: [backup-service] make `user_data` optional in `BackupItem`.
Wed, Nov 6, 1:06 AM
bartek accepted D13873: [backup-service] refactor uploading function in `/backups` endpoint.
Wed, Nov 6, 1:05 AM
bartek accepted D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier.

Alternatively, we can download only backupID and read backupDataKey and backupLogDataKey (it should exist on primary always) to avoid downloading User Keys - but curious about @bartek's perspective as I don't fully remember why it was implemented that way,

Wed, Nov 6, 1:01 AM
bartek accepted D13872: [commtest] refactor backup service integration tests.

Nice!

Wed, Nov 6, 12:59 AM
bartek accepted D13871: [native] Get rid of bottomSheetPaddingTop in ConnectFarcasterBottomSheet.
Wed, Nov 6, 12:39 AM
bartek accepted D13870: [native] Get rid of userProfileBottomPadding.
Wed, Nov 6, 12:39 AM
bartek accepted D13869: [native] Fix incorrectly set verticalBounds in UserProfileAvatar.
Wed, Nov 6, 12:39 AM
bartek accepted D13868: [native] Measure whole KeyserverSelectionBottomSheet.
Wed, Nov 6, 12:38 AM
bartek accepted D13867: [native] Consider BottomSheetHandle size when setting snapPoints.
Wed, Nov 6, 12:38 AM
bartek accepted D13844: [native] unify username and wallet backup restore.
Wed, Nov 6, 12:38 AM
bartek accepted D13846: [CommCoreModule][native_rust_library] deprecate SIWE related backup code.
Wed, Nov 6, 12:38 AM
bartek accepted D13847: [native] update Secondary Device Auth flow to support SIWE users.
Wed, Nov 6, 12:37 AM

Tue, Nov 5

bartek accepted D13840: [backup-client] make `backupID` mandatory when restoring backup.
Tue, Nov 5, 3:14 AM

Mon, Nov 4

bartek accepted D13838: [CommCoreModule] expose method to retrieve latest backup info.
Mon, Nov 4, 11:29 PM
bartek retitled D13838: [CommCoreModule] expose method to retrieve latest backup info from [CommCoreModule] expose method retrieve latest backup info to [CommCoreModule] expose method to retrieve latest backup info.
Mon, Nov 4, 11:29 PM
bartek accepted D13837: [native_rust_library] implement method to retrieve latest backup info.
Mon, Nov 4, 11:28 PM
bartek accepted D13836: [backup-client] refactor `SIWEBackupData` type.
Mon, Nov 4, 11:20 PM
bartek accepted D13839: [native] make it possible to test retrieving latest backup info.
Mon, Nov 4, 5:03 AM
bartek accepted D13809: [backup-service][backup-client] update `/latest` endpoint to return both `backupID` and `userID`.

Neat idea with this rename to backup info

Mon, Nov 4, 5:01 AM
bartek accepted D13807: [backup-service] use `username` instead of `userID` when downloading backup.
Mon, Nov 4, 4:59 AM
bartek accepted D13817: [docker-compose] configure Identity endpoint for backup in commtest.
Mon, Nov 4, 4:57 AM
bartek accepted D13806: [backup-service] implement calling `FindUserID` RPC from Backup.
Mon, Nov 4, 4:57 AM
bartek accepted D13805: [commtest] use registered `UserIdentity` in backup tests.
Mon, Nov 4, 4:56 AM
bartek accepted D13803: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`.
Mon, Nov 4, 4:56 AM
bartek accepted D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
Mon, Nov 4, 4:55 AM
bartek updated the diff for D13125: [native] add ability to remove devices from linked devices bottom sheet.

Add missing bottom padding

Mon, Nov 4, 3:40 AM
bartek attached a referenced file: F3146598: Simulator Screenshot - iPhone 15 Pro - 2024-10-25 at 10.25.13.png.
Mon, Nov 4, 3:39 AM