Page MenuHomePhabricator

kamil (Kamil Kurowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2022, 1:56 AM (139 w, 3 d)

Recent Activity

Wed, Apr 16

kamil accepted D14582: [lib] Delete legacySiweAuth action.
Wed, Apr 16, 5:38 AM
kamil accepted D14581: [lib] Delete legacyKeyserverRegister action.
Wed, Apr 16, 5:36 AM
kamil accepted D14580: [lib] Remove all the usages of usingCommServicesAccessToken from lib.
Wed, Apr 16, 5:34 AM
kamil accepted D14579: [native] Remove all the usages of usingCommServicesAccessToken from native.
Wed, Apr 16, 5:22 AM
kamil accepted D14578: [web] Remove all the usages of usingCommServicesAccessToken from web.
Wed, Apr 16, 5:12 AM
kamil accepted D14577: [web] Remove danger zone.
Wed, Apr 16, 5:04 AM
kamil accepted D14576: [keyserver] Improve Olm memory logging.

One thing I would consider is not calling verifyMemoryUsage in cronjobs that are failing, because this checks how memory behaves compared to the previous check, but explicitly call get_total_memory and get_used_memory at start and end of job, and log if there is a difference.

Wed, Apr 16, 3:53 AM

Tue, Apr 15

kamil closed D14575: [native] update `persistConfig` comment.
Tue, Apr 15, 6:48 AM
kamil committed rCOMMfa534b0d4790: [native] update `persistConfig` comment (authored by kamil).
[native] update `persistConfig` comment
Tue, Apr 15, 6:48 AM
kamil updated the diff for D14575: [native] update `persistConfig` comment.

rebase

Tue, Apr 15, 6:25 AM
kamil published D14575: [native] update `persistConfig` comment for review.
Tue, Apr 15, 3:30 AM

Mon, Apr 14

kamil closed D14571: [CommCoreModule][SQLite] remove unused JSI calls.
Mon, Apr 14, 3:12 AM
kamil closed D14572: [SQLite] move database version getter and setter to `SQLiteUtils`.
Mon, Apr 14, 3:12 AM
kamil closed D14570: [SQLite][native] introduce `SQLiteUtils` class.
Mon, Apr 14, 3:12 AM
kamil committed rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls (authored by kamil).
[CommCoreModule][SQLite] remove unused JSI calls
Mon, Apr 14, 3:12 AM
kamil committed rCOMM935928a8f9e4: [SQLite] move database version getter and setter to `SQLiteUtils` (authored by kamil).
[SQLite] move database version getter and setter to `SQLiteUtils`
Mon, Apr 14, 3:12 AM
kamil committed rCOMMa325ca34beae: [SQLite][native] introduce `SQLiteUtils` class (authored by kamil).
[SQLite][native] introduce `SQLiteUtils` class
Mon, Apr 14, 3:12 AM
kamil accepted D14568: [native] Fetch platform details during restore flow.
Mon, Apr 14, 1:50 AM

Fri, Apr 11

kamil published D14573: [SQLite] implement `SQLiteSchema` class to wrap creation and migration logic for review.
Fri, Apr 11, 8:31 AM
kamil published D14572: [SQLite] move database version getter and setter to `SQLiteUtils` for review.
Fri, Apr 11, 8:18 AM
kamil published D14571: [CommCoreModule][SQLite] remove unused JSI calls for review.
Fri, Apr 11, 8:07 AM
kamil published D14570: [SQLite][native] introduce `SQLiteUtils` class for review.
Fri, Apr 11, 8:03 AM
kamil accepted D14569: [native] Make missing AuthMetadata message more accurate.
Fri, Apr 11, 4:54 AM

Thu, Apr 10

kamil closed D14562: [native][SQLite] add logging to errors.
Thu, Apr 10, 3:11 AM
kamil committed rCOMM0db8526f1c97: [native][SQLite] add logging to errors (authored by kamil).
[native][SQLite] add logging to errors
Thu, Apr 10, 3:11 AM
kamil accepted D14563: [lib] Use AuxUserStore peer list in primary logout.
Thu, Apr 10, 3:10 AM
kamil published D14562: [native][SQLite] add logging to errors for review.
Thu, Apr 10, 2:54 AM

Wed, Apr 9

kamil closed D14559: [terraform] bump staging Tunnelbroker to 0.18.4.
Wed, Apr 9, 4:27 AM
kamil committed rCOMM8832665bb4fe: [terraform] bump staging Tunnelbroker to 0.18.4 (authored by kamil).
[terraform] bump staging Tunnelbroker to 0.18.4
Wed, Apr 9, 4:27 AM
kamil published D14559: [terraform] bump staging Tunnelbroker to 0.18.4 for review.
Wed, Apr 9, 4:01 AM
kamil closed D14558: [tunnelbroker] bump `web-push` version.
Wed, Apr 9, 3:48 AM
kamil committed rCOMM4fff7ca27039: [tunnelbroker] bump `web-push` version (authored by kamil).
[tunnelbroker] bump `web-push` version
Wed, Apr 9, 3:48 AM
kamil published D14558: [tunnelbroker] bump `web-push` version for review.
Wed, Apr 9, 2:36 AM

Mon, Apr 7

kamil closed D14533: [lib] attempt restoring User Data after restoring primary device.
Mon, Apr 7, 4:46 AM
kamil closed D14531: [native] implement triggering backup compaction on dev.
Mon, Apr 7, 4:46 AM
kamil closed D14532: [lib] attempt restoring User Data after QR auth.
Mon, Apr 7, 4:46 AM
kamil committed rCOMM918d4fe965b8: [lib] attempt restoring User Data after QR auth (authored by kamil).
[lib] attempt restoring User Data after QR auth
Mon, Apr 7, 4:46 AM
kamil committed rCOMM935209b41610: [lib] attempt restoring User Data after restoring primary device (authored by kamil).
[lib] attempt restoring User Data after restoring primary device
Mon, Apr 7, 4:46 AM
kamil committed rCOMMfb2dbebf180d: [native] implement triggering backup compaction on dev (authored by kamil).
[native] implement triggering backup compaction on dev
Mon, Apr 7, 4:46 AM
kamil closed D14530: [native] make it possible to capture logs.
Mon, Apr 7, 4:46 AM
kamil closed D14529: [native] start backup thread when app is in foreground.
Mon, Apr 7, 4:46 AM
kamil committed rCOMMc4afaa5741c6: [native] make it possible to capture logs (authored by kamil).
[native] make it possible to capture logs
Mon, Apr 7, 4:46 AM
kamil committed rCOMM6343aaccbfc9: [native] start backup thread when app is in foreground (authored by kamil).
[native] start backup thread when app is in foreground
Mon, Apr 7, 4:46 AM
kamil closed D14528: [lib][native] introduce `fullBackupSupport` flag.
Mon, Apr 7, 4:46 AM
kamil committed rCOMMf319bedd23be: [lib][native] introduce `fullBackupSupport` flag (authored by kamil).
[lib][native] introduce `fullBackupSupport` flag
Mon, Apr 7, 4:46 AM
kamil updated the diff for D14533: [lib] attempt restoring User Data after restoring primary device.

rebase before landing

Mon, Apr 7, 4:25 AM
kamil added inline comments to D14531: [native] implement triggering backup compaction on dev.
Mon, Apr 7, 4:22 AM
kamil updated the diff for D14531: [native] implement triggering backup compaction on dev.

address review

Mon, Apr 7, 4:22 AM
kamil closed D14527: [native] remove old code from `BackupMenu`.
Mon, Apr 7, 4:11 AM
kamil committed rCOMM11d2fdabcaf9: [native] remove old code from `BackupMenu` (authored by kamil).
[native] remove old code from `BackupMenu`
Mon, Apr 7, 4:11 AM
kamil closed D14526: [web] remove `BackupTestRestoreModal`.
Mon, Apr 7, 4:11 AM
kamil committed rCOMMcbd9c3437f9f: [web] remove `BackupTestRestoreModal` (authored by kamil).
[web] remove `BackupTestRestoreModal`
Mon, Apr 7, 4:11 AM
kamil closed D14525: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI.
Mon, Apr 7, 4:09 AM
kamil closed D14524: [lib][native] remove `performBackupRestore` from `SecondaryDeviceQRAuthContextProvider`.
Mon, Apr 7, 4:09 AM
kamil committed rCOMMfc46d98e8b94: [lib][native] remove `performBackupRestore` from… (authored by kamil).
[lib][native] remove `performBackupRestore` from…
Mon, Apr 7, 4:09 AM
kamil committed rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI (authored by kamil).
[lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI
Mon, Apr 7, 4:09 AM
kamil closed D14522: [native] extract constants from `persist.js`.
Mon, Apr 7, 4:09 AM
kamil closed D14523: [lib][web][native] implement shared function to execute User Data restore.
Mon, Apr 7, 4:09 AM
kamil committed rCOMMac67f42ea7ec: [lib][web][native] implement shared function to execute User Data restore (authored by kamil).
[lib][web][native] implement shared function to execute User Data restore
Mon, Apr 7, 4:09 AM
kamil committed rCOMMe4174e16d28d: [native] extract constants from `persist.js` (authored by kamil).
[native] extract constants from `persist.js`
Mon, Apr 7, 4:09 AM
kamil closed D14521: [lib][native] refactor login/restore hooks to return `IdentityAuthResult`.
Mon, Apr 7, 4:09 AM
kamil committed rCOMMe544731dddb7: [lib][native] refactor login/restore hooks to return `IdentityAuthResult` (authored by kamil).
[lib][native] refactor login/restore hooks to return `IdentityAuthResult`
Mon, Apr 7, 4:09 AM
kamil updated the diff for D14525: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI.

rebase

Mon, Apr 7, 3:39 AM
kamil updated the diff for D14522: [native] extract constants from `persist.js`.

rebase & review

Mon, Apr 7, 3:37 AM
kamil closed D14520: [lib] add logging to `createMissingSession`.
Mon, Apr 7, 3:34 AM
kamil committed rCOMMb466463e3372: [lib] add logging to `createMissingSession` (authored by kamil).
[lib] add logging to `createMissingSession`
Mon, Apr 7, 3:34 AM
kamil closed D14519: [SQLite] copy tables during restore instead of replacing entire database.
Mon, Apr 7, 3:30 AM
kamil closed D14518: [SQLite] unify `restoreFromMainCompaction` on platforms.
Mon, Apr 7, 3:30 AM
kamil committed rCOMM4326d412a5da: [SQLite] unify `restoreFromMainCompaction` on platforms (authored by kamil).
[SQLite] unify `restoreFromMainCompaction` on platforms
Mon, Apr 7, 3:30 AM
kamil committed rCOMMbb6cb42b2e5f: [SQLite] copy tables during restore instead of replacing entire database (authored by kamil).
[SQLite] copy tables during restore instead of replacing entire database
Mon, Apr 7, 3:30 AM
kamil closed D14517: [SQLite] implement method to copy table between databases.
Mon, Apr 7, 3:30 AM
kamil closed D14516: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach.
Mon, Apr 7, 3:30 AM
kamil committed rCOMM277bd9ad9879: [SQLite] implement method to copy table between databases (authored by kamil).
[SQLite] implement method to copy table between databases
Mon, Apr 7, 3:30 AM
kamil committed rCOMM709bb9123ee5: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach (authored by kamil).
[SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach
Mon, Apr 7, 3:30 AM
kamil closed D14515: [SQLite] add logging to `handleSQLiteError`.
Mon, Apr 7, 3:30 AM
kamil committed rCOMM8b2ec9f431dc: [SQLite] add logging to `handleSQLiteError` (authored by kamil).
[SQLite] add logging to `handleSQLiteError`
Mon, Apr 7, 3:30 AM
kamil updated the diff for D14519: [SQLite] copy tables during restore instead of replacing entire database.

rebase before landing

Mon, Apr 7, 3:02 AM
kamil accepted D14553: [terraform] Deploy prod Identity 0.52.1 and Backup 0.6.0.
Mon, Apr 7, 2:39 AM
kamil accepted D14537: [identity] Remove hacks for authoritative keyserver.
Mon, Apr 7, 1:53 AM

Thu, Apr 3

kamil updated the diff for D14517: [SQLite] implement method to copy table between databases.

address review

Thu, Apr 3, 5:20 AM
kamil published D14533: [lib] attempt restoring User Data after restoring primary device for review.
Thu, Apr 3, 5:02 AM
kamil published D14532: [lib] attempt restoring User Data after QR auth for review.
Thu, Apr 3, 4:36 AM
kamil published D14531: [native] implement triggering backup compaction on dev for review.
Thu, Apr 3, 4:31 AM
kamil published D14530: [native] make it possible to capture logs for review.
Thu, Apr 3, 4:31 AM
kamil published D14529: [native] start backup thread when app is in foreground for review.
Thu, Apr 3, 4:22 AM
kamil published D14528: [lib][native] introduce `fullBackupSupport` flag for review.
Thu, Apr 3, 4:22 AM
kamil planned changes to D14517: [SQLite] implement method to copy table between databases.

Don't we want this method to take a vector of tables to copy? Looking at D14519, I see you're running this in a loop, so the ATTACH DATABASE ..., DETACH statements are repeated for each table

Thu, Apr 3, 3:55 AM
kamil published D14527: [native] remove old code from `BackupMenu` for review.
Thu, Apr 3, 3:54 AM
kamil published D14526: [web] remove `BackupTestRestoreModal` for review.
Thu, Apr 3, 3:54 AM
kamil published D14525: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI for review.
Thu, Apr 3, 3:53 AM
kamil published D14524: [lib][native] remove `performBackupRestore` from `SecondaryDeviceQRAuthContextProvider` for review.
Thu, Apr 3, 3:53 AM
kamil published D14523: [lib][web][native] implement shared function to execute User Data restore for review.
Thu, Apr 3, 3:53 AM
kamil published D14522: [native] extract constants from `persist.js` for review.
Thu, Apr 3, 3:52 AM
kamil published D14521: [lib][native] refactor login/restore hooks to return `IdentityAuthResult` for review.
Thu, Apr 3, 3:52 AM
kamil updated the summary of D14520: [lib] add logging to `createMissingSession`.
Thu, Apr 3, 3:50 AM
kamil published D14520: [lib] add logging to `createMissingSession` for review.
Thu, Apr 3, 3:49 AM
kamil published D14519: [SQLite] copy tables during restore instead of replacing entire database for review.
Thu, Apr 3, 3:13 AM
kamil published D14518: [SQLite] unify `restoreFromMainCompaction` on platforms for review.
Thu, Apr 3, 3:12 AM
kamil published D14517: [SQLite] implement method to copy table between databases for review.
Thu, Apr 3, 3:10 AM
kamil published D14516: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach for review.
Thu, Apr 3, 3:05 AM