Page MenuHomePhabricator

tomek (Tomasz Palys)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2020, 6:20 AM (218 w, 1 d)

Recent Activity

Today

tomek accepted D13814: [lib] Add `canProcess` parameter to `useActionsQueue`.
Wed, Oct 30, 4:15 AM

Yesterday

tomek added a comment to D13793: [lib] Factor out useStaffAlert().

This implementation has a performance consequence - in the original implementation, we were only stringifying when an alert was shown. Now we're stringifying the object even for users who will never see an alert. We could consider keeping the JSON.stringify inside showAlertToStaff, but I'm not sure if it is really that important.

Tue, Oct 29, 1:42 AM

Mon, Oct 28

tomek updated the diff for D13698: [lib] Use the actions queue in the peer to peer context.

Revert actions queue change

Mon, Oct 28, 7:07 AM
tomek updated the diff for D13698: [lib] Use the actions queue in the peer to peer context.

Finally

Mon, Oct 28, 7:03 AM
tomek updated the diff for D13698: [lib] Use the actions queue in the peer to peer context.

Readonly

Mon, Oct 28, 7:01 AM
tomek updated the diff for D13698: [lib] Use the actions queue in the peer to peer context.

Simplify the queueing code. This revision still has an issue where leaving a thread casues an exception while sending the notifs. Regardless, it is an improvement comparing to the master, because it fixes sending messages in quick succession. The notifs issue will be fixed in the next diff.

Mon, Oct 28, 6:59 AM

Thu, Oct 24

tomek added inline comments to D13698: [lib] Use the actions queue in the peer to peer context.
Thu, Oct 24, 8:21 AM
tomek closed D13768: [keyserver] Delete invalid invite links.
Thu, Oct 24, 7:50 AM
tomek committed rCOMM055d5255c837: [keyserver] Delete invalid invite links (authored by tomek).
[keyserver] Delete invalid invite links
Thu, Oct 24, 7:50 AM
tomek closed D13767: [keyserver] Fix synchronizing invite links with blobs.
Thu, Oct 24, 7:50 AM
tomek committed rCOMM9f827f1f012d: [keyserver] Fix synchronizing invite links with blobs (authored by tomek).
[keyserver] Fix synchronizing invite links with blobs
Thu, Oct 24, 7:50 AM
tomek added inline comments to D13785: [keyserver] reply on farcaster with invite link.
Thu, Oct 24, 4:19 AM

Wed, Oct 23

tomek accepted D13766: [lib] Add timestamp check when flipping unread status.

What is our thinking about this now?

Wed, Oct 23, 3:19 AM

Tue, Oct 22

tomek requested review of D13768: [keyserver] Delete invalid invite links.
Tue, Oct 22, 9:33 AM
tomek requested review of D13767: [keyserver] Fix synchronizing invite links with blobs.
Tue, Oct 22, 7:57 AM

Mon, Oct 21

tomek closed D13725: [lib] Show staff alerts when an operation isn't processed.
Mon, Oct 21, 9:01 AM
tomek committed rCOMM9a1e431d3184: [lib] Show staff alerts when an operation isn't processed (authored by tomek).
[lib] Show staff alerts when an operation isn't processed
Mon, Oct 21, 9:01 AM
tomek closed D13724: [lib] Add an alert to the lib config.
Mon, Oct 21, 9:01 AM
tomek committed rCOMMa6e16ec1b8d8: [lib] Add an alert to the lib config (authored by tomek).
[lib] Add an alert to the lib config
Mon, Oct 21, 9:01 AM
tomek added a comment to D13725: [lib] Show staff alerts when an operation isn't processed.

According to this comment worth adding this to encryption related errors:

We'll discuss this async and add this to this diff or I can put up another one

Mon, Oct 21, 8:58 AM
tomek accepted D13750: [lib] Handle identity timeout when fetching device lists.
Mon, Oct 21, 3:52 AM
tomek accepted D13741: [lib] Delete users for whom identity didnt return a device list for a long time.
Mon, Oct 21, 3:41 AM
tomek accepted D13740: [lib] Reduce removePeerUsersActionType in thread reducer.
Mon, Oct 21, 3:23 AM

Thu, Oct 17

tomek accepted D13728: [lib] Mark missing users when fetching device lists.
Thu, Oct 17, 2:34 AM
tomek accepted D13727: [lib] Reduce users missing from identity.
Thu, Oct 17, 2:24 AM
tomek accepted D13726: [lib] Add accountMissingStatus.
Thu, Oct 17, 2:06 AM
tomek accepted D13734: [keyserver] Delete Farcaster channel tag blobs when deleting a community.
Thu, Oct 17, 2:01 AM
tomek accepted D13733: [keyserver] Delete invite links when deleting threads.
Thu, Oct 17, 1:57 AM
tomek accepted D13732: [keyserver] Add cron to delete orphaned invite links.
Thu, Oct 17, 1:54 AM
tomek accepted D13731: [keyserver] Also delete from ids table when deleting invite links.
Thu, Oct 17, 1:48 AM
tomek accepted D13739: [lib] update `processDMOpsActionType` action to return all ops.
Thu, Oct 17, 1:36 AM

Wed, Oct 16

tomek requested review of D13725: [lib] Show staff alerts when an operation isn't processed.
Wed, Oct 16, 7:42 AM
tomek requested review of D13724: [lib] Add an alert to the lib config.
Wed, Oct 16, 7:39 AM
tomek closed D13623: [lib] Use queue when processing inbound messages from the DB.
Wed, Oct 16, 6:13 AM
tomek committed rCOMM93296ad41d22: [lib] Use queue when processing inbound messages from the DB (authored by tomek).
[lib] Use queue when processing inbound messages from the DB
Wed, Oct 16, 6:13 AM

Mon, Oct 14

tomek planned changes to D13698: [lib] Use the actions queue in the peer to peer context.
Mon, Oct 14, 8:42 AM
tomek updated the diff for D13698: [lib] Use the actions queue in the peer to peer context.

Rebase

Mon, Oct 14, 8:42 AM
tomek updated the diff for D13623: [lib] Use queue when processing inbound messages from the DB.

Delete unnecessary dependencies

Mon, Oct 14, 8:41 AM
tomek updated the diff for D13698: [lib] Use the actions queue in the peer to peer context.

Delete unnecessary dependencies

Mon, Oct 14, 8:40 AM
tomek updated the diff for D13623: [lib] Use queue when processing inbound messages from the DB.

Avoid losing messages

Mon, Oct 14, 8:38 AM
tomek closed D13632: [native] Avoid updating relationships before the previous call finished.
Mon, Oct 14, 3:52 AM
tomek committed rCOMM621eb400b11a: [native] Avoid updating relationships before the previous call finished (authored by tomek).
[native] Avoid updating relationships before the previous call finished
Mon, Oct 14, 3:52 AM
tomek closed D13614: [lib] Fix leaving thread logic.
Mon, Oct 14, 3:52 AM
tomek committed rCOMM56bb0af60171: [lib] Fix leaving thread logic (authored by tomek).
[lib] Fix leaving thread logic
Mon, Oct 14, 3:52 AM
tomek accepted D13697: [native] Fix NUX Android problem.
Mon, Oct 14, 3:48 AM
tomek planned changes to D13698: [lib] Use the actions queue in the peer to peer context.
Mon, Oct 14, 1:54 AM

Fri, Oct 11

tomek requested review of D13698: [lib] Use the actions queue in the peer to peer context.
Fri, Oct 11, 11:15 AM
tomek updated the diff for D13623: [lib] Use queue when processing inbound messages from the DB.

MErge operation queues

Fri, Oct 11, 10:00 AM
tomek added inline comments to D13632: [native] Avoid updating relationships before the previous call finished.
Fri, Oct 11, 8:58 AM
tomek updated the diff for D13614: [lib] Fix leaving thread logic.

Return mutable array

Fri, Oct 11, 8:48 AM
tomek accepted D13689: [lib] Merge consecutive membership robotext messages.
Fri, Oct 11, 7:58 AM
tomek accepted D13688: [lib] Explain auto-created Farcaster mutual friend threads better.
Fri, Oct 11, 7:49 AM
tomek accepted D13687: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem.
Fri, Oct 11, 7:45 AM
tomek accepted D13686: [lib][native][web] Add support for rendering array of messages in RobotextChatMessageInfoItem.
Fri, Oct 11, 7:40 AM
tomek accepted D13685: [lib][native] Extract chatMessageItemEngagementTargetMessageInfo.
Fri, Oct 11, 6:12 AM
tomek accepted D13684: [lib][native] Extract chatMessageItemHasNonViewerMessage.
Fri, Oct 11, 6:08 AM
tomek accepted D13683: [lib][native][web] Extract chatMessageInfoItemTimestamp.
Fri, Oct 11, 6:07 AM
tomek accepted D13682: [lib][native][web] Extract chatMessageItemKey.
Fri, Oct 11, 6:06 AM
tomek accepted D13681: [native] Fix Timestamp position when focusing RobotextMessage with InlineEngagement.
Fri, Oct 11, 6:00 AM
tomek accepted D13680: [native] Don't create space for author name in RobotextMessageTooltipModal.
Fri, Oct 11, 5:59 AM
tomek accepted D13679: [native] Narrow ChatMessageInfoItemWithHeight to ChatComposedMessageInfoItemWithHeight where appropriate.
Fri, Oct 11, 5:59 AM
tomek accepted D13678: [lib][native][web] Introduce chatMessageItemHasEngagement.
Fri, Oct 11, 5:58 AM
tomek accepted D13677: [native] Fix display of TooltipInlineEngagement.
Fri, Oct 11, 5:56 AM
tomek accepted D13676: [native] Remove TooltipInlineEngagement from RobotextMessageTooltipButton.
Fri, Oct 11, 5:54 AM
tomek accepted D13675: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where appropriate.
Fri, Oct 11, 5:01 AM
tomek added a comment to D13697: [native] Fix NUX Android problem.

I wanted to pass the measure function itseft through conxtext, but that results in Cannot read property '_nativeTag' of undefined error.

My guess is that we need to bind these methods.

Fri, Oct 11, 4:54 AM
tomek requested changes to D13697: [native] Fix NUX Android problem.
Fri, Oct 11, 4:53 AM

Thu, Oct 10

tomek accepted D13674: [web] Move declarations closer to where they're used in ComposedMessage.
Thu, Oct 10, 8:25 AM
tomek accepted D13673: [web] Add some memos to ComposedMessage.
Thu, Oct 10, 8:24 AM
tomek closed D13634: [web] Fix fetching messages in messages list.
Thu, Oct 10, 8:18 AM
tomek committed rCOMM77102c86aad7: [web] Fix fetching messages in messages list (authored by tomek).
[web] Fix fetching messages in messages list
Thu, Oct 10, 8:18 AM
tomek accepted D13672: [web] Convert ComposedMessage to function component.
Thu, Oct 10, 8:04 AM
tomek accepted D13692: [lib] Add Angelika to staff list.
Thu, Oct 10, 8:00 AM
tomek accepted D13671: [web] Remove duplicate containsInlineEngagement property.
Thu, Oct 10, 6:58 AM
tomek accepted D13670: [web] Remove unused InputState from ComposedMessage.
Thu, Oct 10, 6:57 AM
tomek accepted D13663: [lib] send confirmation for ignored DM ops.

Why do we ignore all the promises? What is the downside of awaiting them?

Thu, Oct 10, 5:29 AM
tomek accepted D13662: [lib] extract code responsible for confirming P2P message to a hook.
Thu, Oct 10, 5:28 AM
tomek accepted D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
Thu, Oct 10, 5:14 AM
tomek accepted D13653: [lib] Add handler component for retrying holder processing.
Thu, Oct 10, 5:03 AM

Tue, Oct 8

tomek requested review of D13634: [web] Fix fetching messages in messages list.
Tue, Oct 8, 8:55 AM
tomek requested review of D13632: [native] Avoid updating relationships before the previous call finished.
Tue, Oct 8, 5:07 AM
tomek added inline comments to D13614: [lib] Fix leaving thread logic.
Tue, Oct 8, 3:45 AM
tomek added inline comments to D13614: [lib] Fix leaving thread logic.
Tue, Oct 8, 2:39 AM

Mon, Oct 7

tomek requested review of D13623: [lib] Use queue when processing inbound messages from the DB.
Mon, Oct 7, 5:35 AM

Fri, Oct 4

tomek requested review of D13614: [lib] Fix leaving thread logic.
Fri, Oct 4, 9:31 AM
tomek closed D13590: [keyserver] Show the most recent thread when opening the web app without providing a thread ID.
Fri, Oct 4, 5:09 AM
tomek committed rCOMMfdbf76f01164: [keyserver] Show the most recent thread when opening the web app without… (authored by tomek).
[keyserver] Show the most recent thread when opening the web app without…
Fri, Oct 4, 5:09 AM

Thu, Oct 3

tomek requested review of D13590: [keyserver] Show the most recent thread when opening the web app without providing a thread ID.
Thu, Oct 3, 8:10 AM
tomek closed D13589: [lib] Update the dev invite link URL.
Thu, Oct 3, 7:16 AM
tomek closed D13588: [keyserver] Handle null browser detection result.
Thu, Oct 3, 7:16 AM
tomek committed rCOMM940a7c64b723: [lib] Update the dev invite link URL (authored by tomek).
[lib] Update the dev invite link URL
Thu, Oct 3, 7:16 AM
tomek committed rCOMM9dd69d49de44: [keyserver] Handle null browser detection result (authored by tomek).
[keyserver] Handle null browser detection result
Thu, Oct 3, 7:16 AM
tomek closed D13587: [lib] Bump detect-browser version.
Thu, Oct 3, 7:16 AM
tomek committed rCOMMbbd8bdc414bf: [lib] Bump detect-browser version (authored by tomek).
[lib] Bump detect-browser version
Thu, Oct 3, 7:16 AM
tomek requested review of D13589: [lib] Update the dev invite link URL.
Thu, Oct 3, 4:32 AM
tomek requested review of D13588: [keyserver] Handle null browser detection result.
Thu, Oct 3, 4:25 AM
tomek requested review of D13587: [lib] Bump detect-browser version.
Thu, Oct 3, 4:19 AM
tomek accepted D13585: [native] Fix styling in animation code.

To verify that this formatting is correct we could consider deleting ignore and worker directives, auto-formatting the code, and reintroducing the directives.

Thu, Oct 3, 3:34 AM

Wed, Oct 2

tomek closed D13576: [lib] fix `PushHandler` to support DMs.
Wed, Oct 2, 11:57 AM
tomek committed rCOMMd304b0bc35f4: [lib] fix `PushHandler` to support DMs (authored by kamil).
[lib] fix `PushHandler` to support DMs
Wed, Oct 2, 11:57 AM